erik/erikvancraddock.com
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add the About page #16

Merged
erik merged 2 commits from task-2acaa558-about-page into main 2026-07-30 14:58:18 -05:00
Conversation 1 Commits 2 Files changed 4 +214 -9
erik commented 2026-07-30 14:47:02 -05:00
Owner
Copy link

Summary

  • add a public /about route matching the content hierarchy and presentation of the current erikcraddock.me About page
  • use the configured actor display name, avatar, social accounts, Fediverse handle, and canonical actor URL rather than hardcoded production identity values
  • include the existing Mastodon-style Follow button and dialog in the profile hero
  • adapt the source “people page” reference to this site's existing Contacts terminology
  • remove the redundant source-page “Follow me at” callout in favor of the working Follow interaction
  • add a compact About info icon beside Settings in the shared header and an About link in the footer

Verification

  • npm run build
  • npm run lint
  • npm test (315 tests)
  • browser: desktop layout matches the source hierarchy and profile-card presentation
  • browser: responsive mobile layout stacks the profile hero and controls cleanly
  • browser: configured identity, social accounts, Follow dialog, internal links, and Contacts wording render correctly on port 3011
  • browser: About and Settings header icons render with a compact 4px gap
## Summary - add a public `/about` route matching the content hierarchy and presentation of the current erikcraddock.me About page - use the configured actor display name, avatar, social accounts, Fediverse handle, and canonical actor URL rather than hardcoded production identity values - include the existing Mastodon-style Follow button and dialog in the profile hero - adapt the source “people page” reference to this site's existing Contacts terminology - remove the redundant source-page “Follow me at” callout in favor of the working Follow interaction - add a compact About info icon beside Settings in the shared header and an About link in the footer ## Verification - `npm run build` - `npm run lint` - `npm test` (315 tests) - browser: desktop layout matches the source hierarchy and profile-card presentation - browser: responsive mobile layout stacks the profile hero and controls cleanly - browser: configured identity, social accounts, Follow dialog, internal links, and Contacts wording render correctly on port 3011 - browser: About and Settings header icons render with a compact 4px gap
Add an About page for the site identity
All checks were successful
CI / build-lint-test (push) Successful in 48s
Details
f716ca288b
Add About navigation to the site header
All checks were successful
CI / build-lint-test (push) Successful in 46s
Details
d1fd6e3ac8
erik commented 2026-07-30 14:58:06 -05:00
Author
Owner
Copy link

Review summary

The PR adds a tested /about route that preserves the source page's profile hero, biography, ActivityPub explanation, recommended-sites context, contact guidance, and responsive structure while using this site's configured identity and design system. User-approved adaptations include the existing Follow interaction, Contacts terminology, removal of the redundant handle callout, and compact header/footer navigation.

Acceptance criteria

  • Met — /about is a working public route with canonical metadata and discoverable navigation.
  • Met — Content hierarchy and presentation match the source page, with explicitly approved follow and terminology adaptations.
  • Met — The page reuses configured actor data, shared social icons, public-page styling, header, footer, color mode, and responsive conventions.
  • Met — Build, lint, all 315 tests, focused route tests, desktop browser verification, and mobile browser verification passed.

Blocking issues

  • None.

Warnings

  • None.

Verdict

Approved for merge.

### Review summary The PR adds a tested `/about` route that preserves the source page's profile hero, biography, ActivityPub explanation, recommended-sites context, contact guidance, and responsive structure while using this site's configured identity and design system. User-approved adaptations include the existing Follow interaction, Contacts terminology, removal of the redundant handle callout, and compact header/footer navigation. ### Acceptance criteria - **Met** — `/about` is a working public route with canonical metadata and discoverable navigation. - **Met** — Content hierarchy and presentation match the source page, with explicitly approved follow and terminology adaptations. - **Met** — The page reuses configured actor data, shared social icons, public-page styling, header, footer, color mode, and responsive conventions. - **Met** — Build, lint, all 315 tests, focused route tests, desktop browser verification, and mobile browser verification passed. ### Blocking issues - None. ### Warnings - None. ### Verdict Approved for merge.
erik merged commit 604309779b into main 2026-07-30 14:58:18 -05:00
erik deleted branch task-2acaa558-about-page 2026-07-30 14:58:18 -05:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
erik/erikvancraddock.com!16
No description provided.