erik/kvshare
1
0
Fork 0
Code Issues Pull requests Projects Releases 4 Packages Wiki Activity Actions

Remove machine-specific network configuration from the repo #24

Merged
erik merged 1 commit from chore/task-9ab8ff18-generic-configuration into main 2026-10-17 08:52:30 -05:00
Conversation 1 Commits 1 Files changed 8 +33 -22
erik commented 2026-10-15 19:55:31 -05:00
Owner
Copy link

Summary

Replace machine-specific network values with reserved documentation placeholders so setup is not tied to a particular Mac or workstation.

Task

task-9ab8ff18 — Remove machine-specific configuration from the repo

Changes

  • Use linux-receiver.example in the committed Mac configuration example and Swift test fixtures.
  • Replace actual network values and Mac mini references in setup, specification, and historical verification docs without changing recorded test outcomes.
  • Explain local runtime configuration, required placeholder replacement, and how to switch the permitted Mac IP.
  • Document the policy against committing identifying network values.
  • Leave actual runtime files, receiver authorization behavior, infrastructure URLs, and Git history unchanged.

Testing

  • ./scripts/pre-pr.sh passed: Rust formatting/clippy, 32 Rust tests, Swift lint, macOS app build, 40 Swift tests, release-tooling tests.
  • git diff --check passed.
  • Confirmed no former machine hostname, real subnet addresses, or Mac mini references remain in tracked application config, docs, Swift, and systemd files.
  • Parsed example JSON and checked the reserved placeholder and port.
  • No live machine setup or permission changes performed.

Checklist

  • ./scripts/pre-pr.sh passes
  • Documentation updated
  • No unrelated changes included

Awaiting CI, independent review, and explicit human merge approval.

## Summary Replace machine-specific network values with reserved documentation placeholders so setup is not tied to a particular Mac or workstation. ## Task task-9ab8ff18 — Remove machine-specific configuration from the repo ## Changes - Use linux-receiver.example in the committed Mac configuration example and Swift test fixtures. - Replace actual network values and Mac mini references in setup, specification, and historical verification docs without changing recorded test outcomes. - Explain local runtime configuration, required placeholder replacement, and how to switch the permitted Mac IP. - Document the policy against committing identifying network values. - Leave actual runtime files, receiver authorization behavior, infrastructure URLs, and Git history unchanged. ## Testing - ./scripts/pre-pr.sh passed: Rust formatting/clippy, 32 Rust tests, Swift lint, macOS app build, 40 Swift tests, release-tooling tests. - git diff --check passed. - Confirmed no former machine hostname, real subnet addresses, or Mac mini references remain in tracked application config, docs, Swift, and systemd files. - Parsed example JSON and checked the reserved placeholder and port. - No live machine setup or permission changes performed. ## Checklist - [x] ./scripts/pre-pr.sh passes - [x] Documentation updated - [x] No unrelated changes included Awaiting CI, independent review, and explicit human merge approval.
chore: keep machine-specific network settings out of examples
All checks were successful
CI / Rust build, lint, and test (pull_request) Successful in 1m18s
Details
CI / Swift build, lint, and test (pull_request) Successful in 2m25s
Details
54923a2cfe 
Use reserved documentation values so setup is not tied to a particular Mac or Linux workstation. Document local configuration and switching Macs without changing runtime settings.

Task: #task-9ab8ff18
erik commented 2026-10-15 20:00:34 -05:00
Author
Owner
Copy link

Review update

  • PR: #24 — open.
  • Reviewed commit: 54923a2cfe7db0817dab4ee738171d5a104fc3d7.
  • Summary: The diff removes workstation-specific network values from committed examples, documentation, and Swift fixtures without changing runtime code or receiver authorization behavior.

Acceptance criteria

  • met — Committed receiver configuration and related test fixtures use the generic reserved hostname linux-receiver.example; the existing whitespace-trimming and invalid-port test coverage is preserved.
  • met — macOS setup and specification documentation no longer depend on a particular receiver hostname or Mac mini; setup explains replacing placeholders locally.
  • met — Linux receiver and historical MVP verification documentation omit identifying IP addresses, use a reserved documentation address where appropriate, and preserve recorded verification outcomes.
  • met — Actual machine settings remain local under ~/.config/kvshare/; no runtime configuration files are changed. Documentation explains both local configuration files and updating the permitted Mac source IP.

Criteria: 4 total, 4 met, 0 missing.

Evidence and findings

  • Independently inspected the PR diff and confirmed no former machine hostname, specified real IP addresses, or Mac mini references remain in tracked README/config/docs/Swift/systemd review paths at the reviewed commit.
  • No production logic changes or new test requirements identified. Scope, maintainability, documentation, and security review found no issues.
  • Verification supplied by the primary agent: ./scripts/pre-pr.sh passed; Rust and Swift CI checks passed in run 82 for this commit. Broad tests were not rerun during independent review.
  • Blocking issues: 0.
  • Warnings: 0.

Final verdict

approved. Explicit human merge approval is required. This review does not merge the PR or change task status.

### Review update - PR: https://forge.caradoc.com/erik/kvshare/pulls/24 — open. - Reviewed commit: `54923a2cfe7db0817dab4ee738171d5a104fc3d7`. - Summary: The diff removes workstation-specific network values from committed examples, documentation, and Swift fixtures without changing runtime code or receiver authorization behavior. ### Acceptance criteria - **met** — Committed receiver configuration and related test fixtures use the generic reserved hostname `linux-receiver.example`; the existing whitespace-trimming and invalid-port test coverage is preserved. - **met** — macOS setup and specification documentation no longer depend on a particular receiver hostname or Mac mini; setup explains replacing placeholders locally. - **met** — Linux receiver and historical MVP verification documentation omit identifying IP addresses, use a reserved documentation address where appropriate, and preserve recorded verification outcomes. - **met** — Actual machine settings remain local under `~/.config/kvshare/`; no runtime configuration files are changed. Documentation explains both local configuration files and updating the permitted Mac source IP. Criteria: **4 total, 4 met, 0 missing**. ### Evidence and findings - Independently inspected the PR diff and confirmed no former machine hostname, specified real IP addresses, or Mac mini references remain in tracked README/config/docs/Swift/systemd review paths at the reviewed commit. - No production logic changes or new test requirements identified. Scope, maintainability, documentation, and security review found no issues. - Verification supplied by the primary agent: `./scripts/pre-pr.sh` passed; Rust and Swift CI checks passed in run 82 for this commit. Broad tests were not rerun during independent review. - Blocking issues: **0**. - Warnings: **0**. ### Final verdict **approved**. Explicit human merge approval is required. This review does not merge the PR or change task status.
erik merged commit 81a59aae35 into main 2026-10-17 08:52:30 -05:00
erik deleted branch chore/task-9ab8ff18-generic-configuration 2026-10-17 08:52:30 -05:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
erik/kvshare!24
No description provided.