erik/slugkit
1
0
Fork 0
Code Issues 6 Pull requests Projects Releases 6 Packages Wiki Activity Actions

Add admin ActivityPub actor settings UI #111

Merged
erik merged 1 commit from feat/task-e9ea259f-activitypub-admin-ui into main 2026-06-05 11:07:08 -05:00
Conversation 1 Commits 1 Files changed 7 +686
erik commented 2026-06-05 10:54:11 -05:00
Owner
Copy link

Summary

  • add protected admin ActivityPub actor settings routes and dashboard link
  • add admin page for primary actor create/update, signing key generation, runtime status, setup warnings, and derived handle/URLs
  • keep federation enabled/disabled in runtime config and avoid adding Slugkit management API endpoints for actor settings
  • add route tests for auth protection, create/update, validation, key generation, runtime warnings, and absent API endpoint

Verification

  • make check
  • ./scripts/pre-pr.sh

Task: #task-e9ea259f

## Summary - add protected admin ActivityPub actor settings routes and dashboard link - add admin page for primary actor create/update, signing key generation, runtime status, setup warnings, and derived handle/URLs - keep federation enabled/disabled in runtime config and avoid adding Slugkit management API endpoints for actor settings - add route tests for auth protection, create/update, validation, key generation, runtime warnings, and absent API endpoint ## Verification - [x] `make check` - [x] `./scripts/pre-pr.sh` Task: #task-e9ea259f
feat: add ActivityPub actor admin UI
All checks were successful
CI / build-lint-test (pull_request) Successful in 35s
Details
7d7f9fdc8d 
Task: #task-e9ea259f
erik commented 2026-06-05 10:55:24 -05:00
Author
Owner
Copy link

Review summary

Approved. The PR adds the requested admin-only ActivityPub actor settings UI without exposing actor settings through the Slugkit management API. It uses the existing database-backed actor foundation, keeps federation enabled/disabled in runtime config, supports primary actor create/update and signing-key generation, and includes focused route coverage.

Acceptance criteria

  • Authenticated admins can view the ActivityPub actor settings page.
  • Unauthenticated users cannot access or submit ActivityPub actor settings.
  • Admins can create the primary/default ActivityPub actor when none exists.
  • Admins can update primary actor username, display name, summary, and supported profile metadata.
  • Admins can generate missing actor key material.
  • The page shows the actor handle and canonical ActivityPub URLs derived from the configured actor and public origin.
  • The page shows runtime federation enabled/disabled status without storing that setting in the database.
  • No Slugkit management API endpoint is added for actor settings.
  • Tests cover success, validation errors, key generation, and auth protection.
  • Relevant lint/test checks pass.

Blocking issues

None.

Warnings

None.

Verification reviewed

  • make check passed locally.
  • ./scripts/pre-pr.sh passed locally.
  • Forgejo CI CI / build-lint-test (pull_request) passed.

Verdict

Approved. Stop at human merge approval gate.

## Review summary Approved. The PR adds the requested admin-only ActivityPub actor settings UI without exposing actor settings through the Slugkit management API. It uses the existing database-backed actor foundation, keeps federation enabled/disabled in runtime config, supports primary actor create/update and signing-key generation, and includes focused route coverage. ## Acceptance criteria - [x] Authenticated admins can view the ActivityPub actor settings page. - [x] Unauthenticated users cannot access or submit ActivityPub actor settings. - [x] Admins can create the primary/default ActivityPub actor when none exists. - [x] Admins can update primary actor username, display name, summary, and supported profile metadata. - [x] Admins can generate missing actor key material. - [x] The page shows the actor handle and canonical ActivityPub URLs derived from the configured actor and public origin. - [x] The page shows runtime federation enabled/disabled status without storing that setting in the database. - [x] No Slugkit management API endpoint is added for actor settings. - [x] Tests cover success, validation errors, key generation, and auth protection. - [x] Relevant lint/test checks pass. ## Blocking issues None. ## Warnings None. ## Verification reviewed - `make check` passed locally. - `./scripts/pre-pr.sh` passed locally. - Forgejo CI `CI / build-lint-test (pull_request)` passed. ## Verdict Approved. Stop at human merge approval gate.
erik merged commit 20a72385c2 into main 2026-06-05 11:07:08 -05:00
erik deleted branch feat/task-e9ea259f-activitypub-admin-ui 2026-06-05 11:07:08 -05:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
activitypub

   
admin

   
api

   
articles

   
auth

   
bug

   
cleanup

   
cli

   
comments

   
compatibility

   
config

   
contacts

   
database

   
deployment

   
design

   
dev-env

   
docs

   
documentation

   
email

   
enhancement

   
feature

   
federation

   
feed

   
homepage

   
implementation

   
integration

   
media

   
openapi

   
priority:high

   
priority:low

   
priority:medium

   
proof

   
public-routes

   
public-ui

   
release

   
safety

   
social

   
sources

   
status:active

   
status:canceled

   
status:done

   
status:inprogress

   
status:waiting

   
syndication

   
tailwind

   
template

   
test

   
web
No labels
activitypub
admin
api
articles
auth
bug
cleanup
cli
comments
compatibility
config
contacts
database
deployment
design
dev-env
docs
documentation
email
enhancement
feature
federation
feed
homepage
implementation
integration
media
openapi
priority:high
priority:low
priority:medium
proof
public-routes
public-ui
release
safety
social
sources
status:active
status:canceled
status:done
status:inprogress
status:waiting
syndication
tailwind
template
test
web
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
erik/slugkit!111
No description provided.