erik/slugkit
1
0
Fork 0
Code Issues 6 Pull requests Projects Releases 6 Packages Wiki Activity Actions

Update footer and sidebar navigation #194

New issue
Closed
opened 2026-06-22 13:32:55 -05:00 by erik · 4 comments
erik commented 2026-06-22 13:32:55 -05:00
Owner
Copy link

Goal

Improve site navigation by updating the footer links and making sidebar sections more consistent across pages.

Requirements

  • Update the footer to include links for:
    • Articles
    • Recommended sites
    • Contacts
    • Tags
    • Feed
  • Add footer sections that link to:
    • OpenAPI / Swagger documentation
    • Git repository website
  • Update sidebars to use consistent navigation sections.
  • Ensure the current page’s relevant section appears first in the sidebar.
    • For example, on /tags/{tagname}, the tags section should appear first.

Acceptance criteria

  • Footer includes the requested site navigation links.
  • Footer includes links to OpenAPI / Swagger docs and the Git repository website.
  • Sidebar navigation uses consistent sections across relevant pages.
  • Sidebar prioritizes the current page’s section at the top.
  • /tags/{tagname} shows the tags section first in the sidebar.

Dependencies

  • None
## Goal Improve site navigation by updating the footer links and making sidebar sections more consistent across pages. ## Requirements - Update the footer to include links for: - Articles - Recommended sites - Contacts - Tags - Feed - Add footer sections that link to: - OpenAPI / Swagger documentation - Git repository website - Update sidebars to use consistent navigation sections. - Ensure the current page’s relevant section appears first in the sidebar. - For example, on `/tags/{tagname}`, the tags section should appear first. ## Acceptance criteria - [ ] Footer includes the requested site navigation links. - [ ] Footer includes links to OpenAPI / Swagger docs and the Git repository website. - [ ] Sidebar navigation uses consistent sections across relevant pages. - [ ] Sidebar prioritizes the current page’s section at the top. - [ ] `/tags/{tagname}` shows the tags section first in the sidebar. ## Dependencies - None
erik commented 2026-06-22 13:44:00 -05:00
Author
Owner
Copy link

Synced from todu comment by @todu on 2026-06-22T18:39:06.799Z

PR Review: #195

Summary: Reviewed PR #195 against this task, including task criteria, PR body, diff, and Forgejo Actions #269.

Acceptance criteria:

  • Footer includes requested site navigation links.
  • Footer includes OpenAPI / Swagger docs and Git repository website links.
  • Sidebar navigation uses consistent shared sections across affected pages.
  • Sidebar prioritizes the current page section at the top.
  • /tags/{tagname} shows Tags first in the sidebar.

Verification:

  • PR open and scoped to task.
  • PR body includes task reference, changes, and testing notes.
  • Forgejo Actions #269 succeeded (build-lint-test).

Blocking issues: none.
Warnings: none.

Verdict: approved; awaiting explicit human merge approval.

_Synced from todu comment by @todu on 2026-06-22T18:39:06.799Z_ ## PR Review: #195 Summary: Reviewed PR #195 against this task, including task criteria, PR body, diff, and Forgejo Actions #269. Acceptance criteria: - [x] Footer includes requested site navigation links. - [x] Footer includes OpenAPI / Swagger docs and Git repository website links. - [x] Sidebar navigation uses consistent shared sections across affected pages. - [x] Sidebar prioritizes the current page section at the top. - [x] `/tags/{tagname}` shows Tags first in the sidebar. Verification: - PR open and scoped to task. - PR body includes task reference, changes, and testing notes. - Forgejo Actions #269 succeeded (`build-lint-test`). Blocking issues: none. Warnings: none. Verdict: approved; awaiting explicit human merge approval.
erik commented 2026-06-22 16:18:10 -05:00
Author
Owner
Copy link

Synced from todu comment by @todu on 2026-06-22T21:17:02.534Z

Corrective PR Review: #195

Summary: Re-reviewed PR #195 after commit 0e01d80 using the final human-approved sidebar/footer scope. This supersedes my earlier changes-requested sidebar note.

Acceptance criteria:

  • /feed has a public sidebar without a Feed self-card.
  • /articles, /contacts, /sources, /sources/{id}, and /tags have no public sidebar.
  • /tags/{tag} uses contact-detail-style layout with the tag card left and no public sidebar.
  • Footer Site links are ordered Feed, Articles, Contacts, Tags, Recommended Sites.
  • Footer Resources labels are API Documentation and Source Repository.
  • Settings footer links mirror accessible settings pages and are hidden when unauthenticated.

Verification:

  • Inspected PR diff and updated tests for 0e01d80.
  • Local targeted tests passed: 2 files, 18 tests.
  • Forgejo Actions #270 succeeded (build-lint-test on 0e01d80408).

Blocking issues: none.
Warnings: none.

Verdict: approved; awaiting explicit human merge approval. Do not merge without that approval.

_Synced from todu comment by @todu on 2026-06-22T21:17:02.534Z_ ## Corrective PR Review: #195 Summary: Re-reviewed PR #195 after commit `0e01d80` using the final human-approved sidebar/footer scope. This supersedes my earlier changes-requested sidebar note. Acceptance criteria: - [x] `/feed` has a public sidebar without a Feed self-card. - [x] `/articles`, `/contacts`, `/sources`, `/sources/{id}`, and `/tags` have no public sidebar. - [x] `/tags/{tag}` uses contact-detail-style layout with the tag card left and no public sidebar. - [x] Footer Site links are ordered Feed, Articles, Contacts, Tags, Recommended Sites. - [x] Footer Resources labels are `API Documentation` and `Source Repository`. - [x] Settings footer links mirror accessible settings pages and are hidden when unauthenticated. Verification: - Inspected PR diff and updated tests for `0e01d80`. - Local targeted tests passed: 2 files, 18 tests. - Forgejo Actions #270 succeeded (`build-lint-test` on `0e01d80408`). Blocking issues: none. Warnings: none. Verdict: approved; awaiting explicit human merge approval. Do not merge without that approval.
erik commented 2026-06-22 16:18:10 -05:00
Author
Owner
Copy link

Synced from todu comment by @todu on 2026-06-22T21:14:30.005Z

PR Review: #195

Summary: Reviewed task criteria, PR body/diff after 0e01d80, local targeted tests, and Forgejo Actions #270 (build-lint-test, success).

Acceptance criteria:

  • Footer includes the requested site navigation links.
  • Footer includes OpenAPI / Swagger docs and Git repository website links.
  • Sidebar navigation uses consistent sections across relevant pages.
  • Sidebar prioritizes the current page’s section at the top.
  • /tags/{tagname} shows the tags section first in the sidebar.

Blocking issues:

  1. Sidebar criteria remain incomplete: PublicSidebar is only used for feed content and its links omit Feed, while /tags/{tagname} renders only a TagCard instead of a consistent sidebar with Tags first plus the shared navigation sections.

Warnings: none.

Verification:

  • PR open and scoped to task.
  • PR body includes task reference, changes, and verification notes.
  • Local targeted tests passed: 2 files, 18 tests.
  • Forgejo Actions #270 succeeded.

Verdict: changes requested; do not merge.

_Synced from todu comment by @todu on 2026-06-22T21:14:30.005Z_ ## PR Review: #195 Summary: Reviewed task criteria, PR body/diff after `0e01d80`, local targeted tests, and Forgejo Actions #270 (`build-lint-test`, success). Acceptance criteria: - [x] Footer includes the requested site navigation links. - [x] Footer includes OpenAPI / Swagger docs and Git repository website links. - [ ] Sidebar navigation uses consistent sections across relevant pages. - [ ] Sidebar prioritizes the current page’s section at the top. - [ ] `/tags/{tagname}` shows the tags section first in the sidebar. Blocking issues: 1. Sidebar criteria remain incomplete: `PublicSidebar` is only used for feed content and its links omit Feed, while `/tags/{tagname}` renders only a `TagCard` instead of a consistent sidebar with Tags first plus the shared navigation sections. Warnings: none. Verification: - PR open and scoped to task. - PR body includes task reference, changes, and verification notes. - Local targeted tests passed: 2 files, 18 tests. - Forgejo Actions #270 succeeded. Verdict: changes requested; do not merge.
erik 2026-06-22 16:23:42 -05:00
erik commented 2026-06-22 16:23:42 -05:00
Author
Owner
Copy link

Synced from todu comment by @todu on 2026-06-22T21:18:25.867Z

Closing summary

Merged PR #195 into main.

Final implemented scope followed the user-refined navigation decisions:

  • Footer Site links include Feed, Articles, Contacts, Tags, and Recommended Sites in the requested order.
  • Footer Resources links point to API docs and the source repository, labeled API Documentation and Source Repository.
  • Footer Settings section mirrors accessible settings pages: hidden when unauthenticated, viewer links for General/Passkeys/API keys, and admin links for Site users/Actor.
  • /feed retains a public sidebar but removes the Feed self-card.
  • /articles, /contacts, /sources, /sources/{id}, and /tags have no public sidebar.
  • /tags/{tag} uses a contact-detail-style layout with the tag card in the left rail and feed-style tagged posts on the right.

Verification:

  • npm exec --workspace @slugkit/template-site -- vitest run --config ../../vitest.config.ts src/routes/__tests__/public.test.ts src/__tests__/app.test.ts passed.
  • ./scripts/pre-pr.sh passed.
  • npm run build && npm run lint && npm test passed.
  • Forgejo Actions #270 passed on commit 0e01d80.
  • Corrective PR review approved with no blockers.
_Synced from todu comment by @todu on 2026-06-22T21:18:25.867Z_ ## Closing summary Merged PR #195 into `main`. Final implemented scope followed the user-refined navigation decisions: - Footer Site links include Feed, Articles, Contacts, Tags, and Recommended Sites in the requested order. - Footer Resources links point to API docs and the source repository, labeled `API Documentation` and `Source Repository`. - Footer Settings section mirrors accessible settings pages: hidden when unauthenticated, viewer links for General/Passkeys/API keys, and admin links for Site users/Actor. - `/feed` retains a public sidebar but removes the Feed self-card. - `/articles`, `/contacts`, `/sources`, `/sources/{id}`, and `/tags` have no public sidebar. - `/tags/{tag}` uses a contact-detail-style layout with the tag card in the left rail and feed-style tagged posts on the right. Verification: - `npm exec --workspace @slugkit/template-site -- vitest run --config ../../vitest.config.ts src/routes/__tests__/public.test.ts src/__tests__/app.test.ts` passed. - `./scripts/pre-pr.sh` passed. - `npm run build && npm run lint && npm test` passed. - Forgejo Actions #270 passed on commit `0e01d80`. - Corrective PR review approved with no blockers.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
release/slug-cli-v0.5.0
release/slug-cli-v0.4.0
release/slug-cli-v0.3.0
release/slug-cli-v0.2.0
release/slug-cli-v0.1.2
release/slug-cli-v0.1.1
feat/task-47be19ea-api-meta-route
feat/task-51eaa27f-swagger-api-docs
feat/task-0dbd25d3-site-config-homepage
feat/task-69937fe4-sqlite-migrations
feat/task-a3cd5595-cli-foundation
feat/task-c272cbda-openapi-health
feat/task-d6397b57-template-foundation
v0.5.0
v0.4.0
v0.3.0
v0.2.0
v0.1.2
v0.1.1
Labels
Clear labels   
activitypub

   
admin

   
api

   
articles

   
auth

   
bug

   
cleanup

   
cli

   
comments

   
compatibility

   
config

   
contacts

   
database

   
deployment

   
design

   
dev-env

   
docs

   
documentation

   
email

   
enhancement

   
feature

   
federation

   
feed

   
homepage

   
implementation

   
integration

   
media

   
openapi

   
priority:high

   
priority:low

   
priority:medium

   
proof

   
public-routes

   
public-ui

   
release

   
safety

   
social

   
sources

   
status:active

   
status:canceled

   
status:done

   
status:inprogress

   
status:waiting

   
syndication

   
tailwind

   
template

   
test

   
web
No labels
activitypub
admin
api
articles
auth
bug
cleanup
cli
comments
compatibility
config
contacts
database
deployment
design
dev-env
docs
documentation
email
enhancement
feature
federation
feed
homepage
implementation
integration
media
openapi
priority:high
priority:low
priority:medium
proof
public-routes
public-ui
release
safety
social
sources
status:active
status:canceled
status:done
status:inprogress
status:waiting
syndication
tailwind
template
test
web
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
erik/slugkit#194
No description provided.