erik/slugkit
1
0
Fork 0
Code Issues 4 Pull requests Projects Releases 17 Packages Wiki Activity Actions

Fix npm package release metadata parsing #241

Merged
erik merged 1 commit from fix/task-059991ea-release-workflow-json into main 2026-06-29 09:17:37 -05:00
Conversation 1 Commits 1 Files changed 1 +1 -1
erik commented 2026-06-29 09:16:00 -05:00
Owner
Copy link

Summary

  • Fix the npm package release workflow metadata step to call node scripts/release-npm-package.mjs directly.
  • Avoid npm run banner output contaminating the JSON metadata file.

Verification

  • ./scripts/pre-pr.sh

Task: #task-059991ea

## Summary - Fix the npm package release workflow metadata step to call `node scripts/release-npm-package.mjs` directly. - Avoid `npm run` banner output contaminating the JSON metadata file. ## Verification - `./scripts/pre-pr.sh` Task: #task-059991ea
fix: parse package release metadata JSON
All checks were successful
CI / build-lint-test (pull_request) Successful in 53s
Details
a35a772651 
Task: #task-059991ea
erik commented 2026-06-29 09:17:37 -05:00
Author
Owner
Copy link

Review summary

Approved. The workflow now writes clean JSON metadata by invoking the release helper directly instead of through npm run.

Acceptance criteria impact

  • Fixes the failed Resolve package metadata step.
  • Avoids npm script banner output in the JSON metadata file.
  • Pre-PR checks and Forgejo CI passed.

Blocking issues

None.

Warnings

None.

Verdict

Approved.

## Review summary Approved. The workflow now writes clean JSON metadata by invoking the release helper directly instead of through `npm run`. ## Acceptance criteria impact - [x] Fixes the failed `Resolve package metadata` step. - [x] Avoids npm script banner output in the JSON metadata file. - [x] Pre-PR checks and Forgejo CI passed. ## Blocking issues None. ## Warnings None. ## Verdict Approved.
erik merged commit eaa3e09f56 into main 2026-06-29 09:17:37 -05:00
erik deleted branch fix/task-059991ea-release-workflow-json 2026-06-29 09:17:37 -05:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
activitypub

   
admin

   
api

   
architecture

   
articles

   
auth

   
bug

   
cleanup

   
cli

   
comments

   
compatibility

   
config

   
contacts

   
content

   
database

   
deployment

   
design

   
dev-env

   
diagnostics

   
docs

   
documentation

   
email

   
enhancement

   
feature

   
federation

   
feed

   
health

   
homepage

   
implementation

   
integration

   
logging

   
mastodon

   
media

   
navigation

   
npm-packages

   
openapi

   
opengraph

   
packages

   
passkeys

   
preview

   
priority:high

   
priority:low

   
priority:medium

   
production

   
proof

   
proxy

   
public-routes

   
public-ui

   
release

   
safety

   
slug-api

   
slug-auth

   
slug-core

   
slug-federation

   
slug-media

   
slug-template

   
social

   
sources

   
status:active

   
status:canceled

   
status:done

   
status:inprogress

   
status:waiting

   
syndication

   
tailwind

   
template

   
test

   
web

   
webauthn
No labels
activitypub
admin
api
architecture
articles
auth
bug
cleanup
cli
comments
compatibility
config
contacts
content
database
deployment
design
dev-env
diagnostics
docs
documentation
email
enhancement
feature
federation
feed
health
homepage
implementation
integration
logging
mastodon
media
navigation
npm-packages
openapi
opengraph
packages
passkeys
preview
priority:high
priority:low
priority:medium
production
proof
proxy
public-routes
public-ui
release
safety
slug-api
slug-auth
slug-core
slug-federation
slug-media
slug-template
social
sources
status:active
status:canceled
status:done
status:inprogress
status:waiting
syndication
tailwind
template
test
web
webauthn
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
erik/slugkit!241
No description provided.