Add full public sidebar to link pages #258

Merged

erik merged 1 commit from feat/task-3389b3bd-link-page-sidebar into main

2026-07-16 19:47:32 -05:00

erik commented

2026-07-16 19:29:39 -05:00

Owner

Summary

render link details in the shared Feed sidebar shell
reuse the rich external preview on link details
cover sidebar and external-preview rendering

Verification

./scripts/pre-pr.sh

Task: task-3389b3bd

## Summary - render link details in the shared Feed sidebar shell - reuse the rich external preview on link details - cover sidebar and external-preview rendering ## Verification - ./scripts/pre-pr.sh Task: task-3389b3bd

erik added 1 commit

2026-07-16 19:29:39 -05:00

feat: add link detail sidebar

CI / build-lint-test (pull_request) Successful in 2m8s

Details

15d8fe0ba1

Task: #task-3389b3bd

erik commented

2026-07-16 19:32:09 -05:00

Author

Owner

Review summary

The shared sidebar and rich preview are correctly reused for link detail pages, and CI is green. However, the task requires responsive visual coverage for complete and sparse link posts, plus explicit coverage for mobile order, missing preview/attribution fallbacks, accessibility order, overflow, and shared sidebar consistency across Feed, article, and link variants. Those artifacts are not included in this PR.

Acceptance criteria

Desktop two-column link detail shell and sticky sidebar.
Sidebar profile and Articles, Recommended Sites, and Tags navigation.
Shared rich preview replaces the standalone external link.
Safe external-link rel behavior.
Canonical local detail URL is preserved.
Mobile ordering, keyboard/screen-reader order, and responsive overflow coverage.
Complete and sparse preview/attribution fallback coverage.
Shared sidebar regression coverage across Feed, article, and link variants.
Light and dark visual regression coverage at mobile and desktop widths.

Blocking issues

Required responsive and visual regression coverage is missing.

Warnings

None.

Verdict

Changes requested.

## Review summary The shared sidebar and rich preview are correctly reused for link detail pages, and CI is green. However, the task requires responsive visual coverage for complete and sparse link posts, plus explicit coverage for mobile order, missing preview/attribution fallbacks, accessibility order, overflow, and shared sidebar consistency across Feed, article, and link variants. Those artifacts are not included in this PR. ## Acceptance criteria - [x] Desktop two-column link detail shell and sticky sidebar. - [x] Sidebar profile and Articles, Recommended Sites, and Tags navigation. - [x] Shared rich preview replaces the standalone external link. - [x] Safe external-link `rel` behavior. - [x] Canonical local detail URL is preserved. - [ ] Mobile ordering, keyboard/screen-reader order, and responsive overflow coverage. - [ ] Complete and sparse preview/attribution fallback coverage. - [ ] Shared sidebar regression coverage across Feed, article, and link variants. - [ ] Light and dark visual regression coverage at mobile and desktop widths. ## Blocking issues - Required responsive and visual regression coverage is missing. ## Warnings - None. ## Verdict Changes requested.

erik force-pushed feat/task-3389b3bd-link-page-sidebar from 15d8fe0ba1

CI / build-lint-test (pull_request) Successful in 2m8s

Details

to 423fdb4d58

CI / build-lint-test (pull_request) Successful in 2m12s

Details

2026-07-16 19:44:35 -05:00

Compare

erik merged commit 461e594438 into main

2026-07-16 19:47:32 -05:00

erik referenced this pull request from a commit

2026-07-16 19:47:34 -05:00