erik/slugkit

Fork 0

Add the full public sidebar to article pages #260

Merged

erik merged 2 commits from feat/task-1c42dad6-article-sidebar into main

2026-07-16 20:30:29 -05:00

erik commented

2026-07-16 20:14:50 -05:00

Owner

Summary

Article detail pages now reuse the complete Feed sidebar in a responsive two-column shell while keeping article content first in mobile and assistive-technology reading order.

Task

Task: task-1c42dad6

Changes

Reuse the shared profile and navigation sidebar on article details.
Keep the article first on mobile and place a sticky sidebar to its left on desktop.
Cover complete actor data, missing actor data, navigation parity, ordering, sticky behavior, and overflow.
Add short and long article visual checks in light and dark modes at mobile, tablet, and desktop widths.

Testing

Unit tests added/updated
Manual responsive behavior verified through Playwright geometry checks
npm run test:visual
./scripts/pre-pr.sh

Checklist

./scripts/pre-pr.sh passes
Documentation updated (not needed)
No unrelated changes included

## Summary Article detail pages now reuse the complete Feed sidebar in a responsive two-column shell while keeping article content first in mobile and assistive-technology reading order. ## Task Task: task-1c42dad6 ## Changes - Reuse the shared profile and navigation sidebar on article details. - Keep the article first on mobile and place a sticky sidebar to its left on desktop. - Cover complete actor data, missing actor data, navigation parity, ordering, sticky behavior, and overflow. - Add short and long article visual checks in light and dark modes at mobile, tablet, and desktop widths. ## Testing - [x] Unit tests added/updated - [x] Manual responsive behavior verified through Playwright geometry checks - [x] `npm run test:visual` - [x] `./scripts/pre-pr.sh` ## Checklist - [x] `./scripts/pre-pr.sh` passes - [x] Documentation updated (not needed) - [x] No unrelated changes included

erik added 1 commit

2026-07-16 20:14:50 -05:00

feat: add article detail sidebar

CI / build-lint-test (pull_request) Successful in 2m11s

Details

90255b889b

Task: #task-1c42dad6

erik commented

2026-07-16 20:18:16 -05:00

Author

Owner

Review summary

The shared sidebar implementation is scoped and well-tested across responsive breakpoints, but the PR does not yet satisfy every acceptance criterion for this task.

Acceptance criteria

Met: Desktop article pages use the full shared Feed sidebar in a balanced two-column shell.
Partial: The sidebar is sticky with the expected header offset, but the tests do not verify its behavior near the footer.
Not evident: The readable main-column and wide-hero behavior defined by task-cb862b58 is not implemented or verified in this PR.
Met: Mobile pages render article content before the complete sidebar.
Met: Profile, social, count, Articles, Recommended Sites, and Tags content is covered through shared rendering tests and the responsive layout.
Partial: Article-first DOM order matches mobile visual intent, but desktop assistive-technology versus visual ordering is not explicitly verified.
Met: Missing actor images, social accounts, and follower counts are covered.
Met: Mobile, tablet, and desktop visual tests check horizontal overflow.
Met: Feed and article pages assert the same shared sidebar marker.
Met: Visual coverage includes short and long articles in light and dark modes at mobile and desktop widths, with tablet coverage added as well.

Blocking issues

Complete or integrate the article wide-hero/readable-column behavior required by task-cb862b58, or formally make that task a prerequisite before this task can pass its acceptance criteria.

Warnings

Extend the sticky-sidebar visual test to scroll near the footer and verify that the sidebar does not overlap it.

Verdict

Changes requested. CI is green, but the task acceptance criteria are not all satisfied.

### Review summary The shared sidebar implementation is scoped and well-tested across responsive breakpoints, but the PR does not yet satisfy every acceptance criterion for this task. ### Acceptance criteria - **Met:** Desktop article pages use the full shared Feed sidebar in a balanced two-column shell. - **Partial:** The sidebar is sticky with the expected header offset, but the tests do not verify its behavior near the footer. - **Not evident:** The readable main-column and wide-hero behavior defined by `task-cb862b58` is not implemented or verified in this PR. - **Met:** Mobile pages render article content before the complete sidebar. - **Met:** Profile, social, count, Articles, Recommended Sites, and Tags content is covered through shared rendering tests and the responsive layout. - **Partial:** Article-first DOM order matches mobile visual intent, but desktop assistive-technology versus visual ordering is not explicitly verified. - **Met:** Missing actor images, social accounts, and follower counts are covered. - **Met:** Mobile, tablet, and desktop visual tests check horizontal overflow. - **Met:** Feed and article pages assert the same shared sidebar marker. - **Met:** Visual coverage includes short and long articles in light and dark modes at mobile and desktop widths, with tablet coverage added as well. ### Blocking issues - Complete or integrate the article wide-hero/readable-column behavior required by `task-cb862b58`, or formally make that task a prerequisite before this task can pass its acceptance criteria. ### Warnings - Extend the sticky-sidebar visual test to scroll near the footer and verify that the sidebar does not overlap it. ### Verdict **Changes requested.** CI is green, but the task acceptance criteria are not all satisfied.

erik added 1 commit

2026-07-16 20:26:14 -05:00

test: verify sidebar clears footer

CI / build-lint-test (pull_request) Successful in 2m7s

Details

74422ba6bd

Task: #task-1c42dad6

erik commented

2026-07-16 20:28:57 -05:00

Author

Owner

Review summary

The updated task scope matches the implemented sidebar-first article layout, the previous wide-hero blocker has been removed from this task, and the footer-overlap test closes the remaining verification gap.

Acceptance criteria

Met: Desktop article pages use the complete shared Feed sidebar and a balanced two-column shell.
Met: The desktop sidebar uses the header offset, and responsive tests verify it does not overlap the footer after scrolling.
Met: Article content and images remain inside the min-width-protected main column beside the sidebar.
Met: Mobile and tablet layouts render article content before the full sidebar.
Met: Profile, social, count, Articles, Recommended Sites, and Tags content is covered through shared rendering tests.
Met: Article-first DOM order preserves the intended keyboard and screen-reader flow while desktop grid placement remains visual-only.
Met: Missing actor images, social accounts, and follower counts are covered.
Met: Responsive tests verify no horizontal overflow at mobile, tablet, and desktop widths.
Met: Feed and article variants render the same marked shared sidebar component.
Met: Visual coverage includes short and long articles in light and dark modes at mobile and desktop widths, plus tablet coverage.

Blocking issues

None.

Warnings

None.

Verdict

Approved. CI passed for commit 74422ba6bd, and all updated acceptance criteria are evidenced by the implementation and tests.

### Review summary The updated task scope matches the implemented sidebar-first article layout, the previous wide-hero blocker has been removed from this task, and the footer-overlap test closes the remaining verification gap. ### Acceptance criteria - **Met:** Desktop article pages use the complete shared Feed sidebar and a balanced two-column shell. - **Met:** The desktop sidebar uses the header offset, and responsive tests verify it does not overlap the footer after scrolling. - **Met:** Article content and images remain inside the min-width-protected main column beside the sidebar. - **Met:** Mobile and tablet layouts render article content before the full sidebar. - **Met:** Profile, social, count, Articles, Recommended Sites, and Tags content is covered through shared rendering tests. - **Met:** Article-first DOM order preserves the intended keyboard and screen-reader flow while desktop grid placement remains visual-only. - **Met:** Missing actor images, social accounts, and follower counts are covered. - **Met:** Responsive tests verify no horizontal overflow at mobile, tablet, and desktop widths. - **Met:** Feed and article variants render the same marked shared sidebar component. - **Met:** Visual coverage includes short and long articles in light and dark modes at mobile and desktop widths, plus tablet coverage. ### Blocking issues - None. ### Warnings - None. ### Verdict **Approved.** CI passed for commit `74422ba6bd`, and all updated acceptance criteria are evidenced by the implementation and tests.

erik merged commit a5ffce8c4f into main

2026-07-16 20:30:29 -05:00

erik deleted branch feat/task-1c42dad6-article-sidebar

2026-07-16 20:30:29 -05:00

erik referenced this pull request from a commit

2026-07-16 20:30:30 -05:00

Merge pull request 'Add the full public sidebar to article pages' (#260) from feat/task-1c42dad6-article-sidebar into main