erik/slugkit
1
0
Fork 0
Code Issues 6 Pull requests Projects Releases 6 Packages Wiki Activity Actions

Add DB-backed site configuration #47

New issue
Closed
opened 2026-05-22 09:25:56 -05:00 by erik · 2 comments
erik commented 2026-05-22 09:25:56 -05:00
Owner
Copy link

Goal

Persist site configuration in SQLite and expose a small manually testable read path without replacing the file-based template defaults.

Requirements

  • Add the smallest site configuration table needed for persisted site identity and homepage settings.
  • Add migration(s) using the existing migration foundation.
  • Add service logic to read persisted config with file/default fallback behavior.
  • Add one manually testable route or command that proves persisted config is read.
  • Keep the PR as a small vertical slice.

Acceptance criteria

  • Migration creates the persisted site configuration table from scratch.
  • Tests use isolated databases.
  • Persisted config can be read through a manually testable path.
  • File/default config still works when no DB config exists.
  • Relevant lint/test checks pass.

Dependencies

  • task-0dbd25d3
  • task-69937fe4
## Goal Persist site configuration in SQLite and expose a small manually testable read path without replacing the file-based template defaults. ## Requirements - Add the smallest site configuration table needed for persisted site identity and homepage settings. - Add migration(s) using the existing migration foundation. - Add service logic to read persisted config with file/default fallback behavior. - Add one manually testable route or command that proves persisted config is read. - Keep the PR as a small vertical slice. ## Acceptance criteria - [ ] Migration creates the persisted site configuration table from scratch. - [ ] Tests use isolated databases. - [ ] Persisted config can be read through a manually testable path. - [ ] File/default config still works when no DB config exists. - [ ] Relevant lint/test checks pass. ## Dependencies - task-0dbd25d3 - task-69937fe4
erik commented 2026-05-22 17:10:36 -05:00
Author
Owner
Copy link

Synced from todu comment by @todu on 2026-05-22T22:08:49.102Z

PR Review: Approved

PR: #62

Summary

Reviewed PR #62 at commit 1223eeb. The PR adds a small site_config migration, a DB-first/file-fallback site config reader, homepage and API metadata wiring for migrated runtime databases, isolated tests, and documentation for manually verifying persisted config reads.

Acceptance Criteria

  • Migration creates the persisted site configuration table from scratch.
  • Tests use isolated databases.
  • Persisted config can be read through a manually testable path.
  • File/default config still works when no DB config exists.
  • Relevant lint/test checks pass: make check, ./scripts/pre-pr.sh, and Forgejo CI passed.

Blocking Issues

None.

Warnings

None.

Verdict

Approved for merge after explicit human approval.

_Synced from todu comment by @todu on 2026-05-22T22:08:49.102Z_ ## PR Review: Approved PR: https://forge.caradoc.com/erik/slugkit/pulls/62 ### Summary Reviewed PR #62 at commit `1223eeb`. The PR adds a small `site_config` migration, a DB-first/file-fallback site config reader, homepage and API metadata wiring for migrated runtime databases, isolated tests, and documentation for manually verifying persisted config reads. ### Acceptance Criteria - [x] Migration creates the persisted site configuration table from scratch. - [x] Tests use isolated databases. - [x] Persisted config can be read through a manually testable path. - [x] File/default config still works when no DB config exists. - [x] Relevant lint/test checks pass: `make check`, `./scripts/pre-pr.sh`, and Forgejo CI passed. ### Blocking Issues None. ### Warnings None. ### Verdict Approved for merge after explicit human approval.
erik 2026-05-22 17:26:25 -05:00
erik commented 2026-05-22 17:26:26 -05:00
Author
Owner
Copy link

Synced from todu comment by @todu on 2026-05-22T22:23:36.242Z

Closing Summary

PR #62 merged: #62

Acceptance criteria evidence:

  • Migration creates the persisted site configuration table from scratch: met — template/site/src/db/migrations/003_site_config.sql creates site_config; migration tests apply template migrations from an empty database and assert the table exists.
  • Tests use isolated databases: met — config/app tests use :memory: SQLite databases with cleanup; migration tests use temporary directories/databases.
  • Persisted config can be read through a manually testable path: met — readSiteConfig() reads the site_config row; / and /api/v1/meta use DB-backed config when the runtime app is started with a migrated database; README documents manual verification.
  • File/default config still works when no DB config exists: met — readSiteConfig() returns src/config/site.ts defaults without a DB or without a persisted row; tests cover both fallback cases.
  • Relevant lint/test checks pass: met — make check, ./scripts/pre-pr.sh, PR review, and Forgejo CI passed.

Readiness: READY

_Synced from todu comment by @todu on 2026-05-22T22:23:36.242Z_ ## Closing Summary PR #62 merged: https://forge.caradoc.com/erik/slugkit/pulls/62 Acceptance criteria evidence: - Migration creates the persisted site configuration table from scratch: met — `template/site/src/db/migrations/003_site_config.sql` creates `site_config`; migration tests apply template migrations from an empty database and assert the table exists. - Tests use isolated databases: met — config/app tests use `:memory:` SQLite databases with cleanup; migration tests use temporary directories/databases. - Persisted config can be read through a manually testable path: met — `readSiteConfig()` reads the `site_config` row; `/` and `/api/v1/meta` use DB-backed config when the runtime app is started with a migrated database; README documents manual verification. - File/default config still works when no DB config exists: met — `readSiteConfig()` returns `src/config/site.ts` defaults without a DB or without a persisted row; tests cover both fallback cases. - Relevant lint/test checks pass: met — `make check`, `./scripts/pre-pr.sh`, PR review, and Forgejo CI passed. Readiness: READY
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
release/slug-cli-v0.5.0
release/slug-cli-v0.4.0
release/slug-cli-v0.3.0
release/slug-cli-v0.2.0
release/slug-cli-v0.1.2
release/slug-cli-v0.1.1
feat/task-47be19ea-api-meta-route
feat/task-51eaa27f-swagger-api-docs
feat/task-0dbd25d3-site-config-homepage
feat/task-69937fe4-sqlite-migrations
feat/task-a3cd5595-cli-foundation
feat/task-c272cbda-openapi-health
feat/task-d6397b57-template-foundation
v0.5.0
v0.4.0
v0.3.0
v0.2.0
v0.1.2
v0.1.1
Labels
Clear labels   
activitypub

   
admin

   
api

   
articles

   
auth

   
bug

   
cleanup

   
cli

   
comments

   
compatibility

   
config

   
contacts

   
database

   
deployment

   
design

   
dev-env

   
docs

   
documentation

   
email

   
enhancement

   
feature

   
federation

   
feed

   
homepage

   
implementation

   
integration

   
media

   
openapi

   
priority:high

   
priority:low

   
priority:medium

   
proof

   
public-routes

   
public-ui

   
release

   
safety

   
social

   
sources

   
status:active

   
status:canceled

   
status:done

   
status:inprogress

   
status:waiting

   
syndication

   
tailwind

   
template

   
test

   
web
No labels
activitypub
admin
api
articles
auth
bug
cleanup
cli
comments
compatibility
config
contacts
database
deployment
design
dev-env
docs
documentation
email
enhancement
feature
federation
feed
homepage
implementation
integration
media
openapi
priority:high
priority:low
priority:medium
proof
public-routes
public-ui
release
safety
social
sources
status:active
status:canceled
status:done
status:inprogress
status:waiting
syndication
tailwind
template
test
web
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
erik/slugkit#47
No description provided.