erik/erikvancraddock.com
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Publish actor creation and update timestamps #13

Merged
erik merged 2 commits from task-7638ca9f-actor-timestamps into main 2026-07-30 12:12:34 -05:00
Conversation 1 Commits 2 Files changed 4 +68 -7
erik commented 2026-07-30 12:06:40 -05:00
Owner
Copy link

Summary

  • publish the actor's persisted creation time as ActivityPub published
  • publish the latest actor, profile-settings, or social-account change as ActivityPub updated
  • include both timestamps in public actor documents and outbound actor Update activities

Verification

  • npm run build
  • npm run lint
  • npm test (311 tests)
  • focused actor route, persistence, and settings delivery tests (48 tests)
## Summary - publish the actor's persisted creation time as ActivityPub `published` - publish the latest actor, profile-settings, or social-account change as ActivityPub `updated` - include both timestamps in public actor documents and outbound actor `Update` activities ## Verification - `npm run build` - `npm run lint` - `npm test` (311 tests) - focused actor route, persistence, and settings delivery tests (48 tests)
Publish actor creation and update timestamps
All checks were successful
CI / build-lint-test (push) Successful in 49s
Details
78112c1a9f
Use generic actor timestamp fixtures
All checks were successful
CI / build-lint-test (push) Successful in 55s
Details
de0d89fc3c
erik commented 2026-07-30 12:10:13 -05:00
Author
Owner
Copy link

Review summary

The PR maps persisted actor creation time to ActivityPub published and computes updated from the newest actor, profile-settings, or social-account timestamp. The shared actor document feeds both the public endpoint and outbound actor Update activities, so both paths receive identical timestamps. Tests use generic actor and URL fixtures.

Acceptance criteria

  • Met — Public actor documents include persisted published timestamps.
  • Met — updated reflects the newest actor, profile-settings, or account timestamp.
  • Met — Outbound actor Update payloads contain both timestamps.
  • Pending production verification — Mastodon joined date requires merge, release, deployment, and a production actor update.
  • Met — Actor endpoint and outbound-update tests use generic fixture data.
  • Met — Build, lint, all 311 tests, focused tests, and Forgejo CI run 43 passed.

Blocking issues

  • None.

Warnings

  • Production Mastodon joined-date correction must be verified after deployment before task closure.

Verdict

Approved for merge.

### Review summary The PR maps persisted actor creation time to ActivityPub `published` and computes `updated` from the newest actor, profile-settings, or social-account timestamp. The shared actor document feeds both the public endpoint and outbound actor `Update` activities, so both paths receive identical timestamps. Tests use generic actor and URL fixtures. ### Acceptance criteria - **Met** — Public actor documents include persisted `published` timestamps. - **Met** — `updated` reflects the newest actor, profile-settings, or account timestamp. - **Met** — Outbound actor `Update` payloads contain both timestamps. - **Pending production verification** — Mastodon joined date requires merge, release, deployment, and a production actor update. - **Met** — Actor endpoint and outbound-update tests use generic fixture data. - **Met** — Build, lint, all 311 tests, focused tests, and Forgejo CI run 43 passed. ### Blocking issues - None. ### Warnings - Production Mastodon joined-date correction must be verified after deployment before task closure. ### Verdict Approved for merge.
erik merged commit 0c1e80c647 into main 2026-07-30 12:12:34 -05:00
erik deleted branch task-7638ca9f-actor-timestamps 2026-07-30 12:12:34 -05:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
erik/erikvancraddock.com!13
No description provided.