erik/erikvancraddock.com
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Honor APP_PORT from local environment #2

Merged
erik merged 1 commit from task-935ff05c-configure-app-port into main 2026-07-26 06:31:53 -05:00
Conversation 1 Commits 1 Files changed 7 +52 -20
erik commented 2026-07-26 00:55:20 -05:00
Owner
Copy link

Summary

  • isolate application port parsing behind APP_PORT with a generic default
  • stop Procfile and Makefile defaults from overriding values loaded from .env
  • document APP_PORT behavior and add focused runtime tests

Verification

  • npm test (304 tests passed)
  • npm run build
  • restarted the Overmind development process and verified health on APP_PORT=3011
  • confirmed no site profile URL changes
## Summary - isolate application port parsing behind APP_PORT with a generic default - stop Procfile and Makefile defaults from overriding values loaded from .env - document APP_PORT behavior and add focused runtime tests ## Verification - npm test (304 tests passed) - npm run build - restarted the Overmind development process and verified health on APP_PORT=3011 - confirmed no site profile URL changes
erik commented 2026-07-26 00:55:50 -05:00
Author
Owner
Copy link

Review summary

The runtime now reads APP_PORT without allowing Overmind's reserved PORT value or Procfile defaults to override local .env configuration. The generic default remains 3000, documentation is updated, and site profile URLs are untouched.

Acceptance criteria

  • Met: APP_PORT=3011 was verified by restarting the development environment and reaching the health endpoint on port 3011.
  • Met: Omitting APP_PORT returns the documented generic default of 3000.
  • Met: The Procfile no longer assigns APP_PORT, allowing .env to control the runtime port.
  • Met: Runtime tests use configurable inputs rather than a site-specific expected port.
  • Met: All 304 tests and the build passed.

Blocking issues

  • None.

Warnings

  • None.

Verdict

Approved

### Review summary The runtime now reads `APP_PORT` without allowing Overmind's reserved `PORT` value or Procfile defaults to override local `.env` configuration. The generic default remains 3000, documentation is updated, and site profile URLs are untouched. ### Acceptance criteria - [x] **Met:** `APP_PORT=3011` was verified by restarting the development environment and reaching the health endpoint on port 3011. - [x] **Met:** Omitting `APP_PORT` returns the documented generic default of 3000. - [x] **Met:** The Procfile no longer assigns `APP_PORT`, allowing `.env` to control the runtime port. - [x] **Met:** Runtime tests use configurable inputs rather than a site-specific expected port. - [x] **Met:** All 304 tests and the build passed. ### Blocking issues - None. ### Warnings - None. ### Verdict **Approved**
erik merged commit 9ad55fd270 into main 2026-07-26 06:31:53 -05:00
erik deleted branch task-935ff05c-configure-app-port 2026-07-26 06:31:53 -05:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
erik/erikvancraddock.com!2
No description provided.