erik/erikvancraddock.com
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Run CI checks on every branch commit #3

Merged
erik merged 3 commits from task-c3e4a44f-run-ci-checks into main 2026-07-27 07:10:30 -05:00
Conversation 2 Commits 3 Files changed 4 +1453 -1
erik commented 2026-07-27 06:59:16 -05:00
Owner
Copy link

Summary

  • run Forgejo CI for every branch push
  • build, lint, and test in explicit workflow steps
  • add ESLint configuration and project lint dependencies

Verification

  • npm run lint
  • npm run build
  • npm test (304 tests)
  • workflow YAML structure validation

Task: task-c3e4a44f

## Summary - run Forgejo CI for every branch push - build, lint, and test in explicit workflow steps - add ESLint configuration and project lint dependencies ## Verification - `npm run lint` - `npm run build` - `npm test` (304 tests) - workflow YAML structure validation Task: task-c3e4a44f
Run CI checks for every branch push
Some checks failed
CI / build-lint-test (push) Failing after 3s
Details
d389005584
erik commented 2026-07-27 07:01:03 -05:00
Author
Owner
Copy link

Review update

  • PR: #3 is open and ready for merge approval.
  • Result: approved.
  • Scope: CI workflow, ESLint configuration, lint script, and required development dependencies are aligned with the task.
  • Verification evidence: npm run lint, npm run build, and npm test passed locally; 304 tests passed. Workflow structure validation confirmed the all-branch push trigger and Build, Lint, and Test steps.

Acceptance criteria

  • Met: Pushing a commit to any branch triggers the workflow through the unrestricted push event.
  • Met: The workflow runs npm run build.
  • Met: The workflow runs npm run lint with the added ESLint configuration.
  • Met: The workflow runs npm test.
  • Met: Build, lint, and test are required sequential steps, so any non-zero result fails the job.

Findings

  • Blocking issues: none.
  • Warnings: none.
  • Final verdict: approved.
  • Follow-up: wait for explicit human merge approval.
### Review update - PR: #3 is open and ready for merge approval. - Result: approved. - Scope: CI workflow, ESLint configuration, lint script, and required development dependencies are aligned with the task. - Verification evidence: `npm run lint`, `npm run build`, and `npm test` passed locally; 304 tests passed. Workflow structure validation confirmed the all-branch push trigger and Build, Lint, and Test steps. ### Acceptance criteria - [x] **Met:** Pushing a commit to any branch triggers the workflow through the unrestricted `push` event. - [x] **Met:** The workflow runs `npm run build`. - [x] **Met:** The workflow runs `npm run lint` with the added ESLint configuration. - [x] **Met:** The workflow runs `npm test`. - [x] **Met:** Build, lint, and test are required sequential steps, so any non-zero result fails the job. ### Findings - Blocking issues: none. - Warnings: none. - Final verdict: **approved**. - Follow-up: wait for explicit human merge approval.
Use SSH for CI checkout
Some checks failed
CI / build-lint-test (push) Failing after 2s
Details
e76cd609cd
Revert "Use SSH for CI checkout"
All checks were successful
CI / build-lint-test (push) Successful in 44s
Details
d565ab4ed2 
This reverts commit e76cd609cd.
erik commented 2026-07-27 07:10:05 -05:00
Author
Owner
Copy link

Review update

  • PR: #3 remains open and CI run #3 passed after configuring the repository’s FORGE_CA_CERT_B64 secret.
  • Result: approved.
  • Verification evidence: Forgejo Actions successfully completed checkout, dependency installation, build, lint, and test for commit d565ab4. Local verification also passed with 304 tests.

Acceptance criteria

  • Met: The unrestricted push event triggered CI for the latest branch commit.
  • Met: The successful workflow ran npm run build.
  • Met: The successful workflow ran npm run lint.
  • Met: The successful workflow ran npm test.
  • Met: Required checks are sequential job steps and failed checkout previously produced a failed workflow, confirming failures propagate.

Findings

  • Blocking issues: none.
  • Warnings: none.
  • Final verdict: approved.
  • Follow-up: wait for explicit human merge approval.
### Review update - PR: #3 remains open and CI run #3 passed after configuring the repository’s `FORGE_CA_CERT_B64` secret. - Result: approved. - Verification evidence: Forgejo Actions successfully completed checkout, dependency installation, build, lint, and test for commit `d565ab4`. Local verification also passed with 304 tests. ### Acceptance criteria - [x] **Met:** The unrestricted `push` event triggered CI for the latest branch commit. - [x] **Met:** The successful workflow ran `npm run build`. - [x] **Met:** The successful workflow ran `npm run lint`. - [x] **Met:** The successful workflow ran `npm test`. - [x] **Met:** Required checks are sequential job steps and failed checkout previously produced a failed workflow, confirming failures propagate. ### Findings - Blocking issues: none. - Warnings: none. - Final verdict: **approved**. - Follow-up: wait for explicit human merge approval.
erik merged commit 2f6284928a into main 2026-07-27 07:10:30 -05:00
erik deleted branch task-c3e4a44f-run-ci-checks 2026-07-27 07:10:30 -05:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
erik/erikvancraddock.com!3
No description provided.