Fix release validation networking in Forgejo #7

Merged
erik merged 1 commit from task-c9375830-fix-release-validation-network into main 2026-07-28 19:42:07 -05:00
Owner

Summary

  • detect when release validation runs inside a Docker-backed CI job
  • share the job network namespace with the production validation container
  • preserve ephemeral host-port validation for local runs

Verification

  • local production-image validation passed
  • nested Docker job simulation with the host Docker socket passed
  • bash -n scripts/validate-production-image.sh
  • git diff --check

Release note

web-v0.3.2 remains immutable and failed without publishing. After this change merges, the next release will use web-v0.3.3.

## Summary - detect when release validation runs inside a Docker-backed CI job - share the job network namespace with the production validation container - preserve ephemeral host-port validation for local runs ## Verification - local production-image validation passed - nested Docker job simulation with the host Docker socket passed - `bash -n scripts/validate-production-image.sh` - `git diff --check` ## Release note `web-v0.3.2` remains immutable and failed without publishing. After this change merges, the next release will use `web-v0.3.3`.
Reach release containers from Forgejo jobs
All checks were successful
CI / build-lint-test (push) Successful in 47s
ee09e90aee
Author
Owner

Review summary

The follow-up correctly handles both execution environments: local validation continues using an ephemeral host port, while Docker-backed Forgejo jobs run the production container in the job container’s network namespace so localhost health and homepage checks can reach it.

Acceptance criteria

  • Met — The merged runtime image includes Hono’s JSX configuration without adding React.
  • Met — Production-image validation verifies the configured homepage after setup.
  • Met — Production-image validation verifies /health and /api/v1/health.
  • Met — The automated release check now has a tested network path in Docker-backed Forgejo jobs.
  • Partial (post-merge gate) — Immutable amd64/arm64 publication remains pending the new web-v0.3.3 release after this networking fix merges.

Blocking issues

  • None.

Warnings

  • None.

Verdict

Approved. The networking change is scoped, preserves local behavior, and passed a nested Docker job simulation matching the Forgejo runner architecture.

### Review summary The follow-up correctly handles both execution environments: local validation continues using an ephemeral host port, while Docker-backed Forgejo jobs run the production container in the job container’s network namespace so localhost health and homepage checks can reach it. ### Acceptance criteria - **Met** — The merged runtime image includes Hono’s JSX configuration without adding React. - **Met** — Production-image validation verifies the configured homepage after setup. - **Met** — Production-image validation verifies `/health` and `/api/v1/health`. - **Met** — The automated release check now has a tested network path in Docker-backed Forgejo jobs. - **Partial (post-merge gate)** — Immutable amd64/arm64 publication remains pending the new `web-v0.3.3` release after this networking fix merges. ### Blocking issues - None. ### Warnings - None. ### Verdict Approved. The networking change is scoped, preserves local behavior, and passed a nested Docker job simulation matching the Forgejo runner architecture.
erik merged commit 5e40701850 into main 2026-07-28 19:42:07 -05:00
erik deleted branch task-c9375830-fix-release-validation-network 2026-07-28 19:42:07 -05:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
erik/erikvancraddock.com!7
No description provided.