Mirror legacy homepage profile #8

Merged

erik merged 2 commits from task-178a6a33-homepage-profile into main 2026-07-28 21:58:28 -05:00

Conversation 2 Commits 2 Files changed 14 +87 -14

erik commented 2026-07-28 21:38:20 -05:00

Owner

Copy link

Summary

• match the legacy homepage profile copy and four social links
• preserve the configurable profile image while matching the legacy edge-to-edge circle styling
• replace the favicon with the supplied legacy favicon

Verification

• npm run build
• npm run lint
• npm test (304 tests)
• desktop browser check at 1200px
• mobile browser check at 390px with no horizontal overflow

## Summary - match the legacy homepage profile copy and four social links - preserve the configurable profile image while matching the legacy edge-to-edge circle styling - replace the favicon with the supplied legacy favicon ## Verification - `npm run build` - `npm run lint` - `npm test` (304 tests) - desktop browser check at 1200px - mobile browser check at 390px with no horizontal overflow

erik added 1 commit 2026-07-28 21:38:20 -05:00

Mirror legacy homepage profile 8744144675

erik commented 2026-07-28 21:39:24 -05:00

Author

Owner

Copy link

Review summary

The homepage now matches the requested legacy profile presentation while preserving the existing configurable actor image. The circle uses the legacy gray background, border, shadow, and edge-to-edge image treatment; profile copy and the four requested links match the reference. The supplied favicon is included.

Acceptance criteria

• Met — The configurable profile image remains sourced locally or from managed site media; no erikcraddock.me image dependency was added.
• Met — Introduction, punctuated tagline, and body match the legacy copy.
• Met — GitHub, LinkedIn, Facebook, and YouTube links render through accessible labeled social icons at the expected URLs.
• Met — Existing responsive classes are preserved, with desktop and 390px mobile browser checks confirming the circle layout and no horizontal overflow.
• Met — Build, lint, all 304 tests, and Forgejo CI run 22 passed.

Blocking issues

• None.

Warnings

• None.

Verdict

Approved.

### Review summary The homepage now matches the requested legacy profile presentation while preserving the existing configurable actor image. The circle uses the legacy gray background, border, shadow, and edge-to-edge image treatment; profile copy and the four requested links match the reference. The supplied favicon is included. ### Acceptance criteria - **Met** — The configurable profile image remains sourced locally or from managed site media; no `erikcraddock.me` image dependency was added. - **Met** — Introduction, punctuated tagline, and body match the legacy copy. - **Met** — GitHub, LinkedIn, Facebook, and YouTube links render through accessible labeled social icons at the expected URLs. - **Met** — Existing responsive classes are preserved, with desktop and 390px mobile browser checks confirming the circle layout and no horizontal overflow. - **Met** — Build, lint, all 304 tests, and Forgejo CI run 22 passed. ### Blocking issues - None. ### Warnings - None. ### Verdict Approved.

erik added 1 commit 2026-07-28 21:57:08 -05:00

Use configured site identity in public and admin views 53b62142a9

erik commented 2026-07-28 21:58:24 -05:00

Author

Owner

Copy link

Updated review summary

The revised PR preserves the configurable profile image, uses only Settings-configured actor/site accounts for homepage social links, opens account links in a new tab with safe relationship attributes, matches the legacy circle and copy, installs the supplied favicon, and uses the configured website title in admin/login headers. Personal profile URLs do not appear in production code or test fixtures.

Acceptance criteria

• Met — The configurable profile image remains independent of erikcraddock.me and uses the requested edge-to-edge circle treatment.
• Met — Introduction, punctuated tagline, and body match the legacy copy.
• Met — Settings-configured GitHub, LinkedIn, Facebook, and YouTube accounts render through accessible icons and open in a new tab; generic fixtures verify the behavior without personal URLs.
• Met — Desktop and 390px mobile browser checks passed without horizontal overflow.
• Met — Build, lint, all 304 tests, and Forgejo CI run 23 passed.

Blocking issues

• None.

Warnings

• None.

Verdict

Approved.

### Updated review summary The revised PR preserves the configurable profile image, uses only Settings-configured actor/site accounts for homepage social links, opens account links in a new tab with safe relationship attributes, matches the legacy circle and copy, installs the supplied favicon, and uses the configured website title in admin/login headers. Personal profile URLs do not appear in production code or test fixtures. ### Acceptance criteria - **Met** — The configurable profile image remains independent of `erikcraddock.me` and uses the requested edge-to-edge circle treatment. - **Met** — Introduction, punctuated tagline, and body match the legacy copy. - **Met** — Settings-configured GitHub, LinkedIn, Facebook, and YouTube accounts render through accessible icons and open in a new tab; generic fixtures verify the behavior without personal URLs. - **Met** — Desktop and 390px mobile browser checks passed without horizontal overflow. - **Met** — Build, lint, all 304 tests, and Forgejo CI run 23 passed. ### Blocking issues - None. ### Warnings - None. ### Verdict Approved.

erik merged commit db9fdf7f3e into main 2026-07-28 21:58:28 -05:00

erik deleted branch task-178a6a33-homepage-profile 2026-07-28 21:58:28 -05:00

erik referenced this pull request from a commit 2026-07-28 21:58:29 -05:00

Merge pull request 'Mirror legacy homepage profile' (#8) from task-178a6a33-homepage-profile into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

erik/erikvancraddock.com!8

No description provided.