erik/erikvancraddock.com
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Match the fixed homepage profile copy #9

Merged
erik merged 1 commit from task-84d40b56-fixed-profile-copy into main 2026-07-28 23:32:29 -05:00
Conversation 1 Commits 1 Files changed 5 +40 -18
erik commented 2026-07-28 23:29:35 -05:00
Owner
Copy link

Summary

  • hardcode the three-line homepage profile copy so persisted site settings cannot override it
  • match the legacy word-level colors and muted typography while retaining the semantic page heading
  • update API, app, and route tests to verify fixed content against persisted overrides

Verification

  • npm run build
  • npm run lint
  • npm test (304 tests)
  • desktop browser check at 1200px
  • mobile browser check at 390px with no horizontal overflow
## Summary - hardcode the three-line homepage profile copy so persisted site settings cannot override it - match the legacy word-level colors and muted typography while retaining the semantic page heading - update API, app, and route tests to verify fixed content against persisted overrides ## Verification - `npm run build` - `npm run lint` - `npm test` (304 tests) - desktop browser check at 1200px - mobile browser check at 390px with no horizontal overflow
Fix homepage profile copy presentation
All checks were successful
CI / build-lint-test (push) Successful in 45s
Details
be7ba00902
erik commented 2026-07-28 23:30:32 -05:00
Author
Owner
Copy link

Review summary

The PR hardcodes the three-line homepage profile block with the requested legacy emphasis, keeps the heading semantic, and prevents persisted site settings from overriding the copy. Tests cover direct rendering, persisted database overrides, and API-updated values using generic fixture data.

Acceptance criteria

  • Met — Copy, colors, italic tagline, and muted body match the supplied reference.
  • Met — Persisted tagline, introduction, and body values cannot override the profile block.
  • Met — The profile statement remains an h1; color is decorative emphasis on fully readable words.
  • Met — Desktop and 390px mobile checks passed without horizontal overflow.
  • Met — Tests cover fixed content and generic persisted overrides without personal account URLs.
  • Met — Build, lint, all 304 tests, and Forgejo CI run 27 passed.

Blocking issues

  • None.

Warnings

  • None.

Verdict

Approved.

### Review summary The PR hardcodes the three-line homepage profile block with the requested legacy emphasis, keeps the heading semantic, and prevents persisted site settings from overriding the copy. Tests cover direct rendering, persisted database overrides, and API-updated values using generic fixture data. ### Acceptance criteria - **Met** — Copy, colors, italic tagline, and muted body match the supplied reference. - **Met** — Persisted tagline, introduction, and body values cannot override the profile block. - **Met** — The profile statement remains an `h1`; color is decorative emphasis on fully readable words. - **Met** — Desktop and 390px mobile checks passed without horizontal overflow. - **Met** — Tests cover fixed content and generic persisted overrides without personal account URLs. - **Met** — Build, lint, all 304 tests, and Forgejo CI run 27 passed. ### Blocking issues - None. ### Warnings - None. ### Verdict Approved.
erik merged commit 780a31008e into main 2026-07-28 23:32:29 -05:00
erik deleted branch task-84d40b56-fixed-profile-copy 2026-07-28 23:32:29 -05:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
erik/erikvancraddock.com!9
No description provided.