erik/kvshare
1
0
Fork 0
Code Issues Pull requests Projects Releases 3 Packages Wiki Activity Actions

Make release asset uploads idempotent #14

Merged
erik merged 2 commits from fix/task-a519f294-idempotent-assets into main 2026-07-22 15:35:50 -05:00
Conversation 2 Commits 2 Files changed 2 +45 -10
erik commented 2026-07-22 15:32:29 -05:00
Owner
Copy link

Summary

Make release asset publication idempotent.

Task

Task: #task-a519f294

Changes

  • list existing release assets before platform uploads
  • delete every same-named package or checksum before uploading its replacement
  • install jq in the Arch build container for safe asset ID selection

Testing

  • Release workflow YAML validation
  • Release version tooling tests
  • Duplicate v0.1.1 assets cleaned, leaving one checksum-verified set

Checklist

  • No unrelated changes included
## Summary Make release asset publication idempotent. ## Task Task: #task-a519f294 ## Changes - list existing release assets before platform uploads - delete every same-named package or checksum before uploading its replacement - install `jq` in the Arch build container for safe asset ID selection ## Testing - [x] Release workflow YAML validation - [x] Release version tooling tests - [x] Duplicate v0.1.1 assets cleaned, leaving one checksum-verified set ## Checklist - [x] No unrelated changes included
fix: replace duplicate release assets
All checks were successful
CI / Rust build, lint, and test (pull_request) Successful in 12s
Details
CI / Swift build, lint, and test (pull_request) Successful in 14s
Details
db9af304e4 
Task: #task-a519f294
erik commented 2026-07-22 15:33:23 -05:00
Author
Owner
Copy link

Review update

  • Summary: PR #14 makes release reruns idempotent by deleting all same-named assets before each replacement upload, using the current Forgejo release-asset endpoint and parsed numeric IDs.
  • Acceptance criteria: Improves repeatable release publication and preserves one package/checksum pair per platform.
  • Evidence: PR CI run #50 passed; duplicate v0.1.1 assets were reduced to one checksum-verified set.
  • Blocking issues: None.
  • Warnings: None.
  • Result: approved
  • Follow-up: Merge, rerun v0.1.1 publication to verify replacement behavior, then perform target-machine installation checks.
### Review update - **Summary:** PR #14 makes release reruns idempotent by deleting all same-named assets before each replacement upload, using the current Forgejo release-asset endpoint and parsed numeric IDs. - **Acceptance criteria:** Improves repeatable release publication and preserves one package/checksum pair per platform. - **Evidence:** PR CI run #50 passed; duplicate `v0.1.1` assets were reduced to one checksum-verified set. - **Blocking issues:** None. - **Warnings:** None. - **Result:** approved - **Follow-up:** Merge, rerun `v0.1.1` publication to verify replacement behavior, then perform target-machine installation checks.
docs: clarify unsigned macOS installation
All checks were successful
CI / Rust build, lint, and test (pull_request) Successful in 11s
Details
CI / Swift build, lint, and test (pull_request) Successful in 14s
Details
130d5fffad 
Task: #task-a519f294
erik commented 2026-07-22 15:35:37 -05:00
Author
Owner
Copy link

Review update

  • Summary: Re-review includes explicit unsigned macOS installation paths through Finder/System Settings and Terminal, with checksum verification required before quarantine removal. Idempotent release replacement remains correctly scoped.
  • Evidence: Updated PR CI run #51 passed; the published v0.1.1 package/checksum pairs were downloaded and verified successfully.
  • Blocking issues: None.
  • Warnings: None.
  • Result: approved
  • Follow-up: Merge, rerun publication once to validate replacement, and use the documented steps for target-machine installation.
### Review update - **Summary:** Re-review includes explicit unsigned macOS installation paths through Finder/System Settings and Terminal, with checksum verification required before quarantine removal. Idempotent release replacement remains correctly scoped. - **Evidence:** Updated PR CI run #51 passed; the published `v0.1.1` package/checksum pairs were downloaded and verified successfully. - **Blocking issues:** None. - **Warnings:** None. - **Result:** approved - **Follow-up:** Merge, rerun publication once to validate replacement, and use the documented steps for target-machine installation.
erik merged commit 9686e8ff08 into main 2026-07-22 15:35:50 -05:00
erik deleted branch fix/task-a519f294-idempotent-assets 2026-07-22 15:35:50 -05:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
erik/kvshare!14
No description provided.