erik/kvshare
1
0
Fork 0
Code Issues Pull requests Projects Releases 3 Packages Wiki Activity Actions

Prevent macOS installer relocation #15

Merged
erik merged 1 commit from fix/task-a519f294-macos-relocation into main 2026-07-22 15:47:43 -05:00
Conversation 1 Commits 1 Files changed 4 +34 -7
erik commented 2026-07-22 15:45:15 -05:00
Owner
Copy link

Summary

Prevent macOS Installer from relocating KvshareMac to an existing development build path.

Task

Task: #task-a519f294

Changes

  • supply explicit pkgbuild component metadata with bundle relocation disabled
  • require an empty relocation list in generated package metadata
  • bump the corrected release to 0.1.2
  • update unsigned installation examples

Testing

  • make pre-pr
  • Local macOS package build and checksum verification
  • Generated PackageInfo contains relocatable="false" and an empty <relocate/>

Checklist

  • Documentation updated
  • No unrelated changes included
## Summary Prevent macOS Installer from relocating KvshareMac to an existing development build path. ## Task Task: #task-a519f294 ## Changes - supply explicit pkgbuild component metadata with bundle relocation disabled - require an empty relocation list in generated package metadata - bump the corrected release to 0.1.2 - update unsigned installation examples ## Testing - [x] `make pre-pr` - [x] Local macOS package build and checksum verification - [x] Generated PackageInfo contains `relocatable="false"` and an empty `<relocate/>` ## Checklist - [x] Documentation updated - [x] No unrelated changes included
fix: prevent macOS bundle relocation
All checks were successful
CI / Rust build, lint, and test (pull_request) Successful in 12s
Details
CI / Swift build, lint, and test (pull_request) Successful in 14s
Details
a1ecdbf337 
Task: #task-a519f294
erik commented 2026-07-22 15:46:44 -05:00
Author
Owner
Copy link

Review update

  • Summary: PR #15 correctly disables Installer bundle relocation with explicit component metadata, enforces the resulting empty relocation list, and versions the corrected artifacts as 0.1.2.
  • Evidence: make pre-pr passed, local package metadata/checksum validation passed, PR CI run #54 passed, and package validation run #55 built both platform artifacts.
  • Blocking issues: None.
  • Warnings: None.
  • Result: approved
  • Follow-up: Merge, publish v0.1.2, and install the released macOS package while a development app bundle exists to verify /Applications placement.
### Review update - **Summary:** PR #15 correctly disables Installer bundle relocation with explicit component metadata, enforces the resulting empty relocation list, and versions the corrected artifacts as `0.1.2`. - **Evidence:** `make pre-pr` passed, local package metadata/checksum validation passed, PR CI run #54 passed, and package validation run #55 built both platform artifacts. - **Blocking issues:** None. - **Warnings:** None. - **Result:** approved - **Follow-up:** Merge, publish `v0.1.2`, and install the released macOS package while a development app bundle exists to verify `/Applications` placement.
erik merged commit a8b7bbf26d into main 2026-07-22 15:47:43 -05:00
erik deleted branch fix/task-a519f294-macos-relocation 2026-07-22 15:47:43 -05:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
erik/kvshare!15
No description provided.