erik/kvshare
1
0
Fork 0
Code Issues Pull requests Projects Releases 3 Packages Wiki Activity Actions

Fix kvshare macOS startup regression #17

Merged
erik merged 1 commit from fix/task-f0c5bcb9-startup-regression into main 2026-07-31 17:42:37 -05:00
Conversation 1 Commits 1 Files changed 4 +76 -23
erik commented 2026-07-31 17:28:12 -05:00
Owner
Copy link

Summary

Restore the macOS menu-bar app startup by executing the stable binary through a valid runtime application bundle.

Task

Task: #task-f0c5bcb9

Changes

  • Extract the packaged launcher into a testable source file.
  • Create a user-local runtime app bundle that symlinks to the stable trusted executable.
  • Add a launcher regression test and document runtime files and removal.

Testing

  • Unit tests added/updated
  • Manual testing performed
  • make check
  • ./scripts/pre-pr.sh
  • macOS package build and code-signature verification
  • Packaged-launcher smoke test with no AppKit status-bar errors

Checklist

  • ./scripts/pre-pr.sh passes
  • Documentation updated (if needed)
  • No unrelated changes included
## Summary Restore the macOS menu-bar app startup by executing the stable binary through a valid runtime application bundle. ## Task Task: #task-f0c5bcb9 ## Changes - Extract the packaged launcher into a testable source file. - Create a user-local runtime app bundle that symlinks to the stable trusted executable. - Add a launcher regression test and document runtime files and removal. ## Testing - [x] Unit tests added/updated - [x] Manual testing performed - [x] `make check` - [x] `./scripts/pre-pr.sh` - [x] macOS package build and code-signature verification - [x] Packaged-launcher smoke test with no AppKit status-bar errors ## Checklist - [x] `./scripts/pre-pr.sh` passes - [x] Documentation updated (if needed) - [x] No unrelated changes included
fix: launch macOS app from runtime bundle
All checks were successful
CI / Rust build, lint, and test (pull_request) Successful in 1m13s
Details
CI / Swift build, lint, and test (pull_request) Successful in 2m24s
Details
f32411735a 
Task: #task-f0c5bcb9
erik commented 2026-07-31 17:32:27 -05:00
Author
Owner
Copy link

Review summary

The startup regression is fixed by launching the stable executable through a valid user-local application bundle, restoring AppKit menu-bar integration without changing the trusted executable target.

Acceptance criteria

  • Met: The failure was reproduced and traced to executing the app binary outside an application bundle, which produced AppKit status-bar activation errors.
  • Met: The packaged-launcher smoke test starts kvshare from the runtime bundle with no AppKit status-bar errors.
  • Met: The release-tooling test verifies the runtime-bundle execution path and stable executable symlink.
  • Met: make check, ./scripts/pre-pr.sh, package construction, signature verification, and Forgejo CI passed.

Blocking issues

  • None.

Warnings

  • None.

Verdict

Approved

### Review summary The startup regression is fixed by launching the stable executable through a valid user-local application bundle, restoring AppKit menu-bar integration without changing the trusted executable target. ### Acceptance criteria - **Met:** The failure was reproduced and traced to executing the app binary outside an application bundle, which produced AppKit status-bar activation errors. - **Met:** The packaged-launcher smoke test starts kvshare from the runtime bundle with no AppKit status-bar errors. - **Met:** The release-tooling test verifies the runtime-bundle execution path and stable executable symlink. - **Met:** `make check`, `./scripts/pre-pr.sh`, package construction, signature verification, and Forgejo CI passed. ### Blocking issues - None. ### Warnings - None. ### Verdict **Approved**
erik merged commit edaee431e3 into main 2026-07-31 17:42:37 -05:00
erik deleted branch fix/task-f0c5bcb9-startup-regression 2026-07-31 17:42:37 -05:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
erik/kvshare!17
No description provided.