erik/kvshare
1
0
Fork 0
Code Issues Pull requests Projects Releases 3 Packages Wiki Activity Actions

Launch kvshare through macOS Launch Services #18

Merged
erik merged 1 commit from fix/task-f0c5bcb9-deliver-startup-fix into main 2026-07-31 18:38:04 -05:00
Conversation 1 Commits 1 Files changed 5 +16 -12
erik commented 2026-07-31 18:36:10 -05:00
Owner
Copy link

Summary

Correct the macOS startup fix by launching the runtime application through Launch Services, then deliver it as v0.1.4.

Task

Task: #task-f0c5bcb9

Changes

  • Launch the user-local runtime bundle with open -n -W instead of directly executing its binary.
  • Update the regression test to prove Launch Services starts the stable executable.
  • Bump the package and documentation to v0.1.4.

Testing

  • Unit tests added/updated
  • Manual testing performed against the installed /Applications/KvshareMac.app
  • Installed v0.1.4 starts through the runtime bundle with no AppKit status-bar errors
  • make check
  • ./scripts/pre-pr.sh
  • Package checksum verification

Checklist

  • ./scripts/pre-pr.sh passes
  • Documentation updated
  • No unrelated changes included
## Summary Correct the macOS startup fix by launching the runtime application through Launch Services, then deliver it as v0.1.4. ## Task Task: #task-f0c5bcb9 ## Changes - Launch the user-local runtime bundle with `open -n -W` instead of directly executing its binary. - Update the regression test to prove Launch Services starts the stable executable. - Bump the package and documentation to v0.1.4. ## Testing - [x] Unit tests added/updated - [x] Manual testing performed against the installed `/Applications/KvshareMac.app` - [x] Installed v0.1.4 starts through the runtime bundle with no AppKit status-bar errors - [x] `make check` - [x] `./scripts/pre-pr.sh` - [x] Package checksum verification ## Checklist - [x] `./scripts/pre-pr.sh` passes - [x] Documentation updated - [x] No unrelated changes included
fix: launch runtime app through Launch Services
All checks were successful
CI / Rust build, lint, and test (pull_request) Successful in 12s
Details
CI / Swift build, lint, and test (pull_request) Successful in 14s
Details
98dd8e4c1b 
Task: #task-f0c5bcb9
erik commented 2026-07-31 18:37:02 -05:00
Author
Owner
Copy link

Review summary

The follow-up fixes the actual startup path by invoking the runtime application through macOS Launch Services and delivers the correction as v0.1.4. The installed /Applications/KvshareMac.app was tested directly after package installation.

Acceptance criteria

  • Met: The remaining failure was reproduced and identified: directly executing the runtime binary still bypassed Launch Services and caused AppKit status-bar activation failures.
  • Met: Installed v0.1.4 starts through Launch Services and remains running with no AppKit status-bar errors.
  • Met: The regression test now launches the test runtime application through Launch Services and verifies the stable executable target.
  • Met: make check, ./scripts/pre-pr.sh, package checksum verification, and Forgejo CI passed.

Blocking issues

  • None.

Warnings

  • None.

Verdict

Approved

### Review summary The follow-up fixes the actual startup path by invoking the runtime application through macOS Launch Services and delivers the correction as v0.1.4. The installed `/Applications/KvshareMac.app` was tested directly after package installation. ### Acceptance criteria - **Met:** The remaining failure was reproduced and identified: directly executing the runtime binary still bypassed Launch Services and caused AppKit status-bar activation failures. - **Met:** Installed v0.1.4 starts through Launch Services and remains running with no AppKit status-bar errors. - **Met:** The regression test now launches the test runtime application through Launch Services and verifies the stable executable target. - **Met:** `make check`, `./scripts/pre-pr.sh`, package checksum verification, and Forgejo CI passed. ### Blocking issues - None. ### Warnings - None. ### Verdict **Approved**
erik merged commit d17c8ad780 into main 2026-07-31 18:38:04 -05:00
erik deleted branch fix/task-f0c5bcb9-deliver-startup-fix 2026-07-31 18:38:04 -05:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
erik/kvshare!18
No description provided.