Define the kvshare wire protocol #3

Merged

erik merged 7 commits from erik/task-d9bbd64e-wire-protocol into main 2026-07-17 06:01:46 -05:00 AGit

Conversation 1 Commits 7 Files changed 18 +1173 -1

erik commented 2026-07-16 23:17:19 -05:00

Owner

Copy link

Documents protocol version 1 and adds matching dependency-free Rust and Swift codecs, shared fixtures, strict validation tests, and cross-language verification commands. Task: task-d9bbd64e

Documents protocol version 1 and adds matching dependency-free Rust and Swift codecs, shared fixtures, strict validation tests, and cross-language verification commands. Task: task-d9bbd64e

erik added 1 commit 2026-07-16 23:17:19 -05:00

feat: define kvshare wire protocol ... ace5cb3b3c

Task: #task-d9bbd64e

erik added 1 commit 2026-07-16 23:21:30 -05:00

ci: verify Rust and Swift protocol code ... 61d35acf65

Task: #task-d9bbd64e

erik added 1 commit 2026-07-16 23:23:33 -05:00

fix: resolve CI setup actions from GitHub ... d7d9dcdbc0

Task: #task-d9bbd64e

erik added 1 commit 2026-07-16 23:24:49 -05:00

ci: allow manual verification runs ... 21640824ba

Task: #task-d9bbd64e

erik added 1 commit 2026-07-16 23:29:57 -05:00

ci: use isolated Rust and Swift containers ... d4fe6b48e4

Task: #task-d9bbd64e

erik added 1 commit 2026-07-17 05:59:11 -05:00

fix: trust Forgejo CA in pull request CI ... df6be5b5f9

Task: #task-d9bbd64e

erik added 1 commit 2026-07-17 06:00:34 -05:00

fix: install Rust CI quality components ... 8460f048c4

Task: #task-d9bbd64e

erik commented 2026-07-17 06:01:28 -05:00

Author

Owner

Copy link

Review summary

The PR defines protocol version 1, adds matching dependency-free Rust and Swift codecs, validates shared fixtures and malformed input, and introduces passing Forgejo CI for both toolchains.

Acceptance criteria

• The protocol format is documented — met — docs/PROTOCOL.md specifies framing, byte order, limits, message layouts, enum values, directions, and version behavior.
• Swift and Rust encode and decode the same fixtures — met — both test suites decode and re-encode the eight canonical protocol/fixtures/*.hex frames byte-for-byte.
• Invalid and unsupported messages are rejected safely — met — both codecs test short frames, invalid magic, unsupported versions, oversized and mismatched payloads, unknown message types, invalid enum values, and trailing data.

Blocking issues

• None.

Warnings

• None.

Verification

• Local make check and make pre-pr: passed.
• Forgejo CI run #6: Rust and Swift build, lint, and test jobs passed.

Verdict

Approved.

### Review summary The PR defines protocol version 1, adds matching dependency-free Rust and Swift codecs, validates shared fixtures and malformed input, and introduces passing Forgejo CI for both toolchains. ### Acceptance criteria - [x] **The protocol format is documented** — met — `docs/PROTOCOL.md` specifies framing, byte order, limits, message layouts, enum values, directions, and version behavior. - [x] **Swift and Rust encode and decode the same fixtures** — met — both test suites decode and re-encode the eight canonical `protocol/fixtures/*.hex` frames byte-for-byte. - [x] **Invalid and unsupported messages are rejected safely** — met — both codecs test short frames, invalid magic, unsupported versions, oversized and mismatched payloads, unknown message types, invalid enum values, and trailing data. ### Blocking issues - None. ### Warnings - None. ### Verification - Local `make check` and `make pre-pr`: passed. - Forgejo CI run #6: Rust and Swift build, lint, and test jobs passed. ### Verdict Approved.

erik merged commit 8460f048c4 into main 2026-07-17 06:01:46 -05:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

erik/kvshare!3

No description provided.