Fix stale Undo Follow handling #61

Merged

erik merged 1 commit from fix/task-14c16989-stale-undo into main

2026-10-26 16:16:48 -05:00

erik commented

2026-10-26 16:15:05 -05:00

Owner

Summary

Port the site-owned follower fixes from Slugkit template 0.10.4 (5fdff3bf and 797a5796).
Match Undo by actor and current Follow activity ID in one guarded SQL update; leave newer relationships and malformed/missing stored identities unchanged.
Normalize incoming Follow JSON-LD to compact IDs, retaining support for previously stored @id values.
Add persistence and signed-inbox regressions for stale/matching Undo and JSON-LD ID aliases.

Verification

./scripts/pre-pr.sh: formatting, typecheck, build, unchanged generated CSS, all 61 test files / 620 tests passed (including local-only signed federation tests).
Targeted follower + Follow inbox checks: 26 tests passed.
CI verify succeeded for 902fa6c588 (action run #66).
Independent read-only review: no findings; independently reran targeted tests, typecheck, and whitespace checks. See PR review comment.
No dependency updates, database migrations, release automation changes, development-port changes, or live federation writes.

Task: task-14c16989

## Summary - Port the site-owned follower fixes from Slugkit template 0.10.4 (5fdff3bf and 797a5796). - Match Undo by actor and current Follow activity ID in one guarded SQL update; leave newer relationships and malformed/missing stored identities unchanged. - Normalize incoming Follow JSON-LD to compact IDs, retaining support for previously stored @id values. - Add persistence and signed-inbox regressions for stale/matching Undo and JSON-LD ID aliases. ## Verification - ./scripts/pre-pr.sh: formatting, typecheck, build, unchanged generated CSS, all 61 test files / 620 tests passed (including local-only signed federation tests). - Targeted follower + Follow inbox checks: 26 tests passed. - CI verify succeeded for 902fa6c588 (action run #66). - Independent read-only review: no findings; independently reran targeted tests, typecheck, and whitespace checks. See PR review comment. - No dependency updates, database migrations, release automation changes, development-port changes, or live federation writes. Task: task-14c16989

erik added 1 commit

2026-10-26 16:15:05 -05:00

fix: ignore stale Undo Follow activities

CI / verify (pull_request) Successful in 45s

Details

902fa6c588

Port Follow identity matching and JSON-LD normalization from template 0.10.4. Preserve newer relationships when delayed Undo activities arrive.

Task: task-14c16989

erik commented

2026-10-26 16:16:39 -05:00

Author

Owner

Independent review — no findings

A separate read-only reviewer inspected this PR description, full diff, both reference commits, relevant inbox/persistence/schema code, and project guidance. It found no correctness, security, or scope defects. The reviewer independently ran the 26 targeted tests, typecheck, and diff whitespace checks; all passed.

Review limits: it did not rerun the complete suite/build, inspect remote CI, or perform live federation writes. The implementing session separately passed ./scripts/pre-pr.sh (620 tests, 61 files) and confirmed the verify CI job succeeded for head 902fa6c588 in action run #66.

The fj pr status command encountered a Forgejo CLI URL-deserialization error; CI success was verified via fj actions tasks instead.

Review artifact: /tmp/task-14c16989-review.log

## Independent review — no findings A separate read-only reviewer inspected this PR description, full diff, both reference commits, relevant inbox/persistence/schema code, and project guidance. It found no correctness, security, or scope defects. The reviewer independently ran the 26 targeted tests, typecheck, and diff whitespace checks; all passed. Review limits: it did not rerun the complete suite/build, inspect remote CI, or perform live federation writes. The implementing session separately passed ./scripts/pre-pr.sh (620 tests, 61 files) and confirmed the verify CI job succeeded for head 902fa6c588 in action run #66. The fj pr status command encountered a Forgejo CLI URL-deserialization error; CI success was verified via fj actions tasks instead. Review artifact: /tmp/task-14c16989-review.log

erik merged commit 4d5fa0c0a6 into main

2026-10-26 16:16:48 -05:00

erik deleted branch fix/task-14c16989-stale-undo

2026-10-26 16:16:48 -05:00

erik referenced this pull request from a commit

2026-10-26 16:16:49 -05:00

Merge pull request 'Fix stale Undo Follow handling' (#61) from fix/task-14c16989-stale-undo into main