Remove ActivityPub signing keys section #176

Merged

erik merged 1 commit from feat/task-6e02b0c8-remove-activitypub-keys-section into main

2026-06-21 11:48:25 -05:00

erik commented

2026-06-21 11:45:28 -05:00

Owner

Summary

Remove the visible ActivityPub signing keys section from /settings/activitypub.
Keep automatic key generation during ActivityPub actor creation.
Keep the backend signing-key repair route available without exposing it as normal page UI.
Update ActivityPub tests so they assert the section/action are not rendered and automatic key creation remains covered.

Verification

npm test --workspace @slugkit/template-site -- src/routes/__tests__/admin-activitypub.test.ts
npm run build --workspace @slugkit/template-site
./scripts/pre-pr.sh

## Summary - Remove the visible ActivityPub signing keys section from `/settings/activitypub`. - Keep automatic key generation during ActivityPub actor creation. - Keep the backend signing-key repair route available without exposing it as normal page UI. - Update ActivityPub tests so they assert the section/action are not rendered and automatic key creation remains covered. ## Verification - `npm test --workspace @slugkit/template-site -- src/routes/__tests__/admin-activitypub.test.ts` - `npm run build --workspace @slugkit/template-site` - `./scripts/pre-pr.sh`

erik added 1 commit

2026-06-21 11:45:28 -05:00

feat: remove ActivityPub signing keys section

CI / build-lint-test (pull_request) Successful in 45s

Details

1b89012e6d

Task: #task-6e02b0c8

erik commented

2026-06-21 11:46:41 -05:00

Author

Owner

PR Review: Approved

Summary

This PR removes the visible ActivityPub signing keys card from /settings/activitypub while preserving automatic key generation during actor creation and retaining the backend repair route without exposing it as normal page UI.

Acceptance criteria

/settings/activitypub no longer renders the “ActivityPub signing keys” section — met: renderKeySection was removed from the template.
Creating an ActivityPub actor still automatically stores signing keys — met: existing actor creation test still asserts private/public keys are stored.
The page does not show a normal “Generate signing keys” action when keys are already generated — met: tests assert the page does not contain Generate signing keys.
Tests cover automatic signing-key creation during actor creation — met by creates the primary ActivityPub actor.
Tests no longer depend on the removed signing keys section being visible — met: repair-route test verifies backend behavior and absence of removed UI.

Blocking issues

None.

Warnings

None.

Verification

npm test --workspace @slugkit/template-site -- src/routes/__tests__/admin-activitypub.test.ts
npm run build --workspace @slugkit/template-site
./scripts/pre-pr.sh
Forgejo Actions run #244 passed.

Verdict

Approved. Stop at the human merge gate.

PR Review Worker Result

pr: open
review: approved
pr_comment: posted
task_comment: posted
blocking_issues: 0
warnings: 0
criteria_total: 5
criteria_met: 5
criteria_missing: 0

## PR Review: Approved ### Summary This PR removes the visible ActivityPub signing keys card from `/settings/activitypub` while preserving automatic key generation during actor creation and retaining the backend repair route without exposing it as normal page UI. ### Acceptance criteria - [x] `/settings/activitypub` no longer renders the “ActivityPub signing keys” section — met: `renderKeySection` was removed from the template. - [x] Creating an ActivityPub actor still automatically stores signing keys — met: existing actor creation test still asserts private/public keys are stored. - [x] The page does not show a normal “Generate signing keys” action when keys are already generated — met: tests assert the page does not contain `Generate signing keys`. - [x] Tests cover automatic signing-key creation during actor creation — met by `creates the primary ActivityPub actor`. - [x] Tests no longer depend on the removed signing keys section being visible — met: repair-route test verifies backend behavior and absence of removed UI. ### Blocking issues None. ### Warnings None. ### Verification - `npm test --workspace @slugkit/template-site -- src/routes/__tests__/admin-activitypub.test.ts` - `npm run build --workspace @slugkit/template-site` - `./scripts/pre-pr.sh` - Forgejo Actions run #244 passed. ### Verdict Approved. Stop at the human merge gate. PR Review Worker Result - pr: open - review: approved - pr_comment: posted - task_comment: posted - blocking_issues: 0 - warnings: 0 - criteria_total: 5 - criteria_met: 5 - criteria_missing: 0

erik referenced this pull request

2026-06-21 11:48:15 -05:00

Remove ActivityPub signing keys section #177

erik merged commit 4de6e6e1ce into main

2026-06-21 11:48:25 -05:00

erik deleted branch feat/task-6e02b0c8-remove-activitypub-keys-section

2026-06-21 11:48:25 -05:00

erik referenced this pull request from a commit

2026-06-21 11:48:26 -05:00

Remove ActivityPub signing keys section (#176)

erik referenced this pull request

2026-06-21 11:53:47 -05:00