Remove ActivityPub signing keys section #177

New issue

Closed

opened 2026-06-21 11:48:14 -05:00 by erik · 2 comments

erik commented

2026-06-21 11:48:14 -05:00

Owner

Goal

Remove the redundant ActivityPub signing keys section from the ActivityPub settings page because signing keys are generated automatically when an actor is created.

Requirements

Remove the visible “ActivityPub signing keys” section from /settings/activitypub.
Keep actor creation behavior generating signing keys automatically.
Keep existing backend repair behavior only if it is still needed internally or by tests, but do not expose it as a normal settings page section.
Ensure the ActivityPub settings page does not imply signing keys are a separate normal setup step after clicking “Create actor”.
Update tests that currently expect the signing keys section or manual key generation action.

Acceptance criteria

/settings/activitypub no longer renders the “ActivityPub signing keys” section.
Creating an ActivityPub actor still automatically stores signing keys.
The page does not show a normal “Generate signing keys” action when keys are already generated.
Tests cover automatic signing-key creation during actor creation.
Tests no longer depend on the removed signing keys section being visible.

Dependencies

None

## Goal Remove the redundant ActivityPub signing keys section from the ActivityPub settings page because signing keys are generated automatically when an actor is created. ## Requirements - Remove the visible “ActivityPub signing keys” section from `/settings/activitypub`. - Keep actor creation behavior generating signing keys automatically. - Keep existing backend repair behavior only if it is still needed internally or by tests, but do not expose it as a normal settings page section. - Ensure the ActivityPub settings page does not imply signing keys are a separate normal setup step after clicking “Create actor”. - Update tests that currently expect the signing keys section or manual key generation action. ## Acceptance criteria - [ ] `/settings/activitypub` no longer renders the “ActivityPub signing keys” section. - [ ] Creating an ActivityPub actor still automatically stores signing keys. - [ ] The page does not show a normal “Generate signing keys” action when keys are already generated. - [ ] Tests cover automatic signing-key creation during actor creation. - [ ] Tests no longer depend on the removed signing keys section being visible. ## Dependencies - None

erik added the

implementation

status:inprogress

priority:medium

labels

2026-06-21 11:48:14 -05:00

erik commented

2026-06-21 11:48:15 -05:00

Author

Owner

Synced from todu comment by @todu on 2026-06-21T16:46:41.537Z

Review update

PR: #176 is open and reviewed.
Result: approved; no blocking issues or warnings.
Acceptance criteria: 5/5 met.
Verified: npm test --workspace @slugkit/template-site -- src/routes/__tests__/admin-activitypub.test.ts, npm run build --workspace @slugkit/template-site, ./scripts/pre-pr.sh, and Forgejo Actions run #244.
Follow-up: waiting for explicit human merge approval.

_Synced from todu comment by @todu on 2026-06-21T16:46:41.537Z_ ### Review update - PR: https://forge.caradoc.com/erik/slugkit/pulls/176 is open and reviewed. - Result: approved; no blocking issues or warnings. - Acceptance criteria: 5/5 met. - Verified: `npm test --workspace @slugkit/template-site -- src/routes/__tests__/admin-activitypub.test.ts`, `npm run build --workspace @slugkit/template-site`, `./scripts/pre-pr.sh`, and Forgejo Actions run #244. - Follow-up: waiting for explicit human merge approval.

erik

2026-06-21 11:53:46 -05:00

closed this issue
added
status:done
and removed
status:inprogress
labels

erik commented

2026-06-21 11:53:47 -05:00

Author

Owner

Synced from todu comment by @todu on 2026-06-21T16:49:19.883Z

Closing summary

PR #176 was merged into main.

Acceptance criteria:

/settings/activitypub no longer renders the “ActivityPub signing keys” section — met by removing the section from the settings template.
Creating an ActivityPub actor still automatically stores signing keys — met by preserving automatic key generation and existing actor creation test coverage.
The page does not show a normal “Generate signing keys” action when keys are already generated — met by removal and test assertions.
Tests cover automatic signing-key creation during actor creation — met.
Tests no longer depend on the removed signing keys section being visible — met; repair route test now verifies backend behavior without expecting visible UI.

Verification:

npm test --workspace @slugkit/template-site -- src/routes/__tests__/admin-activitypub.test.ts
npm run build --workspace @slugkit/template-site
./scripts/pre-pr.sh
Forgejo Actions run #244 passed.

Readiness: READY. Closing task.

_Synced from todu comment by @todu on 2026-06-21T16:49:19.883Z_ ### Closing summary PR #176 was merged into `main`. Acceptance criteria: - `/settings/activitypub` no longer renders the “ActivityPub signing keys” section — met by removing the section from the settings template. - Creating an ActivityPub actor still automatically stores signing keys — met by preserving automatic key generation and existing actor creation test coverage. - The page does not show a normal “Generate signing keys” action when keys are already generated — met by removal and test assertions. - Tests cover automatic signing-key creation during actor creation — met. - Tests no longer depend on the removed signing keys section being visible — met; repair route test now verifies backend behavior without expecting visible UI. Verification: - `npm test --workspace @slugkit/template-site -- src/routes/__tests__/admin-activitypub.test.ts` - `npm run build --workspace @slugkit/template-site` - `./scripts/pre-pr.sh` - Forgejo Actions run #244 passed. Readiness: READY. Closing task.