Make tag badges link to tag pages #186

New issue

Closed

opened 2026-06-22 07:07:15 -05:00 by erik · 2 comments

erik commented

2026-06-22 07:07:15 -05:00

Owner

Summary

Tag badges are rendered as non-clickable text in at least one public page context, so users cannot navigate from a tag badge to that tag’s page.

Steps to reproduce

Start the Slugkit site locally.
Open a public page that displays tag badges.
Try to click a tag badge.

Expected behavior

Tag badges are links to their corresponding public tag pages.
Clicking a tag badge navigates to the matching tag page.

Actual behavior

Tag badges are not links in the affected context.
Users cannot navigate to tag pages from those badges.

Acceptance criteria

Public tag badges link to the correct tag detail pages.
Link styling preserves the badge appearance and accessible focus/hover behavior.
Existing public page tests are updated or added to cover tag badge links.

## Summary Tag badges are rendered as non-clickable text in at least one public page context, so users cannot navigate from a tag badge to that tag’s page. ## Steps to reproduce 1. Start the Slugkit site locally. 2. Open a public page that displays tag badges. 3. Try to click a tag badge. ## Expected behavior - Tag badges are links to their corresponding public tag pages. - Clicking a tag badge navigates to the matching tag page. ## Actual behavior - Tag badges are not links in the affected context. - Users cannot navigate to tag pages from those badges. ## Acceptance criteria - [ ] Public tag badges link to the correct tag detail pages. - [ ] Link styling preserves the badge appearance and accessible focus/hover behavior. - [ ] Existing public page tests are updated or added to cover tag badge links.

erik added the

status:active

bug

priority:medium

labels

2026-06-22 07:07:15 -05:00

erik added

status:inprogress

and removed

status:active

labels

2026-06-22 11:42:36 -05:00

erik commented

2026-06-22 11:48:08 -05:00

Author

Owner

Synced from todu comment by @todu on 2026-06-22T16:45:51.215Z

Review update

PR: #190 is open and reviewed.
Result: approved; no blocking issues or warnings found.
Verified: local ./scripts/pre-pr.sh passed and Forgejo Actions #260 is successful.
Follow-up: wait for explicit human merge approval; do not merge yet.

_Synced from todu comment by @todu on 2026-06-22T16:45:51.215Z_ ### Review update - PR: #190 is open and reviewed. - Result: approved; no blocking issues or warnings found. - Verified: local `./scripts/pre-pr.sh` passed and Forgejo Actions #260 is successful. - Follow-up: wait for explicit human merge approval; do not merge yet.

erik

2026-06-22 11:53:37 -05:00

closed this issue
added
status:done
and removed
status:inprogress
labels

erik commented

2026-06-22 11:53:38 -05:00

Author

Owner

Synced from todu comment by @todu on 2026-06-22T16:52:21.583Z

Closing summary

Readiness: READY

Evidence from PR #190 merged to main:

Public tag badges now link to tag pages: merge commit 05f9cd1 includes commit 67876e9, which introduced shared TagBadgeLink usage in FeedTagBadges and PostTags with href={/tags/${tag.slug}}.
Badge appearance and accessible interaction states are preserved: TagBadgeLink keeps the existing badge classes and hover styling, preserves leading-5 for feed badges, and adds focus ring classes including focus:ring-teal-500 and dark-mode focus offset styling.
Public page test coverage was updated in template/site/src/routes/__tests__/public.test.ts to render a tag and assert href="/tags/markdown", #markdown, and focus:ring-teal-500.

Task closed.

_Synced from todu comment by @todu on 2026-06-22T16:52:21.583Z_ ### Closing summary Readiness: READY Evidence from PR #190 merged to `main`: - Public tag badges now link to tag pages: merge commit `05f9cd1` includes commit `67876e9`, which introduced shared `TagBadgeLink` usage in `FeedTagBadges` and `PostTags` with `href={`/tags/${tag.slug}`}`. - Badge appearance and accessible interaction states are preserved: `TagBadgeLink` keeps the existing badge classes and hover styling, preserves `leading-5` for feed badges, and adds focus ring classes including `focus:ring-teal-500` and dark-mode focus offset styling. - Public page test coverage was updated in `template/site/src/routes/__tests__/public.test.ts` to render a tag and assert `href="/tags/markdown"`, `#markdown`, and `focus:ring-teal-500`. Task closed.