erik/slugkit
1
0
Fork 0
Code Issues 6 Pull requests Projects Releases 6 Packages Wiki Activity Actions

Use feed-style previews on tag pages #191

Merged
erik merged 1 commit from feat/task-6903971b-feed-style-tag-pages into main 2026-06-22 12:32:20 -05:00
Conversation 2 Commits 1 Files changed 4 +303 -80
erik commented 2026-06-22 11:59:08 -05:00
Owner
Copy link

Summary

Update /tags/{tag} pages to render tagged posts with the same feed-style preview cards used by /feed.

Task

Task: #task-6903971b

Changes

  • Hydrate tag detail posts as PublicFeedPost records so preview images and source metadata are available.
  • Render tag detail posts with the existing feed post preview component.
  • Preserve the tag heading and empty-state behavior inside the new feed-style container.
  • Remove the old generic post summary list renderer that is no longer used.
  • Update public page tests to assert feed-style tag detail markup, post links, preview image, excerpt, and draft filtering.

Testing

  • Unit tests added/updated
  • Manual testing performed

Verification:

  • npm exec --workspace @slugkit/template-site -- vitest run --config ../../vitest.config.ts src/routes/__tests__/public.test.ts
  • ./scripts/pre-pr.sh

Checklist

  • ./scripts/pre-pr.sh passes
  • Documentation updated (if needed)
  • No unrelated changes included
## Summary Update `/tags/{tag}` pages to render tagged posts with the same feed-style preview cards used by `/feed`. ## Task Task: #task-6903971b ## Changes - Hydrate tag detail posts as `PublicFeedPost` records so preview images and source metadata are available. - Render tag detail posts with the existing feed post preview component. - Preserve the tag heading and empty-state behavior inside the new feed-style container. - Remove the old generic post summary list renderer that is no longer used. - Update public page tests to assert feed-style tag detail markup, post links, preview image, excerpt, and draft filtering. ## Testing - [x] Unit tests added/updated - [x] Manual testing performed Verification: - `npm exec --workspace @slugkit/template-site -- vitest run --config ../../vitest.config.ts src/routes/__tests__/public.test.ts` - `./scripts/pre-pr.sh` ## Checklist - [x] `./scripts/pre-pr.sh` passes - [x] Documentation updated (if needed) - [x] No unrelated changes included
feat: use feed previews on tag pages
All checks were successful
CI / build-lint-test (pull_request) Successful in 43s
Details
4b62cdfd48 
Task: #task-6903971b
erik commented 2026-06-22 12:02:03 -05:00
Author
Owner
Copy link

PR Review

Summary: The tag detail route now hydrates tagged posts as PublicFeedPost items and renders them through the existing feed preview component, preserving the tag heading and a published-post empty state. The focused public route test now verifies feed-style tag detail markup, post detail linking, preview image rendering, excerpts, and draft filtering.

Acceptance criteria:

  • /tags/{tag} displays tagged posts as feed-style link previews.
  • Each preview links to the correct post detail page.
  • The layout is visually consistent with /feed previews.
  • Empty tag pages still show the existing appropriate empty state.
  • Public page tests are updated or added for the tag detail layout.

Verification:

  • Reviewed PR #191 diff against task task-6903971b.
  • Local ./scripts/pre-pr.sh passed: format, lint, typecheck, and tests.
  • Forgejo Actions #262 is successful for commit 4b62cdfd48 (build-lint-test).

Blocking issues: None.

Warnings: None.

Final verdict: Approved. Stop at the human merge gate; do not merge without explicit approval.

### PR Review Summary: The tag detail route now hydrates tagged posts as `PublicFeedPost` items and renders them through the existing feed preview component, preserving the tag heading and a published-post empty state. The focused public route test now verifies feed-style tag detail markup, post detail linking, preview image rendering, excerpts, and draft filtering. Acceptance criteria: - [x] `/tags/{tag}` displays tagged posts as feed-style link previews. - [x] Each preview links to the correct post detail page. - [x] The layout is visually consistent with `/feed` previews. - [x] Empty tag pages still show the existing appropriate empty state. - [x] Public page tests are updated or added for the tag detail layout. Verification: - [x] Reviewed PR #191 diff against task `task-6903971b`. - [x] Local `./scripts/pre-pr.sh` passed: format, lint, typecheck, and tests. - [x] Forgejo Actions #262 is successful for commit `4b62cdfd48` (`build-lint-test`). Blocking issues: None. Warnings: None. Final verdict: Approved. Stop at the human merge gate; do not merge without explicit approval.
erik force-pushed feat/task-6903971b-feed-style-tag-pages from 4b62cdfd48
All checks were successful
CI / build-lint-test (pull_request) Successful in 43s
Details
to 216faa89a0
Some checks failed
CI / build-lint-test (pull_request) Failing after 41s
Details
2026-06-22 12:24:58 -05:00 Compare
erik force-pushed feat/task-6903971b-feed-style-tag-pages from 216faa89a0
Some checks failed
CI / build-lint-test (pull_request) Failing after 41s
Details
to 3c580036c4
All checks were successful
CI / build-lint-test (pull_request) Successful in 48s
Details
2026-06-22 12:27:36 -05:00 Compare
erik commented 2026-06-22 12:28:43 -05:00
Author
Owner
Copy link

PR Review Update

Re-reviewed PR #191 after requested changes. The PR now keeps /tags/{tag} in the feed-style layout with the feed sidebar/profile card, removes the duplicate Tags card and hardcoded RSS sidebar/button, updates /tags into a searchable 4-column tag-card grid, and renders configured site-owned accounts (including an RSS feed account created with make slug accounts create --owner-type site ...) on the home hero, /feed profile card, and /tags/{tag} profile card.

Acceptance criteria remain satisfied:

  • /tags/{tag} displays tagged posts as feed-style link previews.
  • Each preview links to the correct post detail page.
  • The layout is visually consistent with /feed previews.
  • Empty tag pages still show an appropriate empty state.
  • Public page tests are updated for tag detail layout, /tags card/search behavior, and configured RSS/site account rendering.

Verification:

  • Local ./scripts/pre-pr.sh passed.
  • Local CI-equivalent npm run build && npm run lint && npm test passed.
  • Forgejo Actions #264 passed for commit 3c58003.
  • Chromium verified the locally-created RSS site account renders on / and /tags/activitypub as an RSS icon link.

Blocking issues: None.

Warnings: None.

Final verdict: Approved. Stop at the human merge gate; do not merge without explicit approval.

### PR Review Update Re-reviewed PR #191 after requested changes. The PR now keeps `/tags/{tag}` in the feed-style layout with the feed sidebar/profile card, removes the duplicate Tags card and hardcoded RSS sidebar/button, updates `/tags` into a searchable 4-column tag-card grid, and renders configured site-owned accounts (including an RSS feed account created with `make slug accounts create --owner-type site ...`) on the home hero, `/feed` profile card, and `/tags/{tag}` profile card. Acceptance criteria remain satisfied: - [x] `/tags/{tag}` displays tagged posts as feed-style link previews. - [x] Each preview links to the correct post detail page. - [x] The layout is visually consistent with `/feed` previews. - [x] Empty tag pages still show an appropriate empty state. - [x] Public page tests are updated for tag detail layout, `/tags` card/search behavior, and configured RSS/site account rendering. Verification: - Local `./scripts/pre-pr.sh` passed. - Local CI-equivalent `npm run build && npm run lint && npm test` passed. - Forgejo Actions #264 passed for commit `3c58003`. - Chromium verified the locally-created RSS site account renders on `/` and `/tags/activitypub` as an RSS icon link. Blocking issues: None. Warnings: None. Final verdict: Approved. Stop at the human merge gate; do not merge without explicit approval.
erik merged commit 23714733a1 into main 2026-06-22 12:32:20 -05:00
erik deleted branch feat/task-6903971b-feed-style-tag-pages 2026-06-22 12:32:20 -05:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
activitypub

   
admin

   
api

   
articles

   
auth

   
bug

   
cleanup

   
cli

   
comments

   
compatibility

   
config

   
contacts

   
database

   
deployment

   
design

   
dev-env

   
docs

   
documentation

   
email

   
enhancement

   
feature

   
federation

   
feed

   
homepage

   
implementation

   
integration

   
media

   
openapi

   
priority:high

   
priority:low

   
priority:medium

   
proof

   
public-routes

   
public-ui

   
release

   
safety

   
social

   
sources

   
status:active

   
status:canceled

   
status:done

   
status:inprogress

   
status:waiting

   
syndication

   
tailwind

   
template

   
test

   
web
No labels
activitypub
admin
api
articles
auth
bug
cleanup
cli
comments
compatibility
config
contacts
database
deployment
design
dev-env
docs
documentation
email
enhancement
feature
federation
feed
homepage
implementation
integration
media
openapi
priority:high
priority:low
priority:medium
proof
public-routes
public-ui
release
safety
social
sources
status:active
status:canceled
status:done
status:inprogress
status:waiting
syndication
tailwind
template
test
web
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
erik/slugkit!191
No description provided.