erik/slugkit
1
0
Fork 0
Code Issues 6 Pull requests Projects Releases 6 Packages Wiki Activity Actions

Update actor sidebar metadata #193

Merged
erik merged 1 commit from feat/task-5bc8415a-actor-sidebar-metadata into main 2026-06-22 13:18:25 -05:00
Conversation 2 Commits 1 Files changed 3 +167 -57
erik commented 2026-06-22 12:50:17 -05:00
Owner
Copy link

Summary

Update public sidebar actor cards and navigation sections so actor metadata and sidebar links are consistent across feed-style public pages.

Task

Task: #task-5bc8415a

Changes

  • Added follower and following counts to the actor profile card when a primary actor is configured.
  • Hide follower/following counts when no primary actor is configured.
  • Removed Sources and Tags browse links from the actor-card metadata row so they do not duplicate sidebar navigation.
  • Added Browse Tags as its own sidebar card.
  • Removed hardcoded RSS sidebar sections.
  • Applied the shared sidebar/profile card to articles and sources pages in addition to feed/tag pages.
  • Updated public page tests for actor/no-actor metadata, sidebar navigation, and RSS removal.

Testing

  • Unit tests added/updated
  • Manual testing performed

Verification:

  • npm exec --workspace @slugkit/template-site -- vitest run --config ../../vitest.config.ts src/routes/__tests__/public.test.ts
  • ./scripts/pre-pr.sh
  • npm run build && npm run lint && npm test

Checklist

  • ./scripts/pre-pr.sh passes
  • Documentation updated (if needed)
  • No unrelated changes included
## Summary Update public sidebar actor cards and navigation sections so actor metadata and sidebar links are consistent across feed-style public pages. ## Task Task: #task-5bc8415a ## Changes - Added follower and following counts to the actor profile card when a primary actor is configured. - Hide follower/following counts when no primary actor is configured. - Removed Sources and Tags browse links from the actor-card metadata row so they do not duplicate sidebar navigation. - Added Browse Tags as its own sidebar card. - Removed hardcoded RSS sidebar sections. - Applied the shared sidebar/profile card to articles and sources pages in addition to feed/tag pages. - Updated public page tests for actor/no-actor metadata, sidebar navigation, and RSS removal. ## Testing - [x] Unit tests added/updated - [x] Manual testing performed Verification: - `npm exec --workspace @slugkit/template-site -- vitest run --config ../../vitest.config.ts src/routes/__tests__/public.test.ts` - `./scripts/pre-pr.sh` - `npm run build && npm run lint && npm test` ## Checklist - [x] `./scripts/pre-pr.sh` passes - [x] Documentation updated (if needed) - [x] No unrelated changes included
feat: update actor sidebar metadata
All checks were successful
CI / build-lint-test (pull_request) Successful in 49s
Details
b957b35d3b 
Task: #task-5bc8415a
erik commented 2026-06-22 12:52:20 -05:00
Author
Owner
Copy link

PR Review

Summary: Approved. The diff updates the shared public sidebar/profile card path, adds follower/following counts only when a configured actor exists, removes duplicated profile-card browse metadata/RSS cards, and adds dedicated Tags navigation. PR body includes local verification evidence (vitest public route tests, ./scripts/pre-pr.sh, and npm run build && npm run lint && npm test). Forgejo Actions #266 is successful for build-lint-test.

Acceptance criteria:

  • Actor cards show follower and following counts only when actor data is configured.
  • Feeds, sources, accounts, tags, and articles sidebars use the updated actor card behavior.
  • The duplicated sources/recommended site link is resolved.
  • Browse tags appears in its own section.
  • The RSS section is removed.

Blocking issues: none.
Warnings: none.

Final verdict: approved; do not merge until human approval.

## PR Review Summary: Approved. The diff updates the shared public sidebar/profile card path, adds follower/following counts only when a configured actor exists, removes duplicated profile-card browse metadata/RSS cards, and adds dedicated Tags navigation. PR body includes local verification evidence (`vitest` public route tests, `./scripts/pre-pr.sh`, and `npm run build && npm run lint && npm test`). Forgejo Actions #266 is successful for `build-lint-test`. Acceptance criteria: - [x] Actor cards show follower and following counts only when actor data is configured. - [x] Feeds, sources, accounts, tags, and articles sidebars use the updated actor card behavior. - [x] The duplicated sources/recommended site link is resolved. - [x] Browse tags appears in its own section. - [x] The RSS section is removed. Blocking issues: none. Warnings: none. Final verdict: approved; do not merge until human approval.
erik force-pushed feat/task-5bc8415a-actor-sidebar-metadata from b957b35d3b
All checks were successful
CI / build-lint-test (pull_request) Successful in 49s
Details
to cc1c0f37b5
All checks were successful
CI / build-lint-test (pull_request) Successful in 50s
Details
2026-06-22 13:17:06 -05:00 Compare
erik commented 2026-06-22 13:18:25 -05:00
Author
Owner
Copy link

PR Review Update

Re-reviewed PR #193 after requested sidebar consistency changes. The PR now keeps the updated actor sidebar behavior on feed-style pages that retain sidebars, while /articles and /sources remain full-width pages without sidebars.

Acceptance criteria:

  • Actor cards show follower and following counts only when actor data is configured.
  • Feed and tag sidebars use the updated actor card behavior; articles and sources intentionally do not render sidebars.
  • The duplicated sources/recommended site link is resolved by removing Sources/Tags from the actor-card metadata row.
  • Browse tags appears as its own sidebar section where sidebars remain.
  • The hardcoded RSS section is removed.

Verification:

  • Local ./scripts/pre-pr.sh passed.
  • Local CI-equivalent npm run build && npm run lint && npm test passed.
  • Forgejo Actions #267 passed for commit cc1c0f3.

Blocking issues: none.
Warnings: none.

Final verdict: approved; merge approved by human.

## PR Review Update Re-reviewed PR #193 after requested sidebar consistency changes. The PR now keeps the updated actor sidebar behavior on feed-style pages that retain sidebars, while `/articles` and `/sources` remain full-width pages without sidebars. Acceptance criteria: - [x] Actor cards show follower and following counts only when actor data is configured. - [x] Feed and tag sidebars use the updated actor card behavior; articles and sources intentionally do not render sidebars. - [x] The duplicated sources/recommended site link is resolved by removing Sources/Tags from the actor-card metadata row. - [x] Browse tags appears as its own sidebar section where sidebars remain. - [x] The hardcoded RSS section is removed. Verification: - Local `./scripts/pre-pr.sh` passed. - Local CI-equivalent `npm run build && npm run lint && npm test` passed. - Forgejo Actions #267 passed for commit `cc1c0f3`. Blocking issues: none. Warnings: none. Final verdict: approved; merge approved by human.
erik merged commit f1f25193dd into main 2026-06-22 13:18:25 -05:00
erik deleted branch feat/task-5bc8415a-actor-sidebar-metadata 2026-06-22 13:18:25 -05:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
activitypub

   
admin

   
api

   
articles

   
auth

   
bug

   
cleanup

   
cli

   
comments

   
compatibility

   
config

   
contacts

   
database

   
deployment

   
design

   
dev-env

   
docs

   
documentation

   
email

   
enhancement

   
feature

   
federation

   
feed

   
homepage

   
implementation

   
integration

   
media

   
openapi

   
priority:high

   
priority:low

   
priority:medium

   
proof

   
public-routes

   
public-ui

   
release

   
safety

   
social

   
sources

   
status:active

   
status:canceled

   
status:done

   
status:inprogress

   
status:waiting

   
syndication

   
tailwind

   
template

   
test

   
web
No labels
activitypub
admin
api
articles
auth
bug
cleanup
cli
comments
compatibility
config
contacts
database
deployment
design
dev-env
docs
documentation
email
enhancement
feature
federation
feed
homepage
implementation
integration
media
openapi
priority:high
priority:low
priority:medium
proof
public-routes
public-ui
release
safety
social
sources
status:active
status:canceled
status:done
status:inprogress
status:waiting
syndication
tailwind
template
test
web
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
erik/slugkit!193
No description provided.