Fix default template ActivityPub actor identity #201

New issue

Closed

opened 2026-06-24 13:31:36 -05:00 by erik · 2 comments

erik commented

2026-06-24 13:31:36 -05:00

Owner

Bug

The template site's default ActivityPub actor identity uses personal values:

username: erik
display name: Erik Craddock

The template should use neutral example defaults instead:

username: slugkitexample
display name: Slugkit Example

Expected behavior

New template sites and generated sites should start with neutral Slugkit example actor defaults, not personal identity values.

Acceptance criteria

Default template actor username is slugkitexample.
Default template actor display name is Slugkit Example.
Tests and snapshots/fixtures are updated so template defaults no longer reference erik / Erik Craddock except where explicitly testing arbitrary user-provided values.
slug init generated sites inherit the neutral defaults.

## Bug The template site's default ActivityPub actor identity uses personal values: - username: `erik` - display name: `Erik Craddock` The template should use neutral example defaults instead: - username: `slugkitexample` - display name: `Slugkit Example` ## Expected behavior New template sites and generated sites should start with neutral Slugkit example actor defaults, not personal identity values. ## Acceptance criteria - [ ] Default template actor username is `slugkitexample`. - [ ] Default template actor display name is `Slugkit Example`. - [ ] Tests and snapshots/fixtures are updated so template defaults no longer reference `erik` / `Erik Craddock` except where explicitly testing arbitrary user-provided values. - [ ] `slug init` generated sites inherit the neutral defaults.

erik added the

labels

2026-06-24 13:31:36 -05:00

erik commented

2026-06-24 13:48:13 -05:00

Author

Owner

Synced from todu comment by @todu on 2026-06-24T18:45:48.102Z

PR review completed for slugkit PR #203.

Result: approved

Acceptance criteria: 4/4 met, 0 missing.

Verification:

Reviewed task scope, PR body, and diff for neutral template ActivityPub actor defaults.
Confirmed default actor username is now slugkitexample.
Confirmed default actor display name is now Slugkit Example.
Confirmed settings placeholders use neutral values and no longer use erik / Erik Craddock as placeholders.
Confirmed slug init tests verify generated sites inherit the neutral actor defaults and placeholders.
Local targeted tests passed: npm exec --workspace @slugkit/template-site -- vitest run --config ./vitest.config.ts src/federation/__tests__/activitypub.test.ts src/routes/__tests__/admin-activitypub.test.ts src/db/__tests__/migrations.test.ts and npm exec --workspace @evcraddock/slug-cli -- vitest run --config ../vitest.config.ts src/__tests__/commands.test.ts.
Manual generated-site inheritance check passed with slug init /tmp/slugkit-default-actor-check --name default-actor-check --site-title "Default Actor Check".
Local full gate passed: ./scripts/pre-pr.sh.
Forgejo Actions #284 succeeded for commit 274716d (build-lint-test, pull_request).

Blocking issues: none.
Warnings: none.

Merge gate: waiting for explicit human approval.

_Synced from todu comment by @todu on 2026-06-24T18:45:48.102Z_ PR review completed for slugkit PR #203. Result: approved Acceptance criteria: 4/4 met, 0 missing. Verification: - Reviewed task scope, PR body, and diff for neutral template ActivityPub actor defaults. - Confirmed default actor username is now `slugkitexample`. - Confirmed default actor display name is now `Slugkit Example`. - Confirmed settings placeholders use neutral values and no longer use `erik` / `Erik Craddock` as placeholders. - Confirmed `slug init` tests verify generated sites inherit the neutral actor defaults and placeholders. - Local targeted tests passed: `npm exec --workspace @slugkit/template-site -- vitest run --config ./vitest.config.ts src/federation/__tests__/activitypub.test.ts src/routes/__tests__/admin-activitypub.test.ts src/db/__tests__/migrations.test.ts` and `npm exec --workspace @evcraddock/slug-cli -- vitest run --config ../vitest.config.ts src/__tests__/commands.test.ts`. - Manual generated-site inheritance check passed with `slug init /tmp/slugkit-default-actor-check --name default-actor-check --site-title "Default Actor Check"`. - Local full gate passed: `./scripts/pre-pr.sh`. - Forgejo Actions #284 succeeded for commit `274716d` (`build-lint-test`, pull_request). Blocking issues: none. Warnings: none. Merge gate: waiting for explicit human approval.

erik

2026-06-24 13:53:45 -05:00

closed this issue
added
status:done
and removed
status:active
labels

erik commented

2026-06-24 13:53:46 -05:00

Author

Owner

Synced from todu comment by @todu on 2026-06-24T18:50:34.544Z

Completed and merged in slugkit PR #203.

Acceptance criteria: 4/4 met.

Evidence:

Default template ActivityPub actor username is now slugkitexample.
Default template ActivityPub actor display name is now Slugkit Example.
Actor settings placeholders now use slugkitexample and Slugkit Example instead of personal values.
Tests were updated for default actor creation, settings placeholders, and slug init generated output.
slug init generated-site inheritance was manually verified with /tmp/slugkit-default-actor-check.
Local targeted tests and ./scripts/pre-pr.sh passed.
Forgejo Actions #284 passed.
PR #203 merged into main, local main fast-forwarded, and the local feature branch was deleted.

_Synced from todu comment by @todu on 2026-06-24T18:50:34.544Z_ Completed and merged in slugkit PR #203. Acceptance criteria: 4/4 met. Evidence: - Default template ActivityPub actor username is now `slugkitexample`. - Default template ActivityPub actor display name is now `Slugkit Example`. - Actor settings placeholders now use `slugkitexample` and `Slugkit Example` instead of personal values. - Tests were updated for default actor creation, settings placeholders, and `slug init` generated output. - `slug init` generated-site inheritance was manually verified with `/tmp/slugkit-default-actor-check`. - Local targeted tests and `./scripts/pre-pr.sh` passed. - Forgejo Actions #284 passed. - PR #203 merged into `main`, local `main` fast-forwarded, and the local feature branch was deleted.