Fix default template ActivityPub actor identity #203

Merged

erik merged 1 commit from fix/task-eb2e7552-default-actor-identity into main

2026-06-24 13:49:55 -05:00

erik commented

2026-06-24 13:43:42 -05:00

Owner

Summary

Replace template ActivityPub actor example defaults with neutral Slugkit example identity values.

Task

Task: #task-eb2e7552

Changes

Changed the default local ActivityPub actor username to slugkitexample.
Changed the default local ActivityPub actor display name to Slugkit Example.
Updated actor settings form placeholders to use neutral example values.
Updated tests for default actor creation, settings placeholders, and slug init generated output.

Testing

Unit tests added/updated
Manual testing performed

Verification:

npm exec --workspace @slugkit/template-site -- vitest run --config ./vitest.config.ts src/federation/__tests__/activitypub.test.ts src/routes/__tests__/admin-activitypub.test.ts src/db/__tests__/migrations.test.ts
npm exec --workspace @evcraddock/slug-cli -- vitest run --config ../vitest.config.ts src/__tests__/commands.test.ts
Generated-site inheritance check with slug init /tmp/slugkit-default-actor-check --name default-actor-check --site-title "Default Actor Check"
./scripts/pre-pr.sh

Checklist

./scripts/pre-pr.sh passes
Documentation updated
No unrelated changes included

## Summary Replace template ActivityPub actor example defaults with neutral Slugkit example identity values. ## Task Task: #task-eb2e7552 ## Changes - Changed the default local ActivityPub actor username to `slugkitexample`. - Changed the default local ActivityPub actor display name to `Slugkit Example`. - Updated actor settings form placeholders to use neutral example values. - Updated tests for default actor creation, settings placeholders, and `slug init` generated output. ## Testing - [x] Unit tests added/updated - [x] Manual testing performed Verification: - `npm exec --workspace @slugkit/template-site -- vitest run --config ./vitest.config.ts src/federation/__tests__/activitypub.test.ts src/routes/__tests__/admin-activitypub.test.ts src/db/__tests__/migrations.test.ts` - `npm exec --workspace @evcraddock/slug-cli -- vitest run --config ../vitest.config.ts src/__tests__/commands.test.ts` - Generated-site inheritance check with `slug init /tmp/slugkit-default-actor-check --name default-actor-check --site-title "Default Actor Check"` - `./scripts/pre-pr.sh` ## Checklist - [x] `./scripts/pre-pr.sh` passes - [x] Documentation updated - [x] No unrelated changes included

erik added 1 commit

2026-06-24 13:43:42 -05:00

fix: use neutral template actor defaults

CI / build-lint-test (pull_request) Successful in 52s

Details

274716dff2

Task: #task-eb2e7552

erik commented

2026-06-24 13:45:29 -05:00

Author

Owner

PR review completed for task task-eb2e7552.

Result: approved

Acceptance criteria: 4/4 met, 0 missing.

Verification:

Reviewed task scope, PR body, and diff for neutral template ActivityPub actor defaults.
Confirmed default actor username is now slugkitexample.
Confirmed default actor display name is now Slugkit Example.
Confirmed settings placeholders use neutral values and no longer use erik / Erik Craddock as placeholders.
Confirmed slug init tests verify generated sites inherit the neutral actor defaults and placeholders.
Local targeted tests passed: npm exec --workspace @slugkit/template-site -- vitest run --config ./vitest.config.ts src/federation/__tests__/activitypub.test.ts src/routes/__tests__/admin-activitypub.test.ts src/db/__tests__/migrations.test.ts and npm exec --workspace @evcraddock/slug-cli -- vitest run --config ../vitest.config.ts src/__tests__/commands.test.ts.
Manual generated-site inheritance check passed with slug init /tmp/slugkit-default-actor-check --name default-actor-check --site-title "Default Actor Check".
Local full gate passed: ./scripts/pre-pr.sh.
Forgejo Actions #284 succeeded for commit 274716d (build-lint-test, pull_request).

Blocking issues: none.
Warnings: none.

Merge gate: waiting for explicit human approval.

PR Review Worker Result

pr: open
review: approved
pr_comment: posted
task_comment: posted
blocking_issues: 0
warnings: 0
criteria_total: 4
criteria_met: 4
criteria_missing: 0

PR review completed for task `task-eb2e7552`. Result: approved Acceptance criteria: 4/4 met, 0 missing. Verification: - Reviewed task scope, PR body, and diff for neutral template ActivityPub actor defaults. - Confirmed default actor username is now `slugkitexample`. - Confirmed default actor display name is now `Slugkit Example`. - Confirmed settings placeholders use neutral values and no longer use `erik` / `Erik Craddock` as placeholders. - Confirmed `slug init` tests verify generated sites inherit the neutral actor defaults and placeholders. - Local targeted tests passed: `npm exec --workspace @slugkit/template-site -- vitest run --config ./vitest.config.ts src/federation/__tests__/activitypub.test.ts src/routes/__tests__/admin-activitypub.test.ts src/db/__tests__/migrations.test.ts` and `npm exec --workspace @evcraddock/slug-cli -- vitest run --config ../vitest.config.ts src/__tests__/commands.test.ts`. - Manual generated-site inheritance check passed with `slug init /tmp/slugkit-default-actor-check --name default-actor-check --site-title "Default Actor Check"`. - Local full gate passed: `./scripts/pre-pr.sh`. - Forgejo Actions #284 succeeded for commit `274716d` (`build-lint-test`, pull_request). Blocking issues: none. Warnings: none. Merge gate: waiting for explicit human approval. PR Review Worker Result - pr: open - review: approved - pr_comment: posted - task_comment: posted - blocking_issues: 0 - warnings: 0 - criteria_total: 4 - criteria_met: 4 - criteria_missing: 0

erik referenced this pull request

2026-06-24 13:48:13 -05:00

Fix default template ActivityPub actor identity #201

erik merged commit 99d4d38377 into main

2026-06-24 13:49:55 -05:00

erik deleted branch fix/task-eb2e7552-default-actor-identity

2026-06-24 13:49:55 -05:00

erik referenced this pull request from a commit

2026-06-24 13:49:56 -05:00

Merge pull request 'Fix default template ActivityPub actor identity' (#203) from fix/task-eb2e7552-default-actor-identity into main

erik referenced this pull request

2026-06-24 13:53:46 -05:00