Bug: settings menu home link hardcodes localhost origin #214

New issue

Closed

opened 2026-06-27 11:33:44 -05:00 by erik · 2 comments

erik commented

2026-06-27 11:33:44 -05:00

Owner

Problem

The main site title/link in the settings menu can point to http://localhost:3000 instead of the deployed site origin. On slugkit.com, the menu title Slugkit links to localhost rather than the public site.

Expected

The settings menu/home title link should use the current request origin or configured public site origin, not a hardcoded localhost URL.

Scope

Audit settings layout/navigation link generation for hardcoded http://localhost:3000.
Replace hardcoded origin with request-aware or config-aware URL generation matching existing project conventions.
Ensure local development still links correctly.

Acceptance criteria

No settings/public navigation link in production points to http://localhost:3000 unless the actual request origin is localhost.
slugkit.com settings menu title links to https://slugkit.com or the correct configured public origin.
Tests cover production/public-origin behavior and local development behavior where practical.

## Problem The main site title/link in the settings menu can point to `http://localhost:3000` instead of the deployed site origin. On slugkit.com, the menu title `Slugkit` links to localhost rather than the public site. ## Expected The settings menu/home title link should use the current request origin or configured public site origin, not a hardcoded localhost URL. ## Scope - Audit settings layout/navigation link generation for hardcoded `http://localhost:3000`. - Replace hardcoded origin with request-aware or config-aware URL generation matching existing project conventions. - Ensure local development still links correctly. ## Acceptance criteria - No settings/public navigation link in production points to `http://localhost:3000` unless the actual request origin is localhost. - slugkit.com settings menu title links to `https://slugkit.com` or the correct configured public origin. - Tests cover production/public-origin behavior and local development behavior where practical.

erik

2026-06-27 11:33:44 -05:00

closed this issue
added the
bug

priority:medium

navigation

production

status:done
labels

erik commented

2026-06-28 01:23:16 -05:00

Author

Owner

Synced from todu comment by @todu on 2026-06-28T06:19:42.082Z

Close gate

Readiness: READY

Evidence:

PR #220 was merged into main.
Local main is fast-forwarded to origin/main at caa4471, merge commit for PR #220: fix: derive public home link from request origin.
Prior review comment recorded Forgejo CI passing, approval, and acceptance criteria 3/3 met.

Acceptance criteria: 3/3 met. Next action: close task.

_Synced from todu comment by @todu on 2026-06-28T06:19:42.082Z_ ### Close gate Readiness: READY Evidence: - PR #220 was merged into `main`. - Local `main` is fast-forwarded to `origin/main` at `caa4471`, merge commit for PR #220: `fix: derive public home link from request origin`. - Prior review comment recorded Forgejo CI passing, approval, and acceptance criteria 3/3 met. Acceptance criteria: 3/3 met. Next action: close task.

erik commented

2026-06-28 01:23:16 -05:00

Author

Owner

Synced from todu comment by @todu on 2026-06-28T06:18:22.655Z

Review update

PR: #220 is open with Forgejo CI passing.
Result: approved.
Follow-up: waiting for explicit human merge approval.

Acceptance criteria: 3/3 met. Blocking issues: 0. Warnings: 0.

_Synced from todu comment by @todu on 2026-06-28T06:18:22.655Z_ ### Review update - PR: https://forge.caradoc.com/erik/slugkit/pulls/220 is open with Forgejo CI passing. - Result: approved. - Follow-up: waiting for explicit human merge approval. Acceptance criteria: 3/3 met. Blocking issues: 0. Warnings: 0.