fix: derive public home link from request origin #220

Merged

erik merged 1 commit from fix/task-2aff6d58-settings-home-origin into main

2026-06-28 01:19:03 -05:00

erik commented

2026-06-27 23:06:30 -05:00

Owner

Summary

Resolve the public site title/home link from the incoming request origin when the configured site URL is still the localhost template default.
Preserve localhost links for actual localhost development requests.
Apply the same request-aware site URL to RSS feed rendering and 404 pages.
Add regression coverage for production-style https://slugkit.com requests and localhost development behavior.

Verification

npm exec --workspace @slugkit/template-site -- vitest run --config ./vitest.config.ts src/routes/tests/public.test.ts
npm run typecheck --workspace @slugkit/template-site
npm run lint
./scripts/pre-pr.sh

Task: #task-2aff6d58

## Summary - Resolve the public site title/home link from the incoming request origin when the configured site URL is still the localhost template default. - Preserve localhost links for actual localhost development requests. - Apply the same request-aware site URL to RSS feed rendering and 404 pages. - Add regression coverage for production-style `https://slugkit.com` requests and localhost development behavior. ## Verification - npm exec --workspace @slugkit/template-site -- vitest run --config ./vitest.config.ts src/routes/__tests__/public.test.ts - npm run typecheck --workspace @slugkit/template-site - npm run lint - ./scripts/pre-pr.sh Task: #task-2aff6d58

erik added 1 commit

2026-06-27 23:06:30 -05:00

fix: derive public home link from request origin

CI / build-lint-test (pull_request) Successful in 16m51s

Details

9a54167bc3

Task: #task-2aff6d58

erik commented

2026-06-28 01:18:19 -05:00

Author

Owner

Review summary

Approved.

Acceptance criteria

No settings/public navigation link in production points to http://localhost:3000 unless the actual request origin is localhost. Evidence: request-aware site URL resolution replaces the default localhost URL with the request origin for non-localhost requests, and tests assert https://slugkit.com output does not include href="http://localhost:3000".
slugkit.com settings menu title links to https://slugkit.com or the correct configured public origin. Evidence: the production-style test requests https://slugkit.com/ and asserts the site title link uses href="https://slugkit.com".
Tests cover production/public-origin behavior and local development behavior where practical. Evidence: public route tests cover both https://slugkit.com/ and http://localhost:3000/ behavior.

Blocking issues

None.

Warnings

None.

Verification reviewed

./scripts/pre-pr.sh passed locally.
Forgejo CI run #304 passed.

Final verdict

Approved. Ready for human merge approval.

### Review summary Approved. ### Acceptance criteria - [x] No settings/public navigation link in production points to `http://localhost:3000` unless the actual request origin is localhost. Evidence: request-aware site URL resolution replaces the default localhost URL with the request origin for non-localhost requests, and tests assert `https://slugkit.com` output does not include `href="http://localhost:3000"`. - [x] slugkit.com settings menu title links to `https://slugkit.com` or the correct configured public origin. Evidence: the production-style test requests `https://slugkit.com/` and asserts the site title link uses `href="https://slugkit.com"`. - [x] Tests cover production/public-origin behavior and local development behavior where practical. Evidence: public route tests cover both `https://slugkit.com/` and `http://localhost:3000/` behavior. ### Blocking issues - None. ### Warnings - None. ### Verification reviewed - `./scripts/pre-pr.sh` passed locally. - Forgejo CI run #304 passed. ### Final verdict Approved. Ready for human merge approval.

erik merged commit caa4471d01 into main

2026-06-28 01:19:03 -05:00

erik deleted branch fix/task-2aff6d58-settings-home-origin

2026-06-28 01:19:03 -05:00

erik referenced this pull request from a commit

2026-06-28 01:19:05 -05:00

Merge pull request 'fix: derive public home link from request origin' (#220) from fix/task-2aff6d58-settings-home-origin into main

erik referenced this pull request

2026-06-28 01:23:16 -05:00

Bug: settings menu home link hardcodes localhost origin #214

erik referenced this pull request

2026-06-28 01:23:16 -05:00