erik/slugkit

Fork 0

Use published slug-core package in template #242

Merged

erik merged 1 commit from fix/task-059991ea-use-published-slug-core into main

2026-06-29 10:36:18 -05:00

erik commented

2026-06-29 09:40:53 -05:00

Owner

Summary

Clarifies the package consumption model for @evcraddock/slug-core after the published package release.
Documents that the in-repo template declares the published semver dependency but npm links local packages/* workspace source during monorepo development.
Documents that generated sites created by slug init stay outside the monorepo and install the published npm package version.

Verification

npm ci
npm test
./scripts/pre-pr.sh
Forgejo CI run #335 passed for PR #242.

Task: #task-059991ea

## Summary - Clarifies the package consumption model for `@evcraddock/slug-core` after the published package release. - Documents that the in-repo template declares the published semver dependency but npm links local `packages/*` workspace source during monorepo development. - Documents that generated sites created by `slug init` stay outside the monorepo and install the published npm package version. ## Verification - `npm ci` - `npm test` - `./scripts/pre-pr.sh` - Forgejo CI run #335 passed for PR #242. Task: #task-059991ea

erik added 1 commit

2026-06-29 09:40:53 -05:00

fix: install slug core from npm in template

CI / build-lint-test (pull_request) Successful in 54s

Details

75eaa22583

Task: #task-059991ea

erik force-pushed fix/task-059991ea-use-published-slug-core from 75eaa22583

CI / build-lint-test (pull_request) Successful in 54s

Details

to cf1e5c5ea4

CI / build-lint-test (pull_request) Has been cancelled

Details

2026-06-29 10:02:58 -05:00

Compare

erik force-pushed fix/task-059991ea-use-published-slug-core from cf1e5c5ea4

CI / build-lint-test (pull_request) Has been cancelled

Details

to c7596bc6e8

CI / build-lint-test (pull_request) Failing after 48s

Details

2026-06-29 10:10:41 -05:00

Compare

erik force-pushed fix/task-059991ea-use-published-slug-core from c7596bc6e8

CI / build-lint-test (pull_request) Failing after 48s

Details

to 4c12f21b77

CI / build-lint-test (pull_request) Successful in 52s

Details

2026-06-29 10:33:25 -05:00

Compare

erik commented

2026-06-29 10:35:43 -05:00

Author

Owner

Review summary

PR #242 now matches the clarified package consumption model: local monorepo development uses npm workspace linking for packages/*, while generated sites keep published semver dependencies and install from npm outside the repo.

Acceptance criteria

@evcraddock/slug-core exists as a workspace package: already present from the package extraction work and preserved by this PR.
CLI consumes @evcraddock/slug-core: preserved through the workspace dependency model using the published semver package version that npm links locally in-repo.
Template site consumes @evcraddock/slug-core: documented as published semver in the manifest with local workspace linking during monorepo development.
Generated sites created after release depend on the published package: documented behavior is explicit; generated sites outside the monorepo install from npm.
Public exports are documented and tested: previously covered by slug-core package docs/tests; this PR only clarifies consumption docs.
Package is published and post-publish import verification succeeds: completed earlier for @evcraddock/slug-core@0.1.0.
./scripts/pre-pr.sh passes: verified locally, and Forgejo CI run #335 passed.

Blocking issues

None.

Warnings

None.

Verdict

Approved. Stop at the human merge gate.

### Review summary PR #242 now matches the clarified package consumption model: local monorepo development uses npm workspace linking for `packages/*`, while generated sites keep published semver dependencies and install from npm outside the repo. ### Acceptance criteria - [x] `@evcraddock/slug-core` exists as a workspace package: already present from the package extraction work and preserved by this PR. - [x] CLI consumes `@evcraddock/slug-core`: preserved through the workspace dependency model using the published semver package version that npm links locally in-repo. - [x] Template site consumes `@evcraddock/slug-core`: documented as published semver in the manifest with local workspace linking during monorepo development. - [x] Generated sites created after release depend on the published package: documented behavior is explicit; generated sites outside the monorepo install from npm. - [x] Public exports are documented and tested: previously covered by `slug-core` package docs/tests; this PR only clarifies consumption docs. - [x] Package is published and post-publish import verification succeeds: completed earlier for `@evcraddock/slug-core@0.1.0`. - [x] `./scripts/pre-pr.sh` passes: verified locally, and Forgejo CI run #335 passed. ### Blocking issues None. ### Warnings None. ### Verdict Approved. Stop at the human merge gate.

erik merged commit 01a69bf584 into main

2026-06-29 10:36:18 -05:00

erik deleted branch fix/task-059991ea-use-published-slug-core

2026-06-29 10:36:18 -05:00

erik referenced this pull request from a commit

2026-06-29 10:36:18 -05:00

Merge pull request 'Use published slug-core package in template' (#242) from fix/task-059991ea-use-published-slug-core into main

erik referenced this pull request

2026-06-29 10:40:02 -05:00

Extract slug-core npm package #236

erik referenced this pull request

2026-06-29 10:40:02 -05:00