Include Garage in slug init dev environment #252
No reviewers
Labels
No labels
activitypub
admin
api
architecture
articles
auth
bug
cleanup
cli
comments
compatibility
config
contacts
content
database
deployment
design
dev-env
diagnostics
docs
documentation
email
enhancement
feature
federation
feed
health
homepage
implementation
integration
logging
mastodon
media
navigation
npm-packages
openapi
opengraph
packages
passkeys
preview
priority:high
priority:low
priority:medium
production
proof
proxy
public-routes
public-ui
release
safety
slug-api
slug-auth
slug-core
slug-federation
slug-media
slug-template
social
sources
status:active
status:canceled
status:done
status:inprogress
status:waiting
syndication
tailwind
template
test
web
webauthn
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
erik/slugkit!252
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "fix/task-a01397b1-slug-init-garage-dev-env"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
docker-compose.yml,garage.toml, andscripts/setup-garage.sh.Procfile.devandMakefilesomake devstarts Garage alongside the app/CSS watcher andmake garage-setupconfigures the local media bucket..env.exampleand README docs for local Garage media setup.slug initoutput checks so Garage files/config are covered.@evcraddock/slug-templatepackage/version bump is involved.Verification
npm test --workspace @evcraddock/slug-cli -- commands.test.tsnpm test --workspace @slugkit/template-site -- src/__tests__/dev-environment.test.ts src/api/__tests__/routes.test.tsdocker-compose.yml,garage.toml,scripts/setup-garage.sh,Procfile.dev,Makefile,.env.example, and README Garage references./scripts/pre-pr.shTask: #task-a01397b1
Review summary
PR #252 fixes generated-site local media setup by including Garage in the initialized site's dev environment and adding setup/docs/tests for the generated files.
Acceptance criteria
slug initoutput includes Garage/S3-compatible dev-environment service configuration — generated sites now includedocker-compose.yml,garage.toml,scripts/setup-garage.sh, and adocker:process inProcfile.dev.Makefile,Procfile.dev,docker-compose.yml, and env example files work together for local media storage setup —make devstarts Docker Compose via Procfile,make garage-setupruns the setup script, and.env.exampleincludes Garage/S3 variables.make garage-setup, restart flow, and local Garage behavior.make dev— root dev setup is preserved; template-site dev environment tests and full pre-PR passed.Verification evidence
./scripts/pre-pr.shpassed.slug initoutput inspection confirmed generated Garage files and references.@evcraddock/slug-template@0.1.4and@evcraddock/slug-cli@0.6.4.Blocking issues
None.
Verdict
Approved for merge. Human merge approval still required.
746ad4f0821277d5fedeReview summary
Approved.
Acceptance criteria
slug initoutput includes Garage/S3-compatible dev-environment service configuration.Makefile,Procfile.dev,docker-compose.yml, and env example files work together for local media storage setup.make dev.Blocking issues
None.
Warnings
None.
Validation reviewed
build-lint-testsuccess (#381)./scripts/pre-pr.shFinal verdict
Approved.