erik/slugkit
1
0
Fork 0
Code Issues 4 Pull requests Projects Releases 17 Packages Wiki Activity Actions

Remove duplicate title from article posts #273

Merged
erik merged 1 commit from fix/task-7a2cf1dd-duplicate-article-title into main 2026-07-24 15:12:14 -05:00
Conversation 1 Commits 1 Files changed 4 +49 -4
erik commented 2026-07-24 15:07:38 -05:00
Owner
Copy link

Summary

Remove duplicate article titles from post detail pages while preserving distinct and non-leading Markdown headings.

Task

Task: #task-7a2cf1dd

Changes

  • Add an opt-in Markdown rendering option that omits a leading H1 only when its normalized text matches the canonical article title.
  • Enable duplicate-title omission only for article detail content.
  • Preserve unmatched leading headings, later H1 headings, and non-article Markdown behavior.
  • Add Markdown renderer and public route regression coverage.

Testing

  • Unit tests added/updated
  • Matching, unmatched, and non-leading H1 behavior covered
  • Article detail output asserts exactly one H1
  • Manual testing performed with /posts/daily-process
  • Full local suite passes: 127 CLI tests and 307 site tests

Checklist

  • ./scripts/pre-pr.sh passes
  • Documentation updated (not needed; rendering bug fix)
  • No unrelated changes included
## Summary Remove duplicate article titles from post detail pages while preserving distinct and non-leading Markdown headings. ## Task Task: #task-7a2cf1dd ## Changes - Add an opt-in Markdown rendering option that omits a leading H1 only when its normalized text matches the canonical article title. - Enable duplicate-title omission only for article detail content. - Preserve unmatched leading headings, later H1 headings, and non-article Markdown behavior. - Add Markdown renderer and public route regression coverage. ## Testing - [x] Unit tests added/updated - [x] Matching, unmatched, and non-leading H1 behavior covered - [x] Article detail output asserts exactly one H1 - [x] Manual testing performed with `/posts/daily-process` - [x] Full local suite passes: 127 CLI tests and 307 site tests ## Checklist - [x] `./scripts/pre-pr.sh` passes - [x] Documentation updated (not needed; rendering bug fix) - [x] No unrelated changes included
fix: remove duplicate article titles
All checks were successful
CI / build-lint-test (pull_request) Successful in 2m9s
Details
d27921f580 
Task: #task-7a2cf1dd
erik commented 2026-07-24 15:11:22 -05:00
Author
Owner
Copy link

Independent review — approved

Summary

  • Reviewed PR #273 against Todu task task-7a2cf1dd, the complete four-file diff, repository standards, and the relevant/full test suite.
  • The opt-in renderer removes only a leading Markdown H1 whose whitespace-normalized source text matches the canonical article title, and the option is passed only for article detail pages.

Acceptance criteria

  • Met — Remove the duplicate article title below the banner URL. The canonical page H1 remains, while a matching leading content H1 is omitted before rendered article content.
  • Met — Article posts display their title exactly once. The route regression test renders an article with a matching content H1 and asserts exactly one <h1> in the response.

Behavior and regression coverage

  • Matching leading H1: omitted.
  • Distinct leading H1: preserved.
  • Matching later H1: preserved.
  • Non-article/default Markdown behavior: preserved because omission is opt-in and article-gated; the standard renderer test still verifies normal H1 output.
  • Later H2/content, banner rendering, Markdown safety, and other article detail behavior remain covered.
  • Tests are adequate: focused site suite passed (46 files, 307 tests), and ./scripts/pre-pr.sh passed formatting, lint, typecheck, generated CSS, and all workspace tests (including 127 CLI and 307 site tests).

Blockers: none.

Warnings: none.

Verdict: APPROVED. All 2 acceptance criteria are met; no correctness, scope, security, or maintainability issues found.

### Independent review — approved **Summary** - Reviewed PR #273 against Todu task `task-7a2cf1dd`, the complete four-file diff, repository standards, and the relevant/full test suite. - The opt-in renderer removes only a leading Markdown H1 whose whitespace-normalized source text matches the canonical article title, and the option is passed only for article detail pages. **Acceptance criteria** - [x] **Met — Remove the duplicate article title below the banner URL.** The canonical page H1 remains, while a matching leading content H1 is omitted before rendered article content. - [x] **Met — Article posts display their title exactly once.** The route regression test renders an article with a matching content H1 and asserts exactly one `<h1>` in the response. **Behavior and regression coverage** - Matching leading H1: omitted. - Distinct leading H1: preserved. - Matching later H1: preserved. - Non-article/default Markdown behavior: preserved because omission is opt-in and article-gated; the standard renderer test still verifies normal H1 output. - Later H2/content, banner rendering, Markdown safety, and other article detail behavior remain covered. - Tests are adequate: focused site suite passed (46 files, 307 tests), and `./scripts/pre-pr.sh` passed formatting, lint, typecheck, generated CSS, and all workspace tests (including 127 CLI and 307 site tests). **Blockers:** none. **Warnings:** none. **Verdict: APPROVED.** All 2 acceptance criteria are met; no correctness, scope, security, or maintainability issues found.
erik merged commit c1c5a9ef92 into main 2026-07-24 15:12:14 -05:00
erik deleted branch fix/task-7a2cf1dd-duplicate-article-title 2026-07-24 15:12:14 -05:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
activitypub

   
admin

   
api

   
architecture

   
articles

   
auth

   
bug

   
cleanup

   
cli

   
comments

   
compatibility

   
config

   
contacts

   
content

   
database

   
deployment

   
design

   
dev-env

   
diagnostics

   
docs

   
documentation

   
email

   
enhancement

   
feature

   
federation

   
feed

   
health

   
homepage

   
implementation

   
integration

   
logging

   
mastodon

   
media

   
navigation

   
npm-packages

   
openapi

   
opengraph

   
packages

   
passkeys

   
preview

   
priority:high

   
priority:low

   
priority:medium

   
production

   
proof

   
proxy

   
public-routes

   
public-ui

   
release

   
safety

   
slug-api

   
slug-auth

   
slug-core

   
slug-federation

   
slug-media

   
slug-template

   
social

   
sources

   
status:active

   
status:canceled

   
status:done

   
status:inprogress

   
status:waiting

   
syndication

   
tailwind

   
template

   
test

   
web

   
webauthn
No labels
activitypub
admin
api
architecture
articles
auth
bug
cleanup
cli
comments
compatibility
config
contacts
content
database
deployment
design
dev-env
diagnostics
docs
documentation
email
enhancement
feature
federation
feed
health
homepage
implementation
integration
logging
mastodon
media
navigation
npm-packages
openapi
opengraph
packages
passkeys
preview
priority:high
priority:low
priority:medium
production
proof
proxy
public-routes
public-ui
release
safety
slug-api
slug-auth
slug-core
slug-federation
slug-media
slug-template
social
sources
status:active
status:canceled
status:done
status:inprogress
status:waiting
syndication
tailwind
template
test
web
webauthn
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
erik/slugkit!273
No description provided.