erik/slugkit
1
0
Fork 0
Code Issues 4 Pull requests Projects Releases 17 Packages Wiki Activity Actions

Fix actor profile update federation #276

Merged
erik merged 1 commit from fix/task-1ce84a99-actor-profile-updates into main 2026-07-30 13:08:07 -05:00
Conversation 1 Commits 1 Files changed 6 +288 -103
erik commented 2026-07-30 12:58:29 -05:00
Owner
Copy link

Summary

Send signed ActivityPub actor Update activities after actor profile or social-account settings are saved so followers receive current profile data.

Task

Task: #task-1ce84a99

Changes

  • Extract the actor document builder so actor endpoints and update activities share the same current representation.
  • Deliver actor updates through the existing follower queue when federation is enabled and followers exist.
  • Cover summary, social-account, recipient, disabled-federation, and no-follower behavior.

Testing

  • Unit tests added/updated
  • Manual testing performed
  • ./scripts/pre-pr.sh

Checklist

  • ./scripts/pre-pr.sh passes
  • Documentation updated (not needed)
  • No unrelated changes included
## Summary Send signed ActivityPub actor `Update` activities after actor profile or social-account settings are saved so followers receive current profile data. ## Task Task: #task-1ce84a99 ## Changes - Extract the actor document builder so actor endpoints and update activities share the same current representation. - Deliver actor updates through the existing follower queue when federation is enabled and followers exist. - Cover summary, social-account, recipient, disabled-federation, and no-follower behavior. ## Testing - [x] Unit tests added/updated - [ ] Manual testing performed - [x] `./scripts/pre-pr.sh` ## Checklist - [x] `./scripts/pre-pr.sh` passes - [x] Documentation updated (not needed) - [x] No unrelated changes included
fix: federate actor profile updates
All checks were successful
CI / build-lint-test (pull_request) Successful in 2m7s
Details
06bc92068b 
Task: #task-1ce84a99
erik commented 2026-07-30 13:03:30 -05:00
Author
Owner
Copy link

Review summary

  • PR: #276 is open; CI is green.
  • Result: approved
  • Acceptance criteria:
    • Actor profile and social-account saves deliver an ActivityPub Update.
    • The activity reuses the current actor document and existing signed follower-delivery path.
    • Delivery is skipped when federation is disabled or no followers exist.
    • Tests cover summaries, social accounts, follower recipients, disabled federation, and no followers.
    • Existing generated-site tests pass through ./scripts/pre-pr.sh.
  • Blocking issues: none.
  • Warnings: none.
  • Follow-up: await explicit human merge approval.
### Review summary - PR: #276 is open; CI is green. - Result: **approved** - Acceptance criteria: - [x] Actor profile and social-account saves deliver an ActivityPub `Update`. - [x] The activity reuses the current actor document and existing signed follower-delivery path. - [x] Delivery is skipped when federation is disabled or no followers exist. - [x] Tests cover summaries, social accounts, follower recipients, disabled federation, and no followers. - [x] Existing generated-site tests pass through `./scripts/pre-pr.sh`. - Blocking issues: none. - Warnings: none. - Follow-up: await explicit human merge approval.
erik merged commit ec2bc894ec into main 2026-07-30 13:08:07 -05:00
erik deleted branch fix/task-1ce84a99-actor-profile-updates 2026-07-30 13:08:07 -05:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
activitypub

   
admin

   
api

   
architecture

   
articles

   
auth

   
bug

   
cleanup

   
cli

   
comments

   
compatibility

   
config

   
contacts

   
content

   
database

   
deployment

   
design

   
dev-env

   
diagnostics

   
docs

   
documentation

   
email

   
enhancement

   
feature

   
federation

   
feed

   
health

   
homepage

   
implementation

   
integration

   
logging

   
mastodon

   
media

   
navigation

   
npm-packages

   
openapi

   
opengraph

   
packages

   
passkeys

   
preview

   
priority:high

   
priority:low

   
priority:medium

   
production

   
proof

   
proxy

   
public-routes

   
public-ui

   
release

   
safety

   
slug-api

   
slug-auth

   
slug-core

   
slug-federation

   
slug-media

   
slug-template

   
social

   
sources

   
status:active

   
status:canceled

   
status:done

   
status:inprogress

   
status:waiting

   
syndication

   
tailwind

   
template

   
test

   
web

   
webauthn
No labels
activitypub
admin
api
architecture
articles
auth
bug
cleanup
cli
comments
compatibility
config
contacts
content
database
deployment
design
dev-env
diagnostics
docs
documentation
email
enhancement
feature
federation
feed
health
homepage
implementation
integration
logging
mastodon
media
navigation
npm-packages
openapi
opengraph
packages
passkeys
preview
priority:high
priority:low
priority:medium
production
proof
proxy
public-routes
public-ui
release
safety
slug-api
slug-auth
slug-core
slug-federation
slug-media
slug-template
social
sources
status:active
status:canceled
status:done
status:inprogress
status:waiting
syndication
tailwind
template
test
web
webauthn
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
erik/slugkit!276
No description provided.