fix: clarify passing doctor package checks #292

Merged

erik merged 1 commit from fix/task-383aad92-doctor-package-output into main

2026-10-04 19:43:07 -05:00

erik commented

2026-10-04 18:30:15 -05:00

Owner

Summary

Change the passing packages message to Site reported N Slugkit package versions.
Remove the generic upgrades are advisory suffix when no actionable upgrade is identified.
Preserve existing stale-package warnings, which name the package and show current/recommended versions.
Add a plain-text regression and strengthen the existing JSON output assertion.

Verification

Both new message assertions failed before the one-line fix, reproducing the defect in text and JSON.
Focused doctor checks pass (10 tests); existing actionable upgrade warning coverage remains green.
./scripts/pre-pr.sh passed: generated CSS, formatting, lint, type checks and 1,085 local tests (504 CLI).
git diff --check passed.

No new upgrade logic, dependencies, documentation or workflows. CI continues to use test:ci and never runs integration tests.

Task: #task-383aad92

Awaiting CI, independent review and explicit human merge approval.

## Summary - Change the passing packages message to `Site reported N Slugkit package versions`. - Remove the generic `upgrades are advisory` suffix when no actionable upgrade is identified. - Preserve existing stale-package warnings, which name the package and show current/recommended versions. - Add a plain-text regression and strengthen the existing JSON output assertion. ## Verification - Both new message assertions failed before the one-line fix, reproducing the defect in text and JSON. - Focused doctor checks pass (10 tests); existing actionable upgrade warning coverage remains green. - ./scripts/pre-pr.sh passed: generated CSS, formatting, lint, type checks and 1,085 local tests (504 CLI). - git diff --check passed. No new upgrade logic, dependencies, documentation or workflows. CI continues to use test:ci and never runs integration tests. Task: #task-383aad92 Awaiting CI, independent review and explicit human merge approval.

erik added 1 commit

2026-10-04 18:30:15 -05:00

fix: clarify passing doctor package checks

CI / build-lint-test (pull_request) Successful in 57s

Details

822091029c

Report the site package count without suggesting an unspecified upgrade; preserve warnings that identify a package and actionable version change.

Task: #task-383aad92

erik commented

2026-10-04 18:33:21 -05:00

Author

Owner

PR Review

Summary

Reviewed Forgejo PR #292 for task-383aad92 against the PR diff, task acceptance criteria, and provided verification artifacts.
Scope is limited to cli/src/commands.ts and cli/src/__tests__/commands.test.ts; no workflow, dependency, documentation, or upgrade-logic changes are present.

Acceptance criteria

Passing package checks use clear, non-alarming wording: pass branch now reports Site reported N Slugkit package versions.
Upgrade guidance is specific/actionable or advisory-explained: the generic passing upgrades are advisory suffix is removed, while the stale-package branch still emits named package/version guidance.
CLI tests cover the revised doctor output: plain-text regression asserts the exact five-package line and absence of upgrade/advisory advice; JSON regression asserts the exact package message.

Evidence reviewed

/tmp/slugkit-doctor-packages-red.log: new text and JSON assertions failed before the implementation change.
/tmp/slugkit-doctor-packages-green.log: focused doctor tests passed, including 10 doctor-related tests.
/tmp/slugkit-doctor-packages-pre-pr.log: full pre-PR checks passed with 1,085 tests total.
CI artifact: Forgejo Actions task #495 at 822091029c reported success.

Blocking issues

None.

Warnings

None.

Final verdict

Approved. Merge approval remains waiting on explicit human approval.

### PR Review **Summary** - Reviewed Forgejo PR #292 for `task-383aad92` against the PR diff, task acceptance criteria, and provided verification artifacts. - Scope is limited to `cli/src/commands.ts` and `cli/src/__tests__/commands.test.ts`; no workflow, dependency, documentation, or upgrade-logic changes are present. **Acceptance criteria** - [x] Passing package checks use clear, non-alarming wording: pass branch now reports `Site reported N Slugkit package versions`. - [x] Upgrade guidance is specific/actionable or advisory-explained: the generic passing `upgrades are advisory` suffix is removed, while the stale-package branch still emits named package/version guidance. - [x] CLI tests cover the revised doctor output: plain-text regression asserts the exact five-package line and absence of upgrade/advisory advice; JSON regression asserts the exact package message. **Evidence reviewed** - `/tmp/slugkit-doctor-packages-red.log`: new text and JSON assertions failed before the implementation change. - `/tmp/slugkit-doctor-packages-green.log`: focused doctor tests passed, including 10 doctor-related tests. - `/tmp/slugkit-doctor-packages-pre-pr.log`: full pre-PR checks passed with 1,085 tests total. - CI artifact: Forgejo Actions task #495 at `822091029c` reported success. **Blocking issues** - None. **Warnings** - None. **Final verdict** - Approved. Merge approval remains waiting on explicit human approval.

erik merged commit 37161b8d71 into main

2026-10-04 19:43:07 -05:00

erik deleted branch fix/task-383aad92-doctor-package-output

2026-10-04 19:43:07 -05:00

erik referenced this pull request from a commit

2026-10-04 19:43:08 -05:00

Merge pull request 'fix: clarify passing doctor package checks' (#292) from fix/task-383aad92-doctor-package-output into main