Remove following resolve endpoint #78

New issue

Closed

opened 2026-06-01 11:47:58 -05:00 by caradoc · 2 comments

caradoc commented

2026-06-01 11:47:58 -05:00

Collaborator

Goal

Remove the standalone following target resolution endpoint until Slugkit has decided whether target resolution should be exposed separately or only happen as part of creating a follow.

Requirements

Remove POST /api/v1/following/resolve from the implementation.
Remove following.resolve from the OpenAPI document.
Remove or update tests that assert the standalone resolve endpoint exists.
Keep POST /api/v1/following responsible for accepting a follow target and returning the created pending following record.
Do not add a replacement resolve route in this task.

Acceptance criteria

POST /api/v1/following/resolve is no longer routed.
OpenAPI no longer documents following.resolve.
Following creation still accepts a target and creates a pending record.
Relevant tests and checks pass.

Dependencies

None

## Goal Remove the standalone following target resolution endpoint until Slugkit has decided whether target resolution should be exposed separately or only happen as part of creating a follow. ## Requirements - Remove `POST /api/v1/following/resolve` from the implementation. - Remove `following.resolve` from the OpenAPI document. - Remove or update tests that assert the standalone resolve endpoint exists. - Keep `POST /api/v1/following` responsible for accepting a follow target and returning the created pending following record. - Do not add a replacement resolve route in this task. ## Acceptance criteria - [ ] `POST /api/v1/following/resolve` is no longer routed. - [ ] OpenAPI no longer documents `following.resolve`. - [ ] Following creation still accepts a target and creates a pending record. - [ ] Relevant tests and checks pass. ## Dependencies - None

caradoc added the

labels

2026-06-01 11:47:58 -05:00

erik removed the

cleanup

label

2026-06-01 11:57:27 -05:00

caradoc added

priority:high

and removed

priority:medium

labels

2026-06-01 13:24:05 -05:00

caradoc commented

2026-06-01 13:34:19 -05:00

Author

Collaborator

Synced from todu comment by @todu on 2026-06-01T18:32:20.138Z

Review update

PR: #82
Result: approved
Verification: make check, ./scripts/pre-pr.sh, and Forgejo CI CI / build-lint-test (pull_request) passed.
Acceptance criteria: 4/4 met.
Follow-up: waiting for explicit human merge approval.

_Synced from todu comment by @todu on 2026-06-01T18:32:20.138Z_ ### Review update - PR: https://forge.caradoc.com/erik/slugkit/pulls/82 - Result: approved - Verification: `make check`, `./scripts/pre-pr.sh`, and Forgejo CI `CI / build-lint-test (pull_request)` passed. - Acceptance criteria: 4/4 met. - Follow-up: waiting for explicit human merge approval.

caradoc

2026-06-01 13:44:25 -05:00

closed this issue
added
status:done
and removed
status:active
labels

caradoc commented

2026-06-01 13:44:26 -05:00

Author

Collaborator

Synced from todu comment by @todu on 2026-06-01T18:44:12.246Z

Completed

Removed the standalone POST /api/v1/following/resolve route.
Removed following.resolve from OpenAPI and API/CLI specs.
Kept follow target parsing and normalization internal to POST /api/v1/following.
Updated tests to assert the resolve route is gone and create-time validation still works.
Verified with make check, ./scripts/pre-pr.sh, and passing Forgejo CI.
Merged PR #82 into main.

_Synced from todu comment by @todu on 2026-06-01T18:44:12.246Z_ ### Completed - Removed the standalone `POST /api/v1/following/resolve` route. - Removed `following.resolve` from OpenAPI and API/CLI specs. - Kept follow target parsing and normalization internal to `POST /api/v1/following`. - Updated tests to assert the resolve route is gone and create-time validation still works. - Verified with `make check`, `./scripts/pre-pr.sh`, and passing Forgejo CI. - Merged PR #82 into `main`.