Remove following resolve endpoint #82

Merged

caradoc merged 1 commit from feat/task-f94e6dd2-remove-following-resolve into main

2026-06-01 13:32:49 -05:00

caradoc commented

2026-06-01 13:31:28 -05:00

Collaborator

Summary

remove the standalone POST /api/v1/following/resolve route
keep target normalization behind POST /api/v1/following
remove following.resolve from OpenAPI and API/CLI specs
update tests for route removal and create-time validation

Verification

make check
./scripts/pre-pr.sh

Task: #task-f94e6dd2

## Summary - remove the standalone `POST /api/v1/following/resolve` route - keep target normalization behind `POST /api/v1/following` - remove `following.resolve` from OpenAPI and API/CLI specs - update tests for route removal and create-time validation ## Verification - `make check` - `./scripts/pre-pr.sh` Task: #task-f94e6dd2

caradoc added 1 commit

2026-06-01 13:31:28 -05:00

feat: remove following resolve endpoint

CI / build-lint-test (pull_request) Successful in 29s

Details

3ed5def512

Task: #task-f94e6dd2

caradoc commented

2026-06-01 13:32:16 -05:00

Author

Collaborator

PR review approved

Summary:

Removes the standalone POST /api/v1/following/resolve endpoint.
Keeps target parsing/normalization behind POST /api/v1/following.
Removes following.resolve from OpenAPI and API/CLI specs.
Updates tests to assert the route is gone and validation happens during follow creation.

Acceptance criteria:

POST /api/v1/following/resolve is no longer routed — met by route removal and test expecting 404.
OpenAPI no longer documents following.resolve — met by deleting the path and route coverage assertion.
Following creation still accepts a target and creates a pending record — met by existing create test and retained internal target parsing.
Relevant tests and checks pass — make check, ./scripts/pre-pr.sh, and Forgejo CI passed.

Blocking issues: none.

Warnings: none.

Final verdict: approved.

### PR review approved Summary: - Removes the standalone `POST /api/v1/following/resolve` endpoint. - Keeps target parsing/normalization behind `POST /api/v1/following`. - Removes `following.resolve` from OpenAPI and API/CLI specs. - Updates tests to assert the route is gone and validation happens during follow creation. Acceptance criteria: - [x] `POST /api/v1/following/resolve` is no longer routed — met by route removal and test expecting `404`. - [x] OpenAPI no longer documents `following.resolve` — met by deleting the path and route coverage assertion. - [x] Following creation still accepts a target and creates a pending record — met by existing create test and retained internal target parsing. - [x] Relevant tests and checks pass — `make check`, `./scripts/pre-pr.sh`, and Forgejo CI passed. Blocking issues: none. Warnings: none. Final verdict: approved.

caradoc merged commit fdb9f742d2 into main

2026-06-01 13:32:49 -05:00

caradoc deleted branch feat/task-f94e6dd2-remove-following-resolve

2026-06-01 13:32:49 -05:00

caradoc referenced this pull request from a commit

2026-06-01 13:32:51 -05:00

Merge pull request 'Remove following resolve endpoint' (#82) from feat/task-f94e6dd2-remove-following-resolve into main

caradoc referenced this pull request

2026-06-01 13:34:19 -05:00

Remove following resolve endpoint #78

caradoc referenced this pull request

2026-06-01 13:44:26 -05:00