erik/slugkit
1
0
Fork 0
Code Issues 6 Pull requests Projects Releases 6 Packages Wiki Activity Actions

Add actor social media account settings #185

Merged
erik merged 1 commit from feat/task-a694dade-actor-social-accounts into main 2026-06-21 23:33:31 -05:00
Conversation 2 Commits 1 Files changed 14 +698 -71
erik commented 2026-06-21 22:47:07 -05:00
Owner
Copy link

Summary

Adds actor-owned social account settings for the public ActivityPub actor.

Task

Task: #task-a694dade

Changes

  • Adds activitypub_actor_accounts for structured actor social account storage.
  • Adds actor account helpers for validated replacement/listing scoped to an actor.
  • Adds a Social accounts section to /settings/actor.
  • Saves configured social accounts with the actor settings form.
  • Publishes configured actor social accounts as ActivityPub actor profile attachments.
  • Adds migration, model, settings route, and ActivityPub actor document tests.

Testing

  • Unit tests added/updated
  • Manual testing performed

Checklist

  • ./scripts/pre-pr.sh passes
  • Documentation updated (if needed)
  • No unrelated changes included
## Summary Adds actor-owned social account settings for the public ActivityPub actor. ## Task Task: #task-a694dade ## Changes - Adds `activitypub_actor_accounts` for structured actor social account storage. - Adds actor account helpers for validated replacement/listing scoped to an actor. - Adds a Social accounts section to `/settings/actor`. - Saves configured social accounts with the actor settings form. - Publishes configured actor social accounts as ActivityPub actor profile attachments. - Adds migration, model, settings route, and ActivityPub actor document tests. ## Testing - [x] Unit tests added/updated - [ ] Manual testing performed ## Checklist - [x] `./scripts/pre-pr.sh` passes - [x] Documentation updated (if needed) - [x] No unrelated changes included
feat: add actor social account settings
All checks were successful
CI / build-lint-test (pull_request) Successful in 49s
Details
0a9f510568 
Task: #task-a694dade
erik force-pushed feat/task-a694dade-actor-social-accounts from 0a9f510568
All checks were successful
CI / build-lint-test (pull_request) Successful in 49s
Details
to 8d96a27125
All checks were successful
CI / build-lint-test (pull_request) Successful in 48s
Details
2026-06-21 22:49:13 -05:00 Compare
erik commented 2026-06-21 22:50:20 -05:00
Author
Owner
Copy link

PR Review

Summary

Reviewed PR #185 against task task-a694dade. The PR adds structured actor-owned social account storage, settings UI for configuring accounts on /settings/actor, persistence scoped to the primary ActivityPub actor, and ActivityPub actor document output for configured accounts.

Acceptance criteria

  • A settings section exists for actor social media accounts.
  • Social media account configuration is saved and available for the website actor.
  • The implementation follows existing project conventions.

Blocking issues

None.

Warnings

None.

Verification

  • Local ./scripts/pre-pr.sh passed.
  • Forgejo Actions task #255 passed for commit 8d96a27.
  • Review checked that invalid social account input is validated before actor profile persistence to avoid partial saves.

Verdict

Approved. Do not merge until explicit human merge approval is given.

## PR Review ### Summary Reviewed PR #185 against task `task-a694dade`. The PR adds structured actor-owned social account storage, settings UI for configuring accounts on `/settings/actor`, persistence scoped to the primary ActivityPub actor, and ActivityPub actor document output for configured accounts. ### Acceptance criteria - [x] A settings section exists for actor social media accounts. - [x] Social media account configuration is saved and available for the website actor. - [x] The implementation follows existing project conventions. ### Blocking issues None. ### Warnings None. ### Verification - Local `./scripts/pre-pr.sh` passed. - Forgejo Actions task `#255` passed for commit `8d96a27`. - Review checked that invalid social account input is validated before actor profile persistence to avoid partial saves. ### Verdict Approved. Do not merge until explicit human merge approval is given.
erik force-pushed feat/task-a694dade-actor-social-accounts from 8d96a27125
All checks were successful
CI / build-lint-test (pull_request) Successful in 48s
Details
to eddee62315
All checks were successful
CI / build-lint-test (pull_request) Successful in 47s
Details
2026-06-21 23:31:27 -05:00 Compare
erik commented 2026-06-21 23:32:37 -05:00
Author
Owner
Copy link

PR Review Update

Summary

Re-reviewed PR #185 after requested changes, now at commit eddee62. The PR keeps social accounts as their own visual section, uses one Save actor action for actor/profile/social account settings, constrains kind and protocol to dropdown-backed validated values, removes hardcoded home hero social icons, and displays configured actor social accounts on both the home page and /feed profile card as well as the ActivityPub actor document.

Acceptance criteria

  • A settings section exists for actor social media accounts.
  • Social media account configuration is saved and available for the website actor.
  • The implementation follows existing project conventions.

Blocking issues

None.

Warnings

None.

Verification

  • Local ./scripts/pre-pr.sh passed.
  • Forgejo Actions task #256 passed for commit eddee62.

Verdict

Approved. Do not merge until explicit human merge approval is given.

## PR Review Update ### Summary Re-reviewed PR #185 after requested changes, now at commit `eddee62`. The PR keeps social accounts as their own visual section, uses one `Save actor` action for actor/profile/social account settings, constrains `kind` and `protocol` to dropdown-backed validated values, removes hardcoded home hero social icons, and displays configured actor social accounts on both the home page and `/feed` profile card as well as the ActivityPub actor document. ### Acceptance criteria - [x] A settings section exists for actor social media accounts. - [x] Social media account configuration is saved and available for the website actor. - [x] The implementation follows existing project conventions. ### Blocking issues None. ### Warnings None. ### Verification - Local `./scripts/pre-pr.sh` passed. - Forgejo Actions task `#256` passed for commit `eddee62`. ### Verdict Approved. Do not merge until explicit human merge approval is given.
erik merged commit cda2b4112d into main 2026-06-21 23:33:31 -05:00
erik deleted branch feat/task-a694dade-actor-social-accounts 2026-06-21 23:33:31 -05:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
activitypub

   
admin

   
api

   
articles

   
auth

   
bug

   
cleanup

   
cli

   
comments

   
compatibility

   
config

   
contacts

   
database

   
deployment

   
design

   
dev-env

   
docs

   
documentation

   
email

   
enhancement

   
feature

   
federation

   
feed

   
homepage

   
implementation

   
integration

   
media

   
openapi

   
priority:high

   
priority:low

   
priority:medium

   
proof

   
public-routes

   
public-ui

   
release

   
safety

   
social

   
sources

   
status:active

   
status:canceled

   
status:done

   
status:inprogress

   
status:waiting

   
syndication

   
tailwind

   
template

   
test

   
web
No labels
activitypub
admin
api
articles
auth
bug
cleanup
cli
comments
compatibility
config
contacts
database
deployment
design
dev-env
docs
documentation
email
enhancement
feature
federation
feed
homepage
implementation
integration
media
openapi
priority:high
priority:low
priority:medium
proof
public-routes
public-ui
release
safety
social
sources
status:active
status:canceled
status:done
status:inprogress
status:waiting
syndication
tailwind
template
test
web
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
erik/slugkit!185
No description provided.