fix: keep ActivityPub integration tests local #265

Merged

erik merged 1 commit from fix/task-eeedea6d-activitypub-ci-tests into main

2026-07-22 07:05:39 -05:00

erik commented

2026-07-22 07:02:33 -05:00

Owner

Summary

Keep timing-sensitive ActivityPub integration tests in the complete local suite while excluding them from ordinary Forgejo CI.

Task

task-eeedea6d

Changes

Rename signed-request, queue, delivery, and federation-processing tests to *.integration.test.ts.
Add npm run test:ci and use it in the Forgejo workflow.
Preserve the complete integration suite in npm test and ./scripts/pre-pr.sh.
Document and test the CI-versus-local test boundary.

Testing

npm run test:ci (263 template tests)
./scripts/pre-pr.sh (complete suite, 301 template tests)

Checklist

./scripts/pre-pr.sh passes
Documentation updated
No unrelated changes included

## Summary Keep timing-sensitive ActivityPub integration tests in the complete local suite while excluding them from ordinary Forgejo CI. ## Task task-eeedea6d ## Changes - Rename signed-request, queue, delivery, and federation-processing tests to `*.integration.test.ts`. - Add `npm run test:ci` and use it in the Forgejo workflow. - Preserve the complete integration suite in `npm test` and `./scripts/pre-pr.sh`. - Document and test the CI-versus-local test boundary. ## Testing - [x] `npm run test:ci` (263 template tests) - [x] `./scripts/pre-pr.sh` (complete suite, 301 template tests) ## Checklist - [x] `./scripts/pre-pr.sh` passes - [x] Documentation updated - [x] No unrelated changes included

erik added 1 commit

2026-07-22 07:02:33 -05:00

fix: keep federation integration tests local

CI / build-lint-test (pull_request) Successful in 2m15s

Details

d50cd0610c

Task: #task-eeedea6d

erik commented

2026-07-22 07:05:21 -05:00

Author

Owner

Review update

PR: #265 open; CI run #414 passed.
Result: approved.
Scope: Adds an explicit integration-test filename convention and keeps the complete suite local while ordinary CI runs deterministic tests.

Acceptance criteria

Met: *.integration.test.ts clearly identifies signed-request, queue, delivery, and federation-processing tests.
Met: Forgejo CI uses npm run test:ci, which excludes the integration-test glob.
Met: Fast ActivityPub actor, configuration, and key tests retain the ordinary .test.ts suffix and run in CI.
Met: ./scripts/pre-pr.sh still invokes complete npm test; 301 template tests passed locally.
Met: docs/CONTRIBUTING.md documents naming, CI exclusion, and complete local verification.
Met: Forgejo CI run #414 passed with the new split.

Quality

Blocking issues: none.
Warnings: none.
Verification: npm run test:ci, ./scripts/pre-pr.sh, and Forgejo CI passed.

Final verdict: approved.

### Review update - PR: #265 open; CI run #414 passed. - Result: approved. - Scope: Adds an explicit integration-test filename convention and keeps the complete suite local while ordinary CI runs deterministic tests. #### Acceptance criteria - **Met:** `*.integration.test.ts` clearly identifies signed-request, queue, delivery, and federation-processing tests. - **Met:** Forgejo CI uses `npm run test:ci`, which excludes the integration-test glob. - **Met:** Fast ActivityPub actor, configuration, and key tests retain the ordinary `.test.ts` suffix and run in CI. - **Met:** `./scripts/pre-pr.sh` still invokes complete `npm test`; 301 template tests passed locally. - **Met:** `docs/CONTRIBUTING.md` documents naming, CI exclusion, and complete local verification. - **Met:** Forgejo CI run #414 passed with the new split. #### Quality - Blocking issues: none. - Warnings: none. - Verification: `npm run test:ci`, `./scripts/pre-pr.sh`, and Forgejo CI passed. **Final verdict: approved.**

erik merged commit a0c35914a4 into main

2026-07-22 07:05:39 -05:00

erik deleted branch fix/task-eeedea6d-activitypub-ci-tests

2026-07-22 07:05:39 -05:00

erik referenced this pull request from a commit

2026-07-22 07:05:40 -05:00

Merge pull request 'fix: keep ActivityPub integration tests local' (#265) from fix/task-eeedea6d-activitypub-ci-tests into main