Fix link post excerpt placement #272

Merged
erik merged 1 commit from fix/task-36698d6d-link-excerpt-placement into main 2026-07-24 14:48:27 -05:00
Owner

Summary

Place link-post commentary before the external preview on post detail pages, matching the established feed layout.

Task

Task: #task-36698d6d

Changes

  • Render link post Markdown content before FeedLinkPreview on /posts/{slug}.
  • Preserve the existing article and note ordering.
  • Add regression assertions that detail and feed pages both place commentary before preview metadata.

Testing

  • Unit tests added/updated
  • Manual testing performed with /posts/audience-of-one
  • Focused public route tests pass
  • Full local suite passes: 127 CLI tests and 306 site tests

Checklist

  • ./scripts/pre-pr.sh passes
  • Documentation updated (not needed; bug fix restores documented behavior)
  • No unrelated changes included
## Summary Place link-post commentary before the external preview on post detail pages, matching the established feed layout. ## Task Task: #task-36698d6d ## Changes - Render link post Markdown content before `FeedLinkPreview` on `/posts/{slug}`. - Preserve the existing article and note ordering. - Add regression assertions that detail and feed pages both place commentary before preview metadata. ## Testing - [x] Unit tests added/updated - [x] Manual testing performed with `/posts/audience-of-one` - [x] Focused public route tests pass - [x] Full local suite passes: 127 CLI tests and 306 site tests ## Checklist - [x] `./scripts/pre-pr.sh` passes - [x] Documentation updated (not needed; bug fix restores documented behavior) - [x] No unrelated changes included
fix: place link commentary before preview
All checks were successful
CI / build-lint-test (pull_request) Successful in 2m11s
73df68f934
Task: #task-36698d6d
Author
Owner

Independent review

Summary

The scoped change renders link-post Markdown commentary before FeedLinkPreview on detail pages, matching the existing /feed sequence (FeedTextPost followed by FeedLinkPreview). The non-link branch preserves the prior article/note order: PostExternalLink (a no-op for those types) followed by the same post content.

Acceptance criteria

  • Met: Link post excerpts/commentary appear above the preview on /posts/{slug}. The detail regression assertion verifies commentary precedes preview metadata.
  • Met: The layout matches link posts on /feed. A corresponding feed assertion verifies the same ordering.

Behavior and verification

  • Article behavior remains unchanged by the equivalent non-link render branch.
  • Note behavior remains unchanged by the equivalent non-link render branch.
  • Full PR diff reviewed: 2 files, +22/-5, with no unrelated changes.
  • Site suite: 46 files / 306 tests passed.
  • Site typecheck passed.
  • Repository lint passed.
  • git diff --check passed.

Blockers: None.

Warnings: None.

Verdict: Approved. Awaiting explicit human merge approval; this review does not merge.

### Independent review **Summary** The scoped change renders link-post Markdown commentary before `FeedLinkPreview` on detail pages, matching the existing `/feed` sequence (`FeedTextPost` followed by `FeedLinkPreview`). The non-link branch preserves the prior article/note order: `PostExternalLink` (a no-op for those types) followed by the same post content. **Acceptance criteria** - [x] **Met:** Link post excerpts/commentary appear above the preview on `/posts/{slug}`. The detail regression assertion verifies commentary precedes preview metadata. - [x] **Met:** The layout matches link posts on `/feed`. A corresponding feed assertion verifies the same ordering. **Behavior and verification** - Article behavior remains unchanged by the equivalent non-link render branch. - Note behavior remains unchanged by the equivalent non-link render branch. - Full PR diff reviewed: 2 files, +22/-5, with no unrelated changes. - Site suite: 46 files / 306 tests passed. - Site typecheck passed. - Repository lint passed. - `git diff --check` passed. **Blockers:** None. **Warnings:** None. **Verdict:** Approved. Awaiting explicit human merge approval; this review does not merge.
erik merged commit 9b9d91f805 into main 2026-07-24 14:48:27 -05:00
erik deleted branch fix/task-36698d6d-link-excerpt-placement 2026-07-24 14:48:27 -05:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
erik/slugkit!272
No description provided.