fix: dispatch CLI release by workflow filename #293

Merged
erik merged 1 commit from fix/task-feefc621-release-workflow-id into main 2026-10-04 21:16:01 -05:00
Owner

Summary

  • One-line release helper fix: WORKFLOW="release-slug-cli.yml" instead of the display name "Release slug CLI".
  • Clarify the file identifier in the release skill and documentation.
  • Add a small static regression assertion in the existing release tests.

Verification

  • Static regression failed against the original helper and passes after the fix.
  • bash -n .pi/skills/cli-release/scripts/release.sh passed.
  • Local-only execution checks exercised the unchanged helper using stubbed git/fj commands: dry-run reports release-slug-cli.yml and never calls fj; non-dry-run invokes fj with exact host, filename, main ref, repository, inferred version and publish_to_npm=true; --no-publish invokes the same filename with publish_to_npm=false.
  • All git/fj commands were intercepted by temporary stubs. No workflow was dispatched, release created, tag pushed or npm package published.
  • Execution evidence: /tmp/slugkit-release-id-execution.log; one-off shell verification: /tmp/slugkit-verify-release-id.sh. No execution-test infrastructure was added to the repository or CI.
  • ./scripts/pre-pr.sh passed: CSS, formatting, lint, types and 1,086 local tests (505 CLI).
  • git diff --check passed.

No workflow/dependency changes. CI remains unit-only and never runs integration tests.

Task: #task-feefc621

Awaiting CI, independent review and explicit human merge approval.

## Summary - One-line release helper fix: WORKFLOW="release-slug-cli.yml" instead of the display name "Release slug CLI". - Clarify the file identifier in the release skill and documentation. - Add a small static regression assertion in the existing release tests. ## Verification - Static regression failed against the original helper and passes after the fix. - bash -n .pi/skills/cli-release/scripts/release.sh passed. - Local-only execution checks exercised the unchanged helper using stubbed git/fj commands: dry-run reports release-slug-cli.yml and never calls fj; non-dry-run invokes fj with exact host, filename, main ref, repository, inferred version and publish_to_npm=true; --no-publish invokes the same filename with publish_to_npm=false. - All git/fj commands were intercepted by temporary stubs. No workflow was dispatched, release created, tag pushed or npm package published. - Execution evidence: /tmp/slugkit-release-id-execution.log; one-off shell verification: /tmp/slugkit-verify-release-id.sh. No execution-test infrastructure was added to the repository or CI. - ./scripts/pre-pr.sh passed: CSS, formatting, lint, types and 1,086 local tests (505 CLI). - git diff --check passed. No workflow/dependency changes. CI remains unit-only and never runs integration tests. Task: #task-feefc621 Awaiting CI, independent review and explicit human merge approval.
fix: dispatch CLI release by workflow filename
All checks were successful
CI / build-lint-test (pull_request) Successful in 56s
83366d26b2
Use the Forgejo-compatible file identifier rather than the workflow display name, which returns HTTP 500. Keep release docs aligned and guard the dispatch identifier without triggering a release.

Task: #task-feefc621
Author
Owner

Review update

  • PR: #293 (fix/task-feefc621-release-workflow-id -> main), open.
  • Result: approved.
  • Follow-up: wait for explicit human merge approval; do not merge from this review.

Summary

The PR makes the requested minimal fix: the CLI release helper now dispatches Forgejo Actions by workflow file identifier (release-slug-cli.yml) while preserving the existing dispatch flow. The release skill and docs now call out the file identifier, and the added static regression assertion plus provided local stub evidence cover the identifier behavior without adding workflow, dependency, infrastructure, or release-logic changes.

Acceptance criteria

  • The release helper dispatches the workflow using a Forgejo-compatible identifier.
    • .pi/skills/cli-release/scripts/release.sh sets WORKFLOW="release-slug-cli.yml" and the dispatch command still uses actions dispatch "$WORKFLOW" "$REF".
  • A dry-run and actual dispatch path are covered or otherwise verified.
    • Reviewed /tmp/slugkit-release-id-red.log, /tmp/slugkit-release-id-green.log, /tmp/slugkit-release-id-execution.log, and /tmp/slugkit-verify-release-id.sh; the local stub verification exercises dry-run and non-dry-run publish/no-publish paths with all git/fj calls intercepted.
  • Release documentation/skill guidance remains accurate.
    • .pi/skills/cli-release/SKILL.md and docs/cli-release.md clarify that fj actions dispatch should use release-slug-cli.yml, not the display name.

Blocking issues

  • None.

Warnings

  • None.

Artifact identifiers

  • Task: task-feefc621
  • PR: Forgejo PR #293
  • Commit/CI: Actions #497 at 83366d26b2 reported succeeded
  • Evidence reviewed: /tmp/slugkit-release-id-red.log, /tmp/slugkit-release-id-green.log, /tmp/slugkit-release-id-execution.log, /tmp/slugkit-verify-release-id.sh, /tmp/slugkit-release-id-pre-pr.log

Final verdict

Approved. Required artifacts posted; awaiting explicit human merge approval.

PR Review Worker Result
- pr: open
- review: approved
- pr_comment: posted
- task_comment: posted
- blocking_issues: 0
- warnings: 0
- criteria_total: 3
- criteria_met: 3
- criteria_missing: 0
### Review update - PR: #293 (`fix/task-feefc621-release-workflow-id` -> `main`), open. - Result: approved. - Follow-up: wait for explicit human merge approval; do not merge from this review. #### Summary The PR makes the requested minimal fix: the CLI release helper now dispatches Forgejo Actions by workflow file identifier (`release-slug-cli.yml`) while preserving the existing dispatch flow. The release skill and docs now call out the file identifier, and the added static regression assertion plus provided local stub evidence cover the identifier behavior without adding workflow, dependency, infrastructure, or release-logic changes. #### Acceptance criteria - [x] The release helper dispatches the workflow using a Forgejo-compatible identifier. - `.pi/skills/cli-release/scripts/release.sh` sets `WORKFLOW="release-slug-cli.yml"` and the dispatch command still uses `actions dispatch "$WORKFLOW" "$REF"`. - [x] A dry-run and actual dispatch path are covered or otherwise verified. - Reviewed `/tmp/slugkit-release-id-red.log`, `/tmp/slugkit-release-id-green.log`, `/tmp/slugkit-release-id-execution.log`, and `/tmp/slugkit-verify-release-id.sh`; the local stub verification exercises dry-run and non-dry-run publish/no-publish paths with all `git`/`fj` calls intercepted. - [x] Release documentation/skill guidance remains accurate. - `.pi/skills/cli-release/SKILL.md` and `docs/cli-release.md` clarify that `fj actions dispatch` should use `release-slug-cli.yml`, not the display name. #### Blocking issues - None. #### Warnings - None. #### Artifact identifiers - Task: `task-feefc621` - PR: Forgejo PR #293 - Commit/CI: Actions #497 at `83366d26b2` reported succeeded - Evidence reviewed: `/tmp/slugkit-release-id-red.log`, `/tmp/slugkit-release-id-green.log`, `/tmp/slugkit-release-id-execution.log`, `/tmp/slugkit-verify-release-id.sh`, `/tmp/slugkit-release-id-pre-pr.log` #### Final verdict Approved. Required artifacts posted; awaiting explicit human merge approval. ```text PR Review Worker Result - pr: open - review: approved - pr_comment: posted - task_comment: posted - blocking_issues: 0 - warnings: 0 - criteria_total: 3 - criteria_met: 3 - criteria_missing: 0 ```
erik merged commit f0d11d1509 into main 2026-10-04 21:16:01 -05:00
erik deleted branch fix/task-feefc621-release-workflow-id 2026-10-04 21:16:01 -05:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
erik/slugkit!293
No description provided.