fix: correct Forgejo release asset deletion endpoint #307

Merged

erik merged 1 commit from fix/task-8e7134b9-template-asset-delete into main

2026-10-26 15:42:20 -05:00

erik commented

2026-10-26 15:39:20 -05:00

Owner

Summary

Include the parent release ID in the Forgejo asset-delete endpoint used by the general publisher.
Apply the identical route correction to both legacy recovery workflows.
Assert the exact replacement URL and stop without upload/retry when deletion fails.

Evidence and verification

Regression failed before the fix: expected /releases/20/assets/21, received /releases/assets/21. It passes after the correction.
Read-only live GET checks on existing template asset 57: /releases/assets/57 returned 404; /releases/60/assets/57 returned 200. No remote deletion/publication was attempted.
./scripts/pre-pr.sh passed all checks and 1,338 local tests, including integration coverage.
CI remains test:ci only; no integration/browser/container testing added.

Release state

The user explicitly requested a release and approved this blocking publisher fix. Publishing remains paused until this normal PR passes CI/review and receives human merge approval.
No changelog or artifact versions are created in this implementation PR. Resume the already-requested release only after this fix is merged.

Task: #task-8e7134b9

## Summary - Include the parent release ID in the Forgejo asset-delete endpoint used by the general publisher. - Apply the identical route correction to both legacy recovery workflows. - Assert the exact replacement URL and stop without upload/retry when deletion fails. ## Evidence and verification - Regression failed before the fix: expected /releases/20/assets/21, received /releases/assets/21. It passes after the correction. - Read-only live GET checks on existing template asset 57: /releases/assets/57 returned 404; /releases/60/assets/57 returned 200. No remote deletion/publication was attempted. - ./scripts/pre-pr.sh passed all checks and 1,338 local tests, including integration coverage. - CI remains test:ci only; no integration/browser/container testing added. ## Release state - The user explicitly requested a release and approved this blocking publisher fix. Publishing remains paused until this normal PR passes CI/review and receives human merge approval. - No changelog or artifact versions are created in this implementation PR. Resume the already-requested release only after this fix is merged. Task: #task-8e7134b9

Rows
Columns