erik/slugkit

Fork 0

Implement contacts API routes #68

Merged

caradoc merged 1 commit from feat/task-24864d2a-contacts-api into main

2026-05-23 15:19:43 -05:00

caradoc commented

2026-05-23 15:06:43 -05:00

Collaborator

Summary

Add authenticated contacts CRUD API routes
Document contacts routes and schemas in OpenAPI
Add contacts route tests for auth, validation, not found, delete conflicts, and OpenAPI coverage
Remove Bun from README prerequisites

Verification

./scripts/pre-pr.sh

Task: #task-24864d2a

## Summary - Add authenticated contacts CRUD API routes - Document contacts routes and schemas in OpenAPI - Add contacts route tests for auth, validation, not found, delete conflicts, and OpenAPI coverage - Remove Bun from README prerequisites ## Verification - ./scripts/pre-pr.sh Task: #task-24864d2a

caradoc added 1 commit

2026-05-23 15:06:43 -05:00

feat: add contacts API routes

CI / build-lint-test (pull_request) Successful in 30s

Details

9f3fa19bfa

Task: #task-24864d2a

caradoc commented

2026-05-23 15:08:06 -05:00

Author

Collaborator

Review summary

Approved. The PR adds authenticated contacts CRUD routes, service logic, OpenAPI coverage, and tests that align with docs/specs/04-contacts-routes.md and the task acceptance criteria. CI is green.

Acceptance criteria

Can list contacts — covered by GET /api/v1/contacts and tests.
Can create a contact — covered by POST /api/v1/contacts and tests.
Can get a contact by ID — covered by GET /api/v1/contacts/{id} and tests.
Can update a contact — covered by PUT /api/v1/contacts/{id} and tests.
Can delete a contact or receive documented conflict behavior — covered by delete and FK conflict tests.
Contact responses may include account summaries/default account as documented — account embedding is not required until accounts exist; current response matches the contacts spec shape.
Invalid URLs and missing required fields return shared validation errors — covered by tests.
Every contacts route appears in OpenAPI with documented operation IDs — covered by route/OpenAPI tests.
Relevant lint/test checks pass — ./scripts/pre-pr.sh passed and CI is green.

Blocking issues

None.

Warnings

None.

Verdict

Approved; waiting for explicit human merge approval.

## Review summary Approved. The PR adds authenticated contacts CRUD routes, service logic, OpenAPI coverage, and tests that align with `docs/specs/04-contacts-routes.md` and the task acceptance criteria. CI is green. ## Acceptance criteria - [x] Can list contacts — covered by `GET /api/v1/contacts` and tests. - [x] Can create a contact — covered by `POST /api/v1/contacts` and tests. - [x] Can get a contact by ID — covered by `GET /api/v1/contacts/{id}` and tests. - [x] Can update a contact — covered by `PUT /api/v1/contacts/{id}` and tests. - [x] Can delete a contact or receive documented conflict behavior — covered by delete and FK conflict tests. - [x] Contact responses may include account summaries/default account as documented — account embedding is not required until accounts exist; current response matches the contacts spec shape. - [x] Invalid URLs and missing required fields return shared validation errors — covered by tests. - [x] Every contacts route appears in OpenAPI with documented operation IDs — covered by route/OpenAPI tests. - [x] Relevant lint/test checks pass — `./scripts/pre-pr.sh` passed and CI is green. ## Blocking issues None. ## Warnings None. ## Verdict Approved; waiting for explicit human merge approval.

caradoc referenced this pull request

2026-05-23 15:08:15 -05:00

Implement contacts API routes #27

caradoc force-pushed feat/task-24864d2a-contacts-api from 9f3fa19bfa

CI / build-lint-test (pull_request) Successful in 30s

Details

to 494b98a80d

CI / build-lint-test (pull_request) Successful in 30s

Details

2026-05-23 15:17:40 -05:00

Compare

caradoc commented

2026-05-23 15:18:23 -05:00

Author

Collaborator

Review update

Approved after the Makefile/README follow-up. The latest commit removes the LAN IP dependency from make slug, uses the existing .slug/dev.yaml config when running the CLI, and switches CLI execution to npm exec --workspace @slugkit/cli -- slug, which matches the workspace setup.

Verification

make slug ARGS="--help" works with .slug/dev.yaml
./scripts/pre-pr.sh passed locally
CI is green on the latest commit

Blocking issues

None.

Warnings

None.

Verdict

Approved; waiting for explicit human merge approval.

## Review update Approved after the Makefile/README follow-up. The latest commit removes the LAN IP dependency from `make slug`, uses the existing `.slug/dev.yaml` config when running the CLI, and switches CLI execution to `npm exec --workspace @slugkit/cli -- slug`, which matches the workspace setup. ## Verification - `make slug ARGS="--help"` works with `.slug/dev.yaml` - `./scripts/pre-pr.sh` passed locally - CI is green on the latest commit ## Blocking issues None. ## Warnings None. ## Verdict Approved; waiting for explicit human merge approval.

caradoc merged commit f30abfee50 into main

2026-05-23 15:19:43 -05:00

caradoc deleted branch feat/task-24864d2a-contacts-api

2026-05-23 15:19:43 -05:00

caradoc referenced this pull request from a commit

2026-05-23 15:19:44 -05:00

Merge pull request 'Implement contacts API routes' (#68) from feat/task-24864d2a-contacts-api into main

caradoc referenced this pull request

2026-05-23 15:23:29 -05:00

Implement contacts API routes #27

caradoc referenced this pull request

2026-05-23 15:23:29 -05:00