Fix ActivityPub settings page width #170

New issue

Closed

opened 2026-06-20 08:59:12 -05:00 by erik · 2 comments

erik commented

2026-06-20 08:59:12 -05:00

Owner

Summary

The Settings → ActivityPub screen renders at a different width than the other settings/admin screens.

Steps to reproduce

Open Slugkit settings.
Navigate between the General, Passkeys, API keys, Site users, and ActivityPub screens.
Compare the content width/layout on the ActivityPub screen against the other settings screens.

Expected behavior

The ActivityPub settings screen uses the same content width and layout constraints as the other settings screens.

Actual behavior

The ActivityPub settings screen appears at a different width than the rest of the settings/admin screens.

Acceptance criteria

The ActivityPub settings screen matches the width/layout constraints used by the other settings screens.
A regression test or snapshot/assertion covers the shared layout expectation where practical.

## Summary The Settings → ActivityPub screen renders at a different width than the other settings/admin screens. ## Steps to reproduce 1. Open Slugkit settings. 2. Navigate between the General, Passkeys, API keys, Site users, and ActivityPub screens. 3. Compare the content width/layout on the ActivityPub screen against the other settings screens. ## Expected behavior - The ActivityPub settings screen uses the same content width and layout constraints as the other settings screens. ## Actual behavior - The ActivityPub settings screen appears at a different width than the rest of the settings/admin screens. ## Acceptance criteria - [ ] The ActivityPub settings screen matches the width/layout constraints used by the other settings screens. - [ ] A regression test or snapshot/assertion covers the shared layout expectation where practical.

erik added the

status:active

bug

priority:medium

labels

2026-06-20 08:59:12 -05:00

erik added

status:inprogress

and removed

status:active

labels

2026-06-20 20:52:28 -05:00

erik commented

2026-06-20 20:57:58 -05:00

Author

Owner

Synced from todu comment by @todu on 2026-06-21T01:53:51.061Z

Review update

PR: #172 is open and reviewed.
Result: approved; no blocking issues or warnings.
Acceptance criteria: 2/2 met.
Verified: npm test --workspace @slugkit/template-site -- src/routes/__tests__/admin-activitypub.test.ts, npm run build --workspace @slugkit/template-site, ./scripts/pre-pr.sh, and Forgejo Actions run #237.
Follow-up: waiting for explicit human merge approval.

_Synced from todu comment by @todu on 2026-06-21T01:53:51.061Z_ ### Review update - PR: https://forge.caradoc.com/erik/slugkit/pulls/172 is open and reviewed. - Result: approved; no blocking issues or warnings. - Acceptance criteria: 2/2 met. - Verified: `npm test --workspace @slugkit/template-site -- src/routes/__tests__/admin-activitypub.test.ts`, `npm run build --workspace @slugkit/template-site`, `./scripts/pre-pr.sh`, and Forgejo Actions run #237. - Follow-up: waiting for explicit human merge approval.

erik

2026-06-20 21:03:28 -05:00

closed this issue
added
status:done
and removed
status:inprogress
labels

erik commented

2026-06-20 21:03:28 -05:00

Author

Owner

Synced from todu comment by @todu on 2026-06-21T01:58:16.519Z

Closing summary

PR #172 was merged into main.

Acceptance criteria:

ActivityPub settings screen matches the width/layout constraints used by the other settings screens — met by removing the max-w-7xl override so the shared renderAdminPage default max-w-6xl applies.
Regression test or assertion covers the shared layout expectation where practical — met by asserting the ActivityPub settings HTML contains max-w-6xl and does not contain max-w-7xl.

Verification:

npm test --workspace @slugkit/template-site -- src/routes/__tests__/admin-activitypub.test.ts
npm run build --workspace @slugkit/template-site
./scripts/pre-pr.sh
Forgejo Actions run #237 passed.

Readiness: READY. Closing task.

_Synced from todu comment by @todu on 2026-06-21T01:58:16.519Z_ ### Closing summary PR #172 was merged into `main`. Acceptance criteria: - ActivityPub settings screen matches the width/layout constraints used by the other settings screens — met by removing the `max-w-7xl` override so the shared `renderAdminPage` default `max-w-6xl` applies. - Regression test or assertion covers the shared layout expectation where practical — met by asserting the ActivityPub settings HTML contains `max-w-6xl` and does not contain `max-w-7xl`. Verification: - `npm test --workspace @slugkit/template-site -- src/routes/__tests__/admin-activitypub.test.ts` - `npm run build --workspace @slugkit/template-site` - `./scripts/pre-pr.sh` - Forgejo Actions run #237 passed. Readiness: READY. Closing task.