Fix ActivityPub settings page width #172

Merged
erik merged 1 commit from fix/task-4927ca9f-activitypub-width into main 2026-06-20 20:56:23 -05:00
Owner

Summary

  • Remove the ActivityPub settings page's custom max-w-7xl layout override so it uses the shared settings width.
  • Add a regression assertion that the ActivityPub settings screen renders with the standard max-w-6xl container and not max-w-7xl.

Verification

  • npm test --workspace @slugkit/template-site -- src/routes/__tests__/admin-activitypub.test.ts
  • npm run build --workspace @slugkit/template-site
  • ./scripts/pre-pr.sh
## Summary - Remove the ActivityPub settings page's custom `max-w-7xl` layout override so it uses the shared settings width. - Add a regression assertion that the ActivityPub settings screen renders with the standard `max-w-6xl` container and not `max-w-7xl`. ## Verification - `npm test --workspace @slugkit/template-site -- src/routes/__tests__/admin-activitypub.test.ts` - `npm run build --workspace @slugkit/template-site` - `./scripts/pre-pr.sh`
fix: align ActivityPub settings width
All checks were successful
CI / build-lint-test (pull_request) Successful in 49s
f9429111b7
Task: #task-4927ca9f
Author
Owner

PR Review: Approved

Summary

This PR removes the ActivityPub settings page's custom max-w-7xl override so it uses the shared settings page default width, and adds a regression assertion covering the expected layout class.

Acceptance criteria

  • The ActivityPub settings screen matches the width/layout constraints used by the other settings screens — met: renderActivityPubAdminPage no longer passes maxWidthClass: "max-w-7xl", so renderAdminPage uses the shared max-w-6xl default.
  • A regression test or snapshot/assertion covers the shared layout expectation where practical — met: admin-activitypub.test.ts asserts the rendered page contains max-w-6xl and does not contain max-w-7xl.

Blocking issues

None.

Warnings

None.

Verification

  • npm test --workspace @slugkit/template-site -- src/routes/__tests__/admin-activitypub.test.ts
  • npm run build --workspace @slugkit/template-site
  • ./scripts/pre-pr.sh
  • Forgejo Actions run #237 passed.

Verdict

Approved. Stop at the human merge gate.

PR Review Worker Result

  • pr: open
  • review: approved
  • pr_comment: posted
  • task_comment: posted
  • blocking_issues: 0
  • warnings: 0
  • criteria_total: 2
  • criteria_met: 2
  • criteria_missing: 0
## PR Review: Approved ### Summary This PR removes the ActivityPub settings page's custom `max-w-7xl` override so it uses the shared settings page default width, and adds a regression assertion covering the expected layout class. ### Acceptance criteria - [x] The ActivityPub settings screen matches the width/layout constraints used by the other settings screens — met: `renderActivityPubAdminPage` no longer passes `maxWidthClass: "max-w-7xl"`, so `renderAdminPage` uses the shared `max-w-6xl` default. - [x] A regression test or snapshot/assertion covers the shared layout expectation where practical — met: `admin-activitypub.test.ts` asserts the rendered page contains `max-w-6xl` and does not contain `max-w-7xl`. ### Blocking issues None. ### Warnings None. ### Verification - `npm test --workspace @slugkit/template-site -- src/routes/__tests__/admin-activitypub.test.ts` - `npm run build --workspace @slugkit/template-site` - `./scripts/pre-pr.sh` - Forgejo Actions run #237 passed. ### Verdict Approved. Stop at the human merge gate. PR Review Worker Result - pr: open - review: approved - pr_comment: posted - task_comment: posted - blocking_issues: 0 - warnings: 0 - criteria_total: 2 - criteria_met: 2 - criteria_missing: 0
erik merged commit c8613fdb45 into main 2026-06-20 20:56:23 -05:00
erik deleted branch fix/task-4927ca9f-activitypub-width 2026-06-20 20:56:23 -05:00
Sign in to join this conversation.
No description provided.