Fix ActivityPub settings page width #172
No reviewers
Labels
No labels
activitypub
admin
api
articles
auth
bug
cleanup
cli
comments
compatibility
config
contacts
database
deployment
design
dev-env
docs
documentation
email
enhancement
feature
federation
feed
homepage
implementation
integration
media
openapi
priority:high
priority:low
priority:medium
proof
public-routes
public-ui
release
safety
social
sources
status:active
status:canceled
status:done
status:inprogress
status:waiting
syndication
tailwind
template
test
web
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
erik/slugkit!172
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "fix/task-4927ca9f-activitypub-width"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
max-w-7xllayout override so it uses the shared settings width.max-w-6xlcontainer and notmax-w-7xl.Verification
npm test --workspace @slugkit/template-site -- src/routes/__tests__/admin-activitypub.test.tsnpm run build --workspace @slugkit/template-site./scripts/pre-pr.shPR Review: Approved
Summary
This PR removes the ActivityPub settings page's custom
max-w-7xloverride so it uses the shared settings page default width, and adds a regression assertion covering the expected layout class.Acceptance criteria
renderActivityPubAdminPageno longer passesmaxWidthClass: "max-w-7xl", sorenderAdminPageuses the sharedmax-w-6xldefault.admin-activitypub.test.tsasserts the rendered page containsmax-w-6xland does not containmax-w-7xl.Blocking issues
None.
Warnings
None.
Verification
npm test --workspace @slugkit/template-site -- src/routes/__tests__/admin-activitypub.test.tsnpm run build --workspace @slugkit/template-site./scripts/pre-pr.shVerdict
Approved. Stop at the human merge gate.
PR Review Worker Result