erik/slugkit
1
0
Fork 0
Code Issues 6 Pull requests Projects Releases 6 Packages Wiki Activity Actions

Update footer and sidebar navigation #195

Merged
erik merged 2 commits from feat/task-143d2b0d-footer-sidebar-navigation into main 2026-06-22 16:17:53 -05:00
Conversation 3 Commits 2 Files changed 4 +147 -35
erik commented 2026-06-22 13:37:19 -05:00
Owner
Copy link

Summary

Update footer navigation sections and sidebar ordering for feed/tag pages.

Task

Task: #task-143d2b0d

Changes

  • Added structured footer sections for site navigation and resources.
  • Site footer links now include Articles, Recommended Sites, Contacts, Tags, and Feed.
  • Resource footer links use configured footer links for OpenAPI / Swagger and Git repository.
  • Updated default footer link labels to match the resource section wording.
  • Updated sidebar ordering so /feed starts with Feed and /tags/{tag} starts with Tags.
  • Added public page tests for footer sections/links and sidebar ordering.

Testing

  • Unit tests added/updated
  • Manual testing performed

Verification:

  • npm exec --workspace @slugkit/template-site -- vitest run --config ../../vitest.config.ts src/routes/__tests__/public.test.ts src/__tests__/app.test.ts
  • ./scripts/pre-pr.sh
  • npm run build && npm run lint && npm test

Checklist

  • ./scripts/pre-pr.sh passes
  • Documentation updated (if needed)
  • No unrelated changes included
## Summary Update footer navigation sections and sidebar ordering for feed/tag pages. ## Task Task: #task-143d2b0d ## Changes - Added structured footer sections for site navigation and resources. - Site footer links now include Articles, Recommended Sites, Contacts, Tags, and Feed. - Resource footer links use configured footer links for OpenAPI / Swagger and Git repository. - Updated default footer link labels to match the resource section wording. - Updated sidebar ordering so `/feed` starts with Feed and `/tags/{tag}` starts with Tags. - Added public page tests for footer sections/links and sidebar ordering. ## Testing - [x] Unit tests added/updated - [x] Manual testing performed Verification: - `npm exec --workspace @slugkit/template-site -- vitest run --config ../../vitest.config.ts src/routes/__tests__/public.test.ts src/__tests__/app.test.ts` - `./scripts/pre-pr.sh` - `npm run build && npm run lint && npm test` ## Checklist - [x] `./scripts/pre-pr.sh` passes - [x] Documentation updated (if needed) - [x] No unrelated changes included
feat: update footer and sidebar navigation
All checks were successful
CI / build-lint-test (pull_request) Successful in 46s
Details
0466883c31 
Task: #task-143d2b0d
erik commented 2026-06-22 13:39:01 -05:00
Author
Owner
Copy link

PR Review

Summary: Reviewed PR #195 against task task-143d2b0d, the PR body, diff, and Forgejo Actions run #269.

Acceptance criteria:

  • Footer includes Articles, Recommended Sites, Contacts, Tags, and Feed links.
  • Footer includes OpenAPI / Swagger docs and Git repository website links.
  • Sidebar navigation uses the shared PublicSidebar / SidebarNavigationCard sections across affected public pages.
  • Sidebar prioritizes the current page section at the top for updated pages.
  • /tags/{tagname} renders the Tags sidebar section before Feed.

Verification:

  • PR is open.
  • PR body references task-143d2b0d and lists relevant changes/tests.
  • Diff is scoped to footer/sidebar updates plus tests/config label updates.
  • Forgejo Actions #269: success (build-lint-test, pull_request).

Blocking issues: none.
Warnings: none.

Final verdict: approved. Do not merge until human merge approval.

## PR Review Summary: Reviewed PR #195 against task `task-143d2b0d`, the PR body, diff, and Forgejo Actions run #269. Acceptance criteria: - [x] Footer includes Articles, Recommended Sites, Contacts, Tags, and Feed links. - [x] Footer includes OpenAPI / Swagger docs and Git repository website links. - [x] Sidebar navigation uses the shared `PublicSidebar` / `SidebarNavigationCard` sections across affected public pages. - [x] Sidebar prioritizes the current page section at the top for updated pages. - [x] `/tags/{tagname}` renders the Tags sidebar section before Feed. Verification: - PR is open. - PR body references `task-143d2b0d` and lists relevant changes/tests. - Diff is scoped to footer/sidebar updates plus tests/config label updates. - Forgejo Actions #269: success (`build-lint-test`, pull_request). Blocking issues: none. Warnings: none. Final verdict: approved. Do not merge until human merge approval.
feat: refine public footer and sidebar navigation
All checks were successful
CI / build-lint-test (pull_request) Successful in 48s
Details
0e01d80408 
Task: #task-143d2b0d
erik commented 2026-06-22 16:14:30 -05:00
Author
Owner
Copy link

PR Review: #195

Summary: Reviewed task task-143d2b0d, PR body/diff after 0e01d80, local targeted tests, and Forgejo Actions #270 (build-lint-test, success).

Acceptance criteria:

  • Footer includes the requested site navigation links.
  • Footer includes OpenAPI / Swagger docs and Git repository website links.
  • Sidebar navigation uses consistent sections across relevant pages.
  • Sidebar prioritizes the current page’s section at the top.
  • /tags/{tagname} shows the tags section first in the sidebar.

Blocking issues:

  1. Sidebar criteria are still not satisfied. The diff only renders PublicSidebar for feed content, with links={["articles", "sources", "tags"]} and no Feed-first section. Tag detail replaces the shared sidebar with only a single TagCard, so /tags/{tagname} does not show a consistent sidebar with the Tags section first; it omits the other navigation sections entirely.

Warnings: none.

Verification:

  • PR is open and scoped to the task.
  • PR body includes task reference, changes, and local verification notes.
  • Local targeted tests passed: npm exec --workspace @slugkit/template-site -- vitest run --config ../../vitest.config.ts src/routes/__tests__/public.test.ts src/__tests__/app.test.ts (2 files, 18 tests).
  • Forgejo Actions #270: success (build-lint-test, commit 0e01d80).

Verdict: changes requested; do not merge until the shared sidebar/navigation ordering criteria are implemented.

## PR Review: #195 Summary: Reviewed task `task-143d2b0d`, PR body/diff after `0e01d80`, local targeted tests, and Forgejo Actions #270 (`build-lint-test`, success). Acceptance criteria: - [x] Footer includes the requested site navigation links. - [x] Footer includes OpenAPI / Swagger docs and Git repository website links. - [ ] Sidebar navigation uses consistent sections across relevant pages. - [ ] Sidebar prioritizes the current page’s section at the top. - [ ] `/tags/{tagname}` shows the tags section first in the sidebar. Blocking issues: 1. Sidebar criteria are still not satisfied. The diff only renders `PublicSidebar` for feed content, with `links={["articles", "sources", "tags"]}` and no Feed-first section. Tag detail replaces the shared sidebar with only a single `TagCard`, so `/tags/{tagname}` does not show a consistent sidebar with the Tags section first; it omits the other navigation sections entirely. Warnings: none. Verification: - PR is open and scoped to the task. - PR body includes task reference, changes, and local verification notes. - Local targeted tests passed: `npm exec --workspace @slugkit/template-site -- vitest run --config ../../vitest.config.ts src/routes/__tests__/public.test.ts src/__tests__/app.test.ts` (2 files, 18 tests). - Forgejo Actions #270: success (`build-lint-test`, commit `0e01d80`). Verdict: changes requested; do not merge until the shared sidebar/navigation ordering criteria are implemented.
erik commented 2026-06-22 16:16:55 -05:00
Author
Owner
Copy link

Corrective PR Review: #195

Summary: Re-reviewed PR #195 after commit 0e01d80 using the final human-approved sidebar/footer scope. This supersedes my earlier changes-requested sidebar note: the final scope intentionally removes public sidebars from /articles, /contacts, /sources, /sources/{id}, and /tags, keeps only /feed with a sidebar that excludes a Feed self-card, and uses a contact-detail-style layout for /tags/{tag}.

Acceptance criteria:

  • /feed has a public sidebar without a Feed self-card. renderFeedContent uses PublicSidebar with links={["articles", "sources", "tags"]}.
  • /articles, /contacts, /sources, /sources/{id}, and /tags have no public sidebar. PublicSidebar is only used by feed content, and targeted tests assert the removed sidebar links are absent on affected pages.
  • /tags/{tag} uses contact-detail-style layout with the tag card in the left rail and no public sidebar. The tag detail render now uses an <aside> with TagCard and does not render feed/sidebar navigation or RSS/account cards.
  • Footer Site links are ordered Feed, Articles, Contacts, Tags, Recommended Sites.
  • Footer Resources labels are API Documentation and Source Repository.
  • Settings footer links mirror accessible settings pages and are hidden when unauthenticated; viewer links include General, Passkeys, API keys, and admin links additionally include Site users and Actor.

Verification:

  • Inspected PR diff and updated tests for 0e01d80.
  • Local targeted tests passed: npm exec --workspace @slugkit/template-site -- vitest run --config ../../vitest.config.ts src/routes/__tests__/public.test.ts src/__tests__/app.test.ts (2 files, 18 tests).
  • Forgejo Actions #270 succeeded: build-lint-test on 0e01d80408.

Blocking issues: none.
Warnings: none.

Verdict: approved; awaiting explicit human merge approval. Do not merge without that approval.

## Corrective PR Review: #195 Summary: Re-reviewed PR #195 after commit `0e01d80` using the final human-approved sidebar/footer scope. This supersedes my earlier changes-requested sidebar note: the final scope intentionally removes public sidebars from `/articles`, `/contacts`, `/sources`, `/sources/{id}`, and `/tags`, keeps only `/feed` with a sidebar that excludes a Feed self-card, and uses a contact-detail-style layout for `/tags/{tag}`. Acceptance criteria: - [x] `/feed` has a public sidebar without a Feed self-card. `renderFeedContent` uses `PublicSidebar` with `links={["articles", "sources", "tags"]}`. - [x] `/articles`, `/contacts`, `/sources`, `/sources/{id}`, and `/tags` have no public sidebar. `PublicSidebar` is only used by feed content, and targeted tests assert the removed sidebar links are absent on affected pages. - [x] `/tags/{tag}` uses contact-detail-style layout with the tag card in the left rail and no public sidebar. The tag detail render now uses an `<aside>` with `TagCard` and does not render feed/sidebar navigation or RSS/account cards. - [x] Footer Site links are ordered Feed, Articles, Contacts, Tags, Recommended Sites. - [x] Footer Resources labels are `API Documentation` and `Source Repository`. - [x] Settings footer links mirror accessible settings pages and are hidden when unauthenticated; viewer links include General, Passkeys, API keys, and admin links additionally include Site users and Actor. Verification: - Inspected PR diff and updated tests for `0e01d80`. - Local targeted tests passed: `npm exec --workspace @slugkit/template-site -- vitest run --config ../../vitest.config.ts src/routes/__tests__/public.test.ts src/__tests__/app.test.ts` (2 files, 18 tests). - Forgejo Actions #270 succeeded: `build-lint-test` on `0e01d80408`. Blocking issues: none. Warnings: none. Verdict: approved; awaiting explicit human merge approval. Do not merge without that approval.
erik merged commit b9c078872e into main 2026-06-22 16:17:53 -05:00
erik deleted branch feat/task-143d2b0d-footer-sidebar-navigation 2026-06-22 16:17:53 -05:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
activitypub

   
admin

   
api

   
articles

   
auth

   
bug

   
cleanup

   
cli

   
comments

   
compatibility

   
config

   
contacts

   
database

   
deployment

   
design

   
dev-env

   
docs

   
documentation

   
email

   
enhancement

   
feature

   
federation

   
feed

   
homepage

   
implementation

   
integration

   
media

   
openapi

   
priority:high

   
priority:low

   
priority:medium

   
proof

   
public-routes

   
public-ui

   
release

   
safety

   
social

   
sources

   
status:active

   
status:canceled

   
status:done

   
status:inprogress

   
status:waiting

   
syndication

   
tailwind

   
template

   
test

   
web
No labels
activitypub
admin
api
articles
auth
bug
cleanup
cli
comments
compatibility
config
contacts
database
deployment
design
dev-env
docs
documentation
email
enhancement
feature
federation
feed
homepage
implementation
integration
media
openapi
priority:high
priority:low
priority:medium
proof
public-routes
public-ui
release
safety
social
sources
status:active
status:canceled
status:done
status:inprogress
status:waiting
syndication
tailwind
template
test
web
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
erik/slugkit!195
No description provided.